TheFurya/nuzlocke-tracker
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix HoF display for transfers/shinies and hook ordering

Browse Source 
Move alive and hofTeam into useMemo hooks above early returns to fix
React hook ordering violation. Include transfer and shiny encounters
in alive so they appear in the team section and can be selected for
the Hall of Fame.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Julian Tabel
2026-02-09 11:45:29 +01:00
parent c2e946f500
commit 4e00e3cad8
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
frontend/src/pages/RunEncounters.tsx
View File

@@ -620,12 +620,19 @@ export function RunEncounters() {
}
}, [organizedRoutes, encounterByRoute]) // eslint-disable-line react-hooks/exhaustive-deps
const alive = useMemo(
() => [...normalEncounters, ...transferEncounters, ...shinyEncounters].filter(
(e) => e.status === 'caught' && e.faintLevel === null,
),
[normalEncounters, transferEncounters, shinyEncounters],
)
// Resolve HoF team encounters from IDs
const hofTeam = useMemo(() => {
if (!run?.hofEncounterIds || run.hofEncounterIds.length === 0) return null
const idSet = new Set(run.hofEncounterIds)
return normalEncounters.filter((e) => idSet.has(e.id))
}, [run?.hofEncounterIds, normalEncounters])
return alive.filter((e) => idSet.has(e.id))
}, [run?.hofEncounterIds, alive])
if (isLoading || loadingRoutes) {
return (
@@ -679,9 +686,6 @@ export function RunEncounters() {
}
const isActive = run.status === 'active'
const alive = normalEncounters.filter(
(e) => e.status === 'caught' && e.faintLevel === null,
)
const dead = normalEncounters.filter(
(e) => e.status === 'caught' && e.faintLevel !== null,
)