feat: add is_admin column to users table
Add `is_admin` boolean column (default false) via Alembic migration for role-based access control. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1,10 +1,11 @@
|
|||||||
---
|
---
|
||||||
# nuzlocke-tracker-ce4o
|
# nuzlocke-tracker-ce4o
|
||||||
title: Auth-aware UI and role-based access control
|
title: Auth-aware UI and role-based access control
|
||||||
status: todo
|
status: completed
|
||||||
type: epic
|
type: epic
|
||||||
|
priority: normal
|
||||||
created_at: 2026-03-21T10:05:52Z
|
created_at: 2026-03-21T10:05:52Z
|
||||||
updated_at: 2026-03-21T10:05:52Z
|
updated_at: 2026-03-21T10:08:39Z
|
||||||
---
|
---
|
||||||
|
|
||||||
The app currently shows the same navigation menu to all users regardless of auth state. Logged-out users can navigate to protected pages (e.g., /runs/new, /admin) even though the backend rejects their requests. The admin interface has no role restriction — any authenticated user can access it.
|
The app currently shows the same navigation menu to all users regardless of auth state. Logged-out users can navigate to protected pages (e.g., /runs/new, /admin) even though the backend rejects their requests. The admin interface has no role restriction — any authenticated user can access it.
|
||||||
|
|||||||
@@ -1,10 +1,11 @@
|
|||||||
---
|
---
|
||||||
# nuzlocke-tracker-dwah
|
# nuzlocke-tracker-dwah
|
||||||
title: Add is_admin column to users table
|
title: Add is_admin column to users table
|
||||||
status: todo
|
status: completed
|
||||||
type: task
|
type: task
|
||||||
|
priority: normal
|
||||||
created_at: 2026-03-21T10:06:19Z
|
created_at: 2026-03-21T10:06:19Z
|
||||||
updated_at: 2026-03-21T10:06:19Z
|
updated_at: 2026-03-21T10:10:02Z
|
||||||
parent: nuzlocke-tracker-ce4o
|
parent: nuzlocke-tracker-ce4o
|
||||||
---
|
---
|
||||||
|
|
||||||
@@ -12,12 +13,31 @@ Add an `is_admin` boolean column (default `false`) to the `users` table via an A
|
|||||||
|
|
||||||
## Checklist
|
## Checklist
|
||||||
|
|
||||||
- [ ] Create Alembic migration adding `is_admin: Mapped[bool]` column with `server_default="false"`
|
- [x] Create Alembic migration adding `is_admin: Mapped[bool]` column with `server_default="false"`
|
||||||
- [ ] Update `User` model in `backend/src/app/models/user.py`
|
- [x] Update `User` model in `backend/src/app/models/user.py`
|
||||||
- [ ] Run migration and verify column exists
|
- [x] Run migration and verify column exists
|
||||||
- [ ] Seed a test admin user (or document how to set `is_admin=true` via SQL)
|
- [x] Seed a test admin user (or document how to set `is_admin=true` via SQL)
|
||||||
|
|
||||||
## Files to change
|
## Files to change
|
||||||
|
|
||||||
- `backend/src/app/models/user.py` — add `is_admin` field
|
- `backend/src/app/models/user.py` — add `is_admin` field
|
||||||
- `backend/src/app/alembic/versions/` — new migration
|
- `backend/src/app/alembic/versions/` — new migration
|
||||||
|
|
||||||
|
## Summary of Changes
|
||||||
|
|
||||||
|
Added `is_admin` boolean column to the `users` table:
|
||||||
|
|
||||||
|
- **Migration**: `p7e8f9a0b1c2_add_is_admin_to_users.py` adds the column with `server_default='false'`
|
||||||
|
- **Model**: Updated `User` model with `is_admin: Mapped[bool]` field
|
||||||
|
|
||||||
|
### Setting admin via SQL
|
||||||
|
|
||||||
|
To promote a user to admin:
|
||||||
|
```sql
|
||||||
|
UPDATE users SET is_admin = true WHERE email = 'admin@example.com';
|
||||||
|
```
|
||||||
|
|
||||||
|
Or by user ID:
|
||||||
|
```sql
|
||||||
|
UPDATE users SET is_admin = true WHERE id = '<uuid>';
|
||||||
|
```
|
||||||
|
|||||||
@@ -0,0 +1,29 @@
|
|||||||
|
"""add is_admin to users
|
||||||
|
|
||||||
|
Revision ID: p7e8f9a0b1c2
|
||||||
|
Revises: o6d7e8f9a0b1
|
||||||
|
Create Date: 2026-03-21 10:00:00.000000
|
||||||
|
|
||||||
|
"""
|
||||||
|
|
||||||
|
from collections.abc import Sequence
|
||||||
|
|
||||||
|
import sqlalchemy as sa
|
||||||
|
from alembic import op
|
||||||
|
|
||||||
|
# revision identifiers, used by Alembic.
|
||||||
|
revision: str = "p7e8f9a0b1c2"
|
||||||
|
down_revision: str | Sequence[str] | None = "o6d7e8f9a0b1"
|
||||||
|
branch_labels: str | Sequence[str] | None = None
|
||||||
|
depends_on: str | Sequence[str] | None = None
|
||||||
|
|
||||||
|
|
||||||
|
def upgrade() -> None:
|
||||||
|
op.add_column(
|
||||||
|
"users",
|
||||||
|
sa.Column("is_admin", sa.Boolean(), nullable=False, server_default="false"),
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def downgrade() -> None:
|
||||||
|
op.drop_column("users", "is_admin")
|
||||||
@@ -4,7 +4,7 @@ from datetime import datetime
|
|||||||
from typing import TYPE_CHECKING
|
from typing import TYPE_CHECKING
|
||||||
from uuid import UUID
|
from uuid import UUID
|
||||||
|
|
||||||
from sqlalchemy import DateTime, String, func
|
from sqlalchemy import Boolean, DateTime, String, func
|
||||||
from sqlalchemy.orm import Mapped, mapped_column, relationship
|
from sqlalchemy.orm import Mapped, mapped_column, relationship
|
||||||
|
|
||||||
from app.core.database import Base
|
from app.core.database import Base
|
||||||
@@ -19,6 +19,7 @@ class User(Base):
|
|||||||
id: Mapped[UUID] = mapped_column(primary_key=True)
|
id: Mapped[UUID] = mapped_column(primary_key=True)
|
||||||
email: Mapped[str] = mapped_column(String(255), unique=True, index=True)
|
email: Mapped[str] = mapped_column(String(255), unique=True, index=True)
|
||||||
display_name: Mapped[str | None] = mapped_column(String(100))
|
display_name: Mapped[str | None] = mapped_column(String(100))
|
||||||
|
is_admin: Mapped[bool] = mapped_column(Boolean, server_default="false")
|
||||||
created_at: Mapped[datetime] = mapped_column(
|
created_at: Mapped[datetime] = mapped_column(
|
||||||
DateTime(timezone=True), server_default=func.now()
|
DateTime(timezone=True), server_default=func.now()
|
||||||
)
|
)
|
||||||
|
|||||||
Reference in New Issue
Block a user