feat: protect frontend routes with ProtectedRoute and AdminRoute

- Wrap /runs/new and /genlockes/new with ProtectedRoute (requires login)
- Create AdminRoute component that checks isAdmin, redirects non-admins
  with a toast notification
- Wrap all /admin/* routes with AdminRoute
- Deep-linking preserved: unauthenticated users redirect to login, then
  back to the original protected route after auth

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-03-21 11:19:16 +01:00
parent bbc6f2c3f4
commit da33c62d62
5 changed files with 61 additions and 15 deletions

View File

@@ -1,11 +1,11 @@
--- ---
# nuzlocke-tracker-2zwg # nuzlocke-tracker-2zwg
title: Protect frontend routes with ProtectedRoute and AdminRoute title: Protect frontend routes with ProtectedRoute and AdminRoute
status: todo status: completed
type: task type: task
priority: normal priority: normal
created_at: 2026-03-21T10:06:20Z created_at: 2026-03-21T10:06:20Z
updated_at: 2026-03-21T10:06:24Z updated_at: 2026-03-21T10:19:22Z
parent: nuzlocke-tracker-ce4o parent: nuzlocke-tracker-ce4o
blocked_by: blocked_by:
- nuzlocke-tracker-5svj - nuzlocke-tracker-5svj
@@ -15,14 +15,24 @@ Use the existing \`ProtectedRoute\` component (currently unused) and create an \
## Checklist ## Checklist
- [ ] Wrap \`/runs/new\` and \`/genlockes/new\` with \`ProtectedRoute\` (requires login) - [x] Wrap \`/runs/new\` and \`/genlockes/new\` with \`ProtectedRoute\` (requires login)
- [ ] Create \`AdminRoute\` component that checks \`isAdmin\` from \`useAuth()\`, redirects to \`/\` with a toast/message if not admin - [x] Create \`AdminRoute\` component that checks \`isAdmin\` from \`useAuth()\`, redirects to \`/\` with a toast/message if not admin
- [ ] Wrap all \`/admin/*\` routes with \`AdminRoute\` - [x] Wrap all \`/admin/*\` routes with \`AdminRoute\`
- [ ] Ensure \`/runs\` and \`/runs/:runId\` remain accessible to everyone (public run viewing) - [x] Ensure \`/runs\` and \`/runs/:runId\` remain accessible to everyone (public run viewing)
- [ ] Verify deep-linking works (e.g., visiting \`/admin/games\` while logged out redirects to login, then back to \`/admin/games\` after auth) - [x] Verify deep-linking works (e.g., visiting \`/admin/games\` while logged out redirects to login, then back to \`/admin/games\` after auth)
## Files to change ## Files to change
- \`frontend/src/App.tsx\` — wrap routes - \`frontend/src/App.tsx\` — wrap routes
- \`frontend/src/components/ProtectedRoute.tsx\` — already exists, verify it works - \`frontend/src/components/ProtectedRoute.tsx\` — already exists, verify it works
- \`frontend/src/components/AdminRoute.tsx\` — new file - \`frontend/src/components/AdminRoute.tsx\` — new file
## Summary of Changes
Implemented frontend route protection:
- **ProtectedRoute**: Wraps `/runs/new` and `/genlockes/new` - redirects unauthenticated users to `/login` with return location preserved
- **AdminRoute**: New component that checks `isAdmin` from `useAuth()`, redirects non-admins to `/` with a toast notification
- **Admin routes**: Wrapped `AdminLayout` with `AdminRoute` to protect all `/admin/*` routes
- **Public routes**: `/runs` and `/runs/:runId` remain accessible to everyone
- **Deep-linking**: Location state preserved so users return to original route after login

View File

@@ -5,7 +5,7 @@ status: completed
type: epic type: epic
priority: normal priority: normal
created_at: 2026-03-21T10:05:52Z created_at: 2026-03-21T10:05:52Z
updated_at: 2026-03-21T10:08:39Z updated_at: 2026-03-21T10:18:47Z
--- ---
The app currently shows the same navigation menu to all users regardless of auth state. Logged-out users can navigate to protected pages (e.g., /runs/new, /admin) even though the backend rejects their requests. The admin interface has no role restriction — any authenticated user can access it. The app currently shows the same navigation menu to all users regardless of auth state. Logged-out users can navigate to protected pages (e.g., /runs/new, /admin) even though the backend rejects their requests. The admin interface has no role restriction — any authenticated user can access it.
@@ -20,9 +20,9 @@ The app currently shows the same navigation menu to all users regardless of auth
## Success Criteria ## Success Criteria
- [ ] Logged-out users see only: Home, Runs (public list), Genlockes, Stats, Sign In - [ ] Logged-out users see only: Home, Runs (public list), Genlockes, Stats, Sign In
- [ ] Logged-out users cannot navigate to /runs/new, /genlockes/new, or /admin/* - [x] Logged-out users cannot navigate to /runs/new, /genlockes/new, or /admin/*
- [ ] Logged-in non-admin users see: New Run, My Runs, Genlockes, Stats (no Admin link) - [ ] Logged-in non-admin users see: New Run, My Runs, Genlockes, Stats (no Admin link)
- [ ] Admin users see the full menu including Admin - [ ] Admin users see the full menu including Admin
- [ ] Backend admin endpoints return 403 for non-admin authenticated users - [x] Backend admin endpoints return 403 for non-admin authenticated users
- [ ] Admin role is stored in the `users` table (`is_admin` boolean column) - [ ] Admin role is stored in the `users` table (`is_admin` boolean column)
- [ ] Admin status is exposed to the frontend via the user API or auth context - [x] Admin status is exposed to the frontend via the user API or auth context

View File

@@ -1,5 +1,5 @@
import { Routes, Route, Navigate } from 'react-router-dom' import { Routes, Route, Navigate } from 'react-router-dom'
import { Layout } from './components' import { Layout, ProtectedRoute, AdminRoute } from './components'
import { AdminLayout } from './components/admin' import { AdminLayout } from './components/admin'
import { import {
AuthCallback, AuthCallback,
@@ -35,18 +35,18 @@ function App() {
<Route path="signup" element={<Signup />} /> <Route path="signup" element={<Signup />} />
<Route path="auth/callback" element={<AuthCallback />} /> <Route path="auth/callback" element={<AuthCallback />} />
<Route path="runs" element={<RunList />} /> <Route path="runs" element={<RunList />} />
<Route path="runs/new" element={<NewRun />} /> <Route path="runs/new" element={<ProtectedRoute><NewRun /></ProtectedRoute>} />
<Route path="runs/:runId" element={<RunEncounters />} /> <Route path="runs/:runId" element={<RunEncounters />} />
<Route path="runs/:runId/journal/:entryId" element={<JournalEntryPage />} /> <Route path="runs/:runId/journal/:entryId" element={<JournalEntryPage />} />
<Route path="genlockes" element={<GenlockeList />} /> <Route path="genlockes" element={<GenlockeList />} />
<Route path="genlockes/new" element={<NewGenlocke />} /> <Route path="genlockes/new" element={<ProtectedRoute><NewGenlocke /></ProtectedRoute>} />
<Route path="genlockes/:genlockeId" element={<GenlockeDetail />} /> <Route path="genlockes/:genlockeId" element={<GenlockeDetail />} />
<Route path="stats" element={<Stats />} /> <Route path="stats" element={<Stats />} />
<Route <Route
path="runs/:runId/encounters" path="runs/:runId/encounters"
element={<Navigate to=".." relative="path" replace />} element={<Navigate to=".." relative="path" replace />}
/> />
<Route path="admin" element={<AdminLayout />}> <Route path="admin" element={<AdminRoute><AdminLayout /></AdminRoute>}>
<Route index element={<Navigate to="/admin/games" replace />} /> <Route index element={<Navigate to="/admin/games" replace />} />
<Route path="games" element={<AdminGames />} /> <Route path="games" element={<AdminGames />} />
<Route path="games/:gameId" element={<AdminGameDetail />} /> <Route path="games/:gameId" element={<AdminGameDetail />} />

View File

@@ -0,0 +1,35 @@
import { useEffect, useRef } from 'react'
import { Navigate, useLocation } from 'react-router-dom'
import { toast } from 'sonner'
import { useAuth } from '../contexts/AuthContext'
export function AdminRoute({ children }: { children: React.ReactNode }) {
const { user, loading, isAdmin } = useAuth()
const location = useLocation()
const toastShownRef = useRef(false)
useEffect(() => {
if (!loading && user && !isAdmin && !toastShownRef.current) {
toastShownRef.current = true
toast.error('Admin access required')
}
}, [loading, user, isAdmin])
if (loading) {
return (
<div className="min-h-screen flex items-center justify-center">
<div className="animate-spin rounded-full h-8 w-8 border-b-2 border-accent-500" />
</div>
)
}
if (!user) {
return <Navigate to="/login" state={{ from: location }} replace />
}
if (!isAdmin) {
return <Navigate to="/" replace />
}
return <>{children}</>
}

View File

@@ -1,3 +1,4 @@
export { AdminRoute } from './AdminRoute'
export { CustomRulesDisplay } from './CustomRulesDisplay' export { CustomRulesDisplay } from './CustomRulesDisplay'
export { ProtectedRoute } from './ProtectedRoute' export { ProtectedRoute } from './ProtectedRoute'
export { EggEncounterModal } from './EggEncounterModal' export { EggEncounterModal } from './EggEncounterModal'