Release: test infrastructure, rules overhaul, and design refresh #30

Merged

TheFurya merged 43 commits from develop into main 2026-02-21 16:58:18 +01:00

Conversation 0 Commits 43 Files Changed 362 +45471 -18064

TheFurya commented 2026-02-21 16:53:42 +01:00

Owner

Copy Link

Summary

• Add backend test infrastructure and integration tests for all API endpoints (games, pokemon, runs, genlockes, bosses)
• Add frontend unit tests for hooks/utilities and component tests for key UI components
• Add Playwright e2e tests for accessibility and mobile layout
• Overhaul nuzlocke rules system: gift clause, static clause, type restriction, egglocke/wonderlocke/randomizer variants, boss team match
• Rebrand to Another Nuzlocke Tracker (ANT) with dark-first Geist design system
• Fix WCAG AA color contrast violations, add dark/light mode toggle
• Set up CI pipeline with backend, frontend, and e2e test jobs
• Per-condition encounter rates in seed data, boss team condition badges
• Numerous seed data corrections and route ordering fixes

Test plan

• Backend tests pass (94 tests)
• Frontend unit/component tests pass
• E2e tests pass
• CI pipeline green for all three jobs

🤖 Generated with Claude Code

## Summary - Add backend test infrastructure and integration tests for all API endpoints (games, pokemon, runs, genlockes, bosses) - Add frontend unit tests for hooks/utilities and component tests for key UI components - Add Playwright e2e tests for accessibility and mobile layout - Overhaul nuzlocke rules system: gift clause, static clause, type restriction, egglocke/wonderlocke/randomizer variants, boss team match - Rebrand to Another Nuzlocke Tracker (ANT) with dark-first Geist design system - Fix WCAG AA color contrast violations, add dark/light mode toggle - Set up CI pipeline with backend, frontend, and e2e test jobs - Per-condition encounter rates in seed data, boss team condition badges - Numerous seed data corrections and route ordering fixes ## Test plan - [x] Backend tests pass (94 tests) - [x] Frontend unit/component tests pass - [x] E2e tests pass - [x] CI pipeline green for all three jobs 🤖 Generated with [Claude Code](https://claude.com/claude-code)

TheFurya added 43 commits 2026-02-21 16:53:43 +01:00

Add bean for encounter conditions seed data work ... bbc054c02f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Migrate pre-commit hooks from pre-commit to prek ... 8cfa074ea6

Replace the Python-based pre-commit framework with prek (Rust) for
faster hook execution. Convert .pre-commit-config.yaml to prek.toml,
remove pre-commit from dev dependencies, and apply ruff auto-fixes
(UP037: remove unnecessary string quotes in type annotations).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Mark bean rb0p as completed ... c8dd4414b5

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add missing files to gitignore 459b3b0829

Scrap bean in favor of 4ni4 d0fff248fe

Add per-condition encounter rates to seed data (#26) ... 7df56325a8

Co-authored-by: Julian Tabel <juliantabel.jt@gmail.com>
Co-committed-by: Julian Tabel <juliantabel.jt@gmail.com>

Archive 172 completed and scrapped beans ... ecc3d0c6b9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Rebrand to Another Nuzlocke Tracker (ANT) (#27) ... e3b3dc5317

Co-authored-by: Julian Tabel <juliantabel.jt@gmail.com>
Co-committed-by: Julian Tabel <juliantabel.jt@gmail.com>

Implement dark-first design system with Geist typography (#28) ... 42b66ee9a2

Co-authored-by: Julian Tabel <juliantabel.jt@gmail.com>
Co-committed-by: Julian Tabel <juliantabel.jt@gmail.com>

Simplify modal, badge, and component styles to dark-first (#29) ... 92dad22981

Co-authored-by: Julian Tabel <juliantabel.jt@gmail.com>
Co-committed-by: Julian Tabel <juliantabel.jt@gmail.com>

Add new epic 4d097158bd

Add epic: Overhaul Nuzlocke Rules System ... 7ec43431e5

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update bean cb35bf161e

Add dark/light mode toggle with adaptive badge colors ... a381633413

Implement theme switching via sun/moon toggle in nav bar. Dark
remains the default; light mode overrides surface, text, border,
accent, and status color tokens. Preference persists in localStorage
and falls back to prefers-color-scheme. An inline script in
index.html prevents flash of wrong theme on load.

Define a Tailwind v4 @custom-variant for light mode and update all
badge components (encounter method, rule, condition) to use
light:bg-{color}-100 / light:text-{color}-700 for readable contrast
on light surfaces.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add Playwright accessibility and mobile layout e2e tests ... a7ec49fcad

Set up end-to-end test infrastructure with Docker Compose test
environment, Playwright config, and automated global setup/teardown
that seeds a test database and creates fixtures via the API.

Tests cover 11 pages across both dark/light themes for WCAG 2.0 AA
accessibility (axe-core), and across 3 viewports (mobile, tablet,
desktop) for horizontal overflow and touch target validation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Fix e2e tests for ESM and podman-compose compatibility ... a12478f24b

Replace __dirname with import.meta.url (required by "type": "module").
Replace --wait flag with manual health polling (unsupported by
podman-compose). Use explicit -p project name to isolate test
containers from dev environment.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Fix WCAG AA color contrast violations across all pages ... 4fbfcf9b29

Replace incorrect perceived-brightness formula in Stats progress bars
with proper WCAG relative luminance calculation, and convert type bar
colors to hex values for reliable contrast detection. Add light: variant
classes to status badges, yellow/purple text, and admin nav links across
17 files. Darken light-mode status-active token and text-tertiary/muted
tokens. Add aria-labels to admin filter selects and flex-wrap for mobile
overflow on AdminEvolutions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove unused nuzlocke rules, reorganize into core and playstyle ... e25d1cf24c

Remove firstEncounterOnly, permadeath, nicknameRequired, and
postGameCompletion from the rules system — they are either implicit
(it's a nuzlocke tracker) or not enforced. Move levelCaps to core
(it's displayed in the sticky bar). Create a new "playstyle" category
for hardcoreMode and setModeOnly — informational rules useful for
stats but not enforced by the tracker. Remove the completion category
entirely. Add sub-task beans for the rules overhaul epic.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add egglocke, wonderlocke, and randomizer variant rules ... 2298c32691

When any variant rule is enabled, the encounter modal switches from
the game's regional dex to an all-Pokemon search (same debounced
API pattern as EggEncounterModal). A new "Run Variant" section in
rules configuration groups these rules, and badges render in amber.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Increase encounter method badge sizes for readability ... ed1f7ad3d0

Bump xs from 8px to 10px and sm from 9px to 12px so the route-list
badges (Grass, Surfing, Gift, etc.) are legible at a glance.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add gift clause rule for free gift encounters ... 18cc116348

When enabled, in-game gift Pokemon (starters, trades, fossils) do not
count against a location's encounter limit. Both a gift encounter and
a regular encounter can coexist on the same route, in any order.

Persists encounter origin on the Encounter model so the backend can
exclude gift encounters from route-lock checks bidirectionally, and the
frontend can split them into a separate display layer that doesn't lock
the route for regular encounters.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Fix boss banner sticking behind nav header on scroll ... 6968d35a33

The sticky level cap banner had z-10 and top-0, placing it behind the
nav (z-40) and overlapping it. Use top-14 to clear the nav height and
z-30 to layer correctly below the nav but above page content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add boss team match playstyle rule ... 347c25e8ed

When enabled, the sticky boss banner shows the next boss's team size
as a hint for players who voluntarily match the boss's party count.
Handles variant boss teams by using the auto-detected starter variant.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update bean aea5d1d84d

Add static clause rule for encounter selector filtering ... 85fef68dae

When disabled, static encounters (legendaries, scripted Pokémon) are
grayed out and unselectable in the encounter selector. Enabled by default.
Adds 'static' to METHOD_CONFIG/METHOD_ORDER with a teal badge.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add type restriction rule (monolocke) ... 993ad09d9c

Adds allowedTypes: string[] to NuzlockeRules. When set, the encounter
selector hides non-matching Pokemon and the routes endpoint filters out
routes with no matching encounters, so only eligible locations appear.

Type picker UI in RulesConfiguration; active restriction shown in
RuleBadges. Backend accepts allowed_types query param and joins through
RouteEncounter.pokemon to filter by type.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Mark Overhaul Nuzlocke Rules System epic as completed ... 16f9e68821

All child features are done.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Set up backend test infrastructure ... b0ac3714a9

Add pytest fixtures (engine, db_session, client) with session-scoped
event loop to avoid asyncpg loop mismatch errors. Smoke tests verify
all three main API endpoints return empty results on a clean DB.
Test DB provided by docker-compose.test.yml on port 5433.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add unit tests for Pydantic schemas ... 4aae12cd72

46 tests across 12 schema classes covering CamelModel alias generation,
required field validation, optional field defaults, camelCase input/output,
nested model coercion, and from_attributes support.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add integration tests for Games & Routes API ... 79eabf4f9f

25 tests covering game CRUD (create/list/get/update/delete), slug
uniqueness enforcement, by-region grouping, and route operations
(create/update/delete/reorder). Verifies that list_game_routes
excludes routes with no Pokemon encounters.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add integration tests for Runs & Encounters API ... d6a0b60585

28 tests covering run CRUD, rules JSONB storage, encounter creation,
route-lock enforcement, shinyClause and giftClause bypasses, status
transitions (complete/fail), and encounter update/delete.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add unit tests for services layer ... ca736e0f39

36 tests covering build_families (linear chains, branching, disjoint,
Shedinja case), resolve_base_form, to_roman (parametrized), and
strip_roman_suffix including round-trip verification.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add integration tests for Pokemon & Evolutions API ... 34835abe0c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add integration tests for Genlockes & Bosses API ... ee5bf03f19

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Set up frontend test infrastructure ... c80d7d0802

Install @testing-library/react, @testing-library/jest-dom,
@testing-library/user-event, and jsdom. Configure Vitest with globals,
jsdom environment, and a setup file importing jest-dom matchers. Add a
custom render helper wrapping components with QueryClientProvider and
MemoryRouter. Exclude e2e/ from vitest. Smoke test covers
formatEvolutionMethod.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add unit tests for frontend utilities and hooks ... 0d2f419c6a

82 tests covering download.ts and all React Query hooks. API modules are
mocked with vi.mock; mutation tests spy on queryClient.invalidateQueries
to verify cache invalidation. Conditional queries (null id) are verified
to stay idle.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add component tests for EndRunModal, GameGrid, RulesConfiguration, Layout ... 9aaa95a1c7

33 tests covering rendering, user interactions (userEvent clicks), prop
callbacks, filter state, and conditional description text. Adds a
matchMedia stub to the vitest setup file so components importing
useTheme don't throw in jsdom. Also adds actionlint and zizmor
pre-commit hooks for GitHub Actions linting.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Replace CI lint jobs with backend, frontend, and e2e test jobs ... bf3a3d3329

Lint, formatting, and type checks are already enforced by prek pre-commit
hooks, so CI now focuses on running the actual test suites instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Fix CI failures for backend and e2e test jobs ... f6bcb1fbe5

Replace astral-sh/setup-uv action with direct curl install to avoid
Node.js 18 incompatibility (setup-uv v6+ requires Node 20+). Change
e2e test API host port from 8000 to 8100 to avoid conflict with
existing service on the CI runner.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add uv to PATH after install in CI ... b50e9160ba

The uv installer places the binary in ~/.local/bin which isn't on
PATH by default in the act runner. Source the env file for the current
step and append to GITHUB_PATH for subsequent steps.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Use host IP for e2e test API in CI ... 00734ee233

The act runner executes steps inside a container where localhost does
not reach the Docker host. Use E2E_API_URL env var (set to the host IP
192.168.1.10:8100 in CI) so both the global setup and Vite proxy can
reach the test API container.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Use uv run for backend tests instead of system pip install ... 9a8a4f75f9

The uv-managed Python is externally managed and rejects --system pip
installs. Use uv run --extra dev to handle venv creation, dependency
installation, and test execution in a single step.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Use host IP for backend test database URL in CI ... bf4302cdd4

The Postgres service container is not reachable via localhost from
inside the act runner container. Use the Docker host IP instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

TheFurya merged commit f15e530130 into main 2026-02-21 16:58:18 +01:00

TheFurya referenced this issue from a commit 2026-02-21 16:58:19 +01:00

Merge pull request 'Release: test infrastructure, rules overhaul, and design refresh' (#30) from develop into main

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

TheFurya renovate

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: pokemon/nuzlocke-tracker#30