Julian Tabel
e8ded9184b
## Summary - Add `is_admin` column to users table with Alembic migration and a `require_admin` FastAPI dependency that protects all admin-facing write endpoints (games, pokemon, evolutions, bosses, routes CRUD) - Expose admin status to frontend via user API and update AuthContext to fetch/store `isAdmin` after login - Make navigation menu auth-aware (different links for logged-out, logged-in, and admin users) and protect frontend routes with `ProtectedRoute` and `AdminRoute` components, preserving deep-linking through redirects - Fix test reliability: `drop_all` before `create_all` to clear stale PostgreSQL enums from interrupted test runs - Fix test auth: add `admin_client` fixture and use valid UUID for mock user so tests pass with new admin-protected endpoints ## Test plan - [x] All 252 backend tests pass - [ ] Verify non-admin users cannot access admin write endpoints (games, pokemon, evolutions, bosses CRUD) - [ ] Verify admin users can access admin endpoints normally - [ ] Verify navigation shows correct links for logged-out, logged-in, and admin states - [ ] Verify `/admin/*` routes redirect non-admin users with a toast - [ ] Verify `/runs/new` and `/genlockes/new` redirect unauthenticated users to login, then back after auth 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed-on: #67 Co-authored-by: Julian Tabel <juliantabel.jt@gmail.com> Co-committed-by: Julian Tabel <juliantabel.jt@gmail.com>
1.4 KiB
1.4 KiB
title, status, type, priority, created_at, updated_at, parent, blocked_by
| title | status | type | priority | created_at | updated_at | parent | blocked_by | |
|---|---|---|---|---|---|---|---|---|
| Expose admin status to frontend via user API | completed | task | normal | 2026-03-21T10:06:20Z | 2026-03-21T10:23:04Z | nuzlocke-tracker-ce4o |
|
The frontend needs to know if the current user is an admin so it can show/hide the Admin nav link and protect admin routes client-side.
Checklist
- Add
is_adminfield to the user response schema (/api/users/meendpoint) - Update
AuthContextto fetch/api/users/meafter login and storeisAdminin context - Expose
isAdminboolean fromuseAuth()hook - Handle edge case: user exists in Supabase but not yet in local DB (first login creates user row with
is_admin=false)
Files to change
backend/src/app/schemas/user.pyor equivalent — addis_adminto responsebackend/src/app/api/users.py— ensure/mereturnsis_adminfrontend/src/contexts/AuthContext.tsx— fetch and store admin status
Summary of Changes
Added isAdmin field to frontend auth system:
- Backend: Added
is_admin: bool = FalsetoUserResponseschema inbackend/src/app/api/users.py - Frontend: Updated
AuthContextto fetch/api/users/meafter login and exposeisAdminboolean - Edge case handled:
syncUserProfilereturnsfalseif API call fails (new user auto-created withis_admin=falseby backend)