Compare commits
13 Commits
renovate/c
...
e21a8acc60
| Author | SHA1 | Date | |
|---|---|---|---|
| e21a8acc60 | |||
| f15e530130 | |||
| e533a3404e | |||
| a944da2204 | |||
| 012cfb96cd | |||
| e3e015852c | |||
| 59b4f7f28c | |||
| e212251da8 | |||
| f49c8cee85 | |||
| b34f1083a3 | |||
| b85668c233 | |||
| 45cbff7672 | |||
| 51b47dbfb0 |
@@ -1,32 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-12cw
|
|
||||||
title: 'Crash: Crash: User model, run ownership, and visibility migration'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:13:06Z
|
|
||||||
updated_at: 2026-03-20T19:21:27Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-gez0
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-gez0.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEs5bfrivterCHgjXoWG"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-gez0
|
|
||||||
- Title: Crash: User model, run ownership, and visibility migration
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
## Reasons for Scrapping
|
|
||||||
|
|
||||||
This crash was caused by an expired OAuth token during agent execution - a transient session management issue, not a code bug. The underlying task (nuzlocke-tracker-bnhh) remains blocked by nuzlocke-tracker-2561 (Supabase setup) and can be resumed once that prerequisite is complete.
|
|
||||||
@@ -1,68 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-1y09
|
|
||||||
title: Enforce feature branch workflow for agents
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T20:48:21Z
|
|
||||||
updated_at: 2026-03-20T21:01:47Z
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
Agents sometimes commit directly to `develop` instead of creating feature branches. The CLAUDE.md branching strategy documents the intent but isn't enforced — agents can ignore it.
|
|
||||||
|
|
||||||
## Solution
|
|
||||||
|
|
||||||
Add a Claude Code `PreToolCall` hook that blocks `git commit` when the current branch is `develop` or `main`, forcing agents to always work on `feature/*` branches. Also update CLAUDE.md to document the stricter workflow.
|
|
||||||
|
|
||||||
**Scope:** Agent-only enforcement (humans can still commit on `develop` if needed).
|
|
||||||
|
|
||||||
## Changes
|
|
||||||
|
|
||||||
### 1. Claude Code hook (`.claude/settings.json`)
|
|
||||||
|
|
||||||
Add a `PreToolCall` hook that:
|
|
||||||
- Triggers on `Bash` tool calls containing `git commit`
|
|
||||||
- Checks the current branch name via `git branch --show-current`
|
|
||||||
- **Blocks** if branch is `develop` or `main` with a clear error message
|
|
||||||
- **Allows** if branch matches `feature/*` or any other pattern
|
|
||||||
|
|
||||||
```json
|
|
||||||
{
|
|
||||||
"hooks": {
|
|
||||||
"PreToolCall": [
|
|
||||||
{
|
|
||||||
"matcher": "Bash",
|
|
||||||
"hooks": [
|
|
||||||
{
|
|
||||||
"type": "command",
|
|
||||||
"command": "bash -c 'if echo \"$TOOL_INPUT\" | grep -q \"git commit\"; then BRANCH=$(git branch --show-current); if [ \"$BRANCH\" = \"develop\" ] || [ \"$BRANCH\" = \"main\" ]; then echo \"BLOCK: Cannot commit directly to $BRANCH. Create a feature branch first: git checkout -b feature/<name>\"; exit 2; fi; fi'"
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
}
|
|
||||||
```
|
|
||||||
|
|
||||||
> Note: Exit code 2 blocks the tool call. The hook should parse `$TOOL_INPUT` (JSON) to check for git commit commands.
|
|
||||||
|
|
||||||
### 2. CLAUDE.md update
|
|
||||||
|
|
||||||
Update the "Branching Strategy" section to add:
|
|
||||||
|
|
||||||
- **Never commit directly to `develop` or `main`.** Always create a `feature/*` branch first.
|
|
||||||
- When starting an **epic**, create `feature/<epic-title-slug>` off `develop`
|
|
||||||
- When starting a **standalone task/bug** (no parent epic), create `feature/<task-title-slug>` off `develop`
|
|
||||||
- Each task within an epic gets its own commit(s) on the epic's feature branch
|
|
||||||
- Branch naming: use a kebab-case slug of the bean title (e.g., `feature/add-auth-system`)
|
|
||||||
- When the epic/task is complete, squash merge into `develop`
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [ ] Add `PreToolCall` hook to `.claude/settings.json` that blocks commits on `develop`/`main`
|
|
||||||
- [ ] Test hook by verifying it blocks a commit attempt on `develop`
|
|
||||||
- [ ] Test hook by verifying it allows a commit on a `feature/*` branch
|
|
||||||
- [ ] Update CLAUDE.md branching strategy with new workflow rules
|
|
||||||
- [ ] Verify hook handles edge cases (e.g., `git commit --amend`, `git commit -m "..."`)
|
|
||||||
@@ -1,21 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-2561
|
|
||||||
title: Supabase Auth project setup and provider config
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T15:28:08Z
|
|
||||||
updated_at: 2026-03-20T20:04:40Z
|
|
||||||
parent: nuzlocke-tracker-d98o
|
|
||||||
---
|
|
||||||
|
|
||||||
Set up Supabase project with Auth enabled. Configure Google and Discord as social login providers. Add Supabase URL and keys to backend/frontend environment variables. This is the foundation — nothing else can start until the Supabase project exists.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
- [ ] Create Supabase project (or configure existing one)
|
|
||||||
- [ ] Enable email/password auth
|
|
||||||
- [ ] Configure Google OAuth provider
|
|
||||||
- [ ] Configure Discord OAuth provider
|
|
||||||
- [x] Add SUPABASE_URL, SUPABASE_ANON_KEY, SUPABASE_JWT_SECRET to backend env
|
|
||||||
- [x] Add VITE_SUPABASE_URL, VITE_SUPABASE_ANON_KEY to frontend env
|
|
||||||
- [x] Document setup steps for local development
|
|
||||||
@@ -1,38 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-2zwg
|
|
||||||
title: Protect frontend routes with ProtectedRoute and AdminRoute
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T10:06:20Z
|
|
||||||
updated_at: 2026-03-21T10:19:41Z
|
|
||||||
parent: nuzlocke-tracker-ce4o
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-5svj
|
|
||||||
---
|
|
||||||
|
|
||||||
Use the existing \`ProtectedRoute\` component (currently unused) and create an \`AdminRoute\` component to guard routes in \`App.tsx\`.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Wrap \`/runs/new\` and \`/genlockes/new\` with \`ProtectedRoute\` (requires login)
|
|
||||||
- [x] Create \`AdminRoute\` component that checks \`isAdmin\` from \`useAuth()\`, redirects to \`/\` with a toast/message if not admin
|
|
||||||
- [x] Wrap all \`/admin/*\` routes with \`AdminRoute\`
|
|
||||||
- [x] Ensure \`/runs\` and \`/runs/:runId\` remain accessible to everyone (public run viewing)
|
|
||||||
- [x] Verify deep-linking works (e.g., visiting \`/admin/games\` while logged out redirects to login, then back to \`/admin/games\` after auth)
|
|
||||||
|
|
||||||
## Files to change
|
|
||||||
|
|
||||||
- \`frontend/src/App.tsx\` — wrap routes
|
|
||||||
- \`frontend/src/components/ProtectedRoute.tsx\` — already exists, verify it works
|
|
||||||
- \`frontend/src/components/AdminRoute.tsx\` — new file
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Implemented frontend route protection:
|
|
||||||
|
|
||||||
- **ProtectedRoute**: Wraps `/runs/new` and `/genlockes/new` - redirects unauthenticated users to `/login` with return location preserved
|
|
||||||
- **AdminRoute**: New component that checks `isAdmin` from `useAuth()`, redirects non-admins to `/` with a toast notification
|
|
||||||
- **Admin routes**: Wrapped `AdminLayout` with `AdminRoute` to protect all `/admin/*` routes
|
|
||||||
- **Public routes**: `/runs` and `/runs/:runId` remain accessible to everyone
|
|
||||||
- **Deep-linking**: Location state preserved so users return to original route after login
|
|
||||||
@@ -1,13 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-3mwb
|
|
||||||
title: Fix TypeScript build errors in RunEncounters.tsx
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T11:24:09Z
|
|
||||||
updated_at: 2026-03-21T11:25:37Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Two TS errors blocking production build:\n1. Line 693: `(typeof bossResults)[number]` fails because bossResults is `BossResult[] | undefined`\n2. Line 1601: Parameter 'tm' implicitly has 'any' type
|
|
||||||
|
|
||||||
## Summary of Changes\n\nFixed two TypeScript errors in RunEncounters.tsx:\n1. Used explicit `BossResult` type instead of `(typeof bossResults)[number]`\n2. Added `BossResultTeamMember` type annotation to `tm` parameter\n\nPR: #71
|
|
||||||
@@ -1,34 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-3psa
|
|
||||||
title: 'Crash: Bug: TypeScript build fails due to optional property type mismatches in journal components'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T19:00:37Z
|
|
||||||
updated_at: 2026-03-20T19:17:34Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-d5ht
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-d5ht.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEr8PbYrEx4DTBz6e1Z7"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-d5ht
|
|
||||||
- Title: Bug: TypeScript build fails due to optional property type mismatches in journal components
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Resolved by nuzlocke-tracker-xsdr - TypeScript build errors fixed.
|
|
||||||
@@ -1,50 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-52rw
|
|
||||||
title: 'Bug: Tailwind typography plugin unresolvable in Docker dev container'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: deferred
|
|
||||||
created_at: 2026-03-20T19:23:06Z
|
|
||||||
updated_at: 2026-03-20T20:26:50Z
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
After commit 1cd1389 added `@tailwindcss/typography` and the `@plugin '@tailwindcss/typography'` directive in `index.css`, the frontend Docker dev container fails to start with:
|
|
||||||
|
|
||||||
```
|
|
||||||
[plugin:@tailwindcss/vite:generate:serve] Can't resolve '@tailwindcss/typography' in '/app/src'
|
|
||||||
```
|
|
||||||
|
|
||||||
## Root Cause
|
|
||||||
|
|
||||||
The `docker-compose.yml` volume mount `./frontend/src:/app/src:cached` overlays the host's `src/` directory into the container. The new `src/index.css` contains `@plugin '@tailwindcss/typography'`, which Tailwind's Vite plugin tries to resolve starting from `/app/src/`.
|
|
||||||
|
|
||||||
Two possible causes:
|
|
||||||
1. **Stale Docker image** — If the image wasn't rebuilt after `@tailwindcss/typography` was added to `package.json`, the container's `node_modules` doesn't have the package. Fix: `docker compose build frontend` or `docker compose up --build`.
|
|
||||||
2. **Resolution path issue** — Tailwind v4's `@plugin` resolution may not walk up to `/app/node_modules` from `/app/src/index.css`. This would be a persistent issue even after rebuilding.
|
|
||||||
|
|
||||||
## Fix
|
|
||||||
|
|
||||||
- [x] Rebuild the Docker image and test if the error persists (FIXED - error was due to stale image)
|
|
||||||
- [~] If it persists after rebuild, add volume mounts (N/A - not needed, rebuild fixed it)
|
|
||||||
- [~] If resolution is the issue, consider moving the `@plugin` directive (N/A - not needed)
|
|
||||||
- [x] Verify the frontend starts correctly in Docker with `docker compose up frontend`
|
|
||||||
|
|
||||||
## Files
|
|
||||||
|
|
||||||
- `docker-compose.yml` (line 27: src volume mount)
|
|
||||||
- `frontend/src/index.css` (line 2: `@plugin '@tailwindcss/typography'`)
|
|
||||||
- `frontend/package.json` (line 22: `@tailwindcss/typography` dependency)
|
|
||||||
- `frontend/Dockerfile`
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
The issue was caused by a **stale Docker image** that was built before `@tailwindcss/typography` was added to `package.json`. The cached `npm ci` layer didn't include the new dependency.
|
|
||||||
|
|
||||||
**Resolution:** Running `docker compose build frontend` rebuilt the image with the updated dependencies. After rebuild:
|
|
||||||
- The frontend container starts correctly
|
|
||||||
- The `@plugin '@tailwindcss/typography'` directive resolves successfully
|
|
||||||
- The `.prose` typography styles are included in the compiled CSS
|
|
||||||
|
|
||||||
**No code changes required.** This is a documentation of the root cause for future reference - users experiencing this error should rebuild their Docker images.
|
|
||||||
@@ -1,35 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-5svj
|
|
||||||
title: Expose admin status to frontend via user API
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T10:06:20Z
|
|
||||||
updated_at: 2026-03-21T10:23:04Z
|
|
||||||
parent: nuzlocke-tracker-ce4o
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-dwah
|
|
||||||
---
|
|
||||||
|
|
||||||
The frontend needs to know if the current user is an admin so it can show/hide the Admin nav link and protect admin routes client-side.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Add `is_admin` field to the user response schema (`/api/users/me` endpoint)
|
|
||||||
- [x] Update `AuthContext` to fetch `/api/users/me` after login and store `isAdmin` in context
|
|
||||||
- [x] Expose `isAdmin` boolean from `useAuth()` hook
|
|
||||||
- [x] Handle edge case: user exists in Supabase but not yet in local DB (first login creates user row with `is_admin=false`)
|
|
||||||
|
|
||||||
## Files to change
|
|
||||||
|
|
||||||
- `backend/src/app/schemas/user.py` or equivalent — add `is_admin` to response
|
|
||||||
- `backend/src/app/api/users.py` — ensure `/me` returns `is_admin`
|
|
||||||
- `frontend/src/contexts/AuthContext.tsx` — fetch and store admin status
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Added `isAdmin` field to frontend auth system:
|
|
||||||
|
|
||||||
- **Backend**: Added `is_admin: bool = False` to `UserResponse` schema in `backend/src/app/api/users.py`
|
|
||||||
- **Frontend**: Updated `AuthContext` to fetch `/api/users/me` after login and expose `isAdmin` boolean
|
|
||||||
- Edge case handled: `syncUserProfile` returns `false` if API call fails (new user auto-created with `is_admin=false` by backend)
|
|
||||||
@@ -1,13 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-7y9z
|
|
||||||
title: Fix test failures from admin auth changes
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T10:33:32Z
|
|
||||||
updated_at: 2026-03-21T10:39:18Z
|
|
||||||
---
|
|
||||||
|
|
||||||
After adding require_admin to admin endpoints, tests fail:\n1. test_pokemon.py: Write endpoints return 401 because tests use unauthenticated client instead of admin client\n2. test_runs.py: mock_auth_user has id='test-user-123' which is not a valid UUID, causing ValueError in UUID(user.id)\n\nFix: add admin_override fixture, admin_client fixture, use valid UUID for mock user, update test_pokemon.py to use admin_client for write ops.
|
|
||||||
|
|
||||||
## Summary of Changes\n\n- Added `admin_override` and `admin_client` fixtures to conftest.py that override both `require_admin` and `get_current_user`\n- Changed mock user ID from `test-user-123` to a valid UUID4\n- Updated test_pokemon.py, test_games.py, and test_genlocke_boss.py to use `admin_client` for admin-protected endpoints\n- All 252 tests pass
|
|
||||||
@@ -1,32 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-8vev
|
|
||||||
title: 'Crash: Frontend auth flow (login, signup, session management)'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T19:01:00Z
|
|
||||||
updated_at: 2026-03-20T19:21:54Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-l9xh
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-l9xh.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZErA6rXo6bi18BfjCwD7"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-l9xh
|
|
||||||
- Title: Frontend auth flow (login, signup, session management)
|
|
||||||
- Type: feature
|
|
||||||
|
|
||||||
## Resolution\n\nThis was an infrastructure issue (Claude API OAuth token expired), not a code bug. Continuing work on the original feature bean (nuzlocke-tracker-l9xh).
|
|
||||||
@@ -1,34 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-9nmp
|
|
||||||
title: 'Crash: Crash: User Account integration'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:12:56Z
|
|
||||||
updated_at: 2026-03-20T19:18:39Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-ndpz
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-ndpz.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEs4pUWwh8wYoPHzaGmx"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-ndpz
|
|
||||||
- Title: Crash: User Account integration
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
## Resolution
|
|
||||||
|
|
||||||
This crash was caused by Claude's OAuth token expiring during an agent session. This is an environmental/infrastructure issue, not a code bug. The token has been refreshed by starting a new agent session.
|
|
||||||
|
|
||||||
No code changes required.
|
|
||||||
@@ -1,50 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-9xac
|
|
||||||
title: Fix stale PostgreSQL enum causing test failures
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T10:27:53Z
|
|
||||||
updated_at: 2026-03-21T10:29:33Z
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
The backend smoke tests fail with:
|
|
||||||
```
|
|
||||||
sqlalchemy.exc.DBAPIError: invalid input value for enum run_visibility: "public"
|
|
||||||
```
|
|
||||||
|
|
||||||
This happens during `Base.metadata.create_all` in the `engine` fixture (`backend/tests/conftest.py:27`).
|
|
||||||
|
|
||||||
## Root Cause
|
|
||||||
|
|
||||||
The `engine` fixture only calls `create_all` during setup and `drop_all` during teardown. If a previous test run was interrupted before teardown, the `run_visibility` PostgreSQL enum type persists in the test database with stale/incorrect values. On the next run, `create_all` (with `checkfirst=True` default) sees the enum exists and skips recreating it, but the existing enum lacks valid values, causing the `DEFAULT 'public'` to fail.
|
|
||||||
|
|
||||||
PostgreSQL native enum types are not automatically dropped with `DROP TABLE` — they require explicit `DROP TYPE`.
|
|
||||||
|
|
||||||
## Fix
|
|
||||||
|
|
||||||
In the `engine` fixture at `backend/tests/conftest.py:23-31`, add `Base.metadata.drop_all` before `create_all` to ensure a clean slate:
|
|
||||||
|
|
||||||
```python
|
|
||||||
@pytest.fixture(scope="session")
|
|
||||||
async def engine():
|
|
||||||
eng = create_async_engine(TEST_DATABASE_URL, echo=False)
|
|
||||||
async with eng.begin() as conn:
|
|
||||||
await conn.run_sync(Base.metadata.drop_all) # <-- add this
|
|
||||||
await conn.run_sync(Base.metadata.create_all)
|
|
||||||
yield eng
|
|
||||||
async with eng.begin() as conn:
|
|
||||||
await conn.run_sync(Base.metadata.drop_all)
|
|
||||||
await eng.dispose()
|
|
||||||
```
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Add `drop_all` before `create_all` in the `engine` fixture (`backend/tests/conftest.py`)
|
|
||||||
- [x] Verify tests pass with `pytest backend/tests/test_smoke.py`
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Added `drop_all` before `create_all` in the test engine fixture to ensure stale PostgreSQL enum types are cleared before recreating the schema. This prevents test failures when a previous test run was interrupted before cleanup.
|
|
||||||
@@ -1,35 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-9zpm
|
|
||||||
title: 'Crash: Backend auth middleware and JWT verification'
|
|
||||||
status: scrapped
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:00:53Z
|
|
||||||
updated_at: 2026-03-20T19:20:40Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-b311
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-b311.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEr9WsspBGfYrbAM9JRc"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-b311
|
|
||||||
- Title: Backend auth middleware and JWT verification
|
|
||||||
- Type: task
|
|
||||||
|
|
||||||
|
|
||||||
## Reasons for Scrapping
|
|
||||||
|
|
||||||
This is not a code bug. The crash occurred because the agent's OAuth token to the Anthropic API expired during execution. This is an infrastructure/authentication issue, not an actionable bug in the nuzlocke-tracker codebase.
|
|
||||||
|
|
||||||
The original task (`nuzlocke-tracker-b311`) can proceed once its actual prerequisite (`nuzlocke-tracker-2561` - Supabase Auth setup) is completed.
|
|
||||||
@@ -1,32 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-a8q0
|
|
||||||
title: 'Crash: Supabase Auth project setup and provider config'
|
|
||||||
status: scrapped
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:00:47Z
|
|
||||||
updated_at: 2026-03-20T19:19:24Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-2561
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-2561.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEr97WSkvKQrZSFbN2DA"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-2561
|
|
||||||
- Title: Supabase Auth project setup and provider config
|
|
||||||
- Type: task
|
|
||||||
|
|
||||||
## Reasons for Scrapping
|
|
||||||
|
|
||||||
This crash was caused by an OAuth token expiration (401 authentication error), not a code bug. The agent's API credentials expired while it was running. This is an infrastructure issue that cannot be fixed by code changes - the original task simply needs to be retried with valid credentials.
|
|
||||||
@@ -1,11 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-actf
|
|
||||||
title: Combine Renovate dependency updates into single commit
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T14:22:33Z
|
|
||||||
updated_at: 2026-03-20T14:26:38Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Cherry-pick all 10 Renovate dependency update branches into develop as a single combined commit. Branches: alembic, python-dotenv, react types, react-router-dom, ruff, sqlalchemy, tailwindcss-vite, tanstack-react-query, ty, vitejs-plugin-react.
|
|
||||||
@@ -1,47 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-b311
|
|
||||||
title: Backend auth middleware and JWT verification
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T15:28:13Z
|
|
||||||
updated_at: 2026-03-20T20:11:23Z
|
|
||||||
parent: nuzlocke-tracker-d98o
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-2561
|
|
||||||
---
|
|
||||||
|
|
||||||
Add Supabase JWT verification to the FastAPI backend. Create a reusable dependency that extracts and validates the Bearer token, resolves the current user, and provides it to endpoints. Protect all write endpoints (POST/PUT/DELETE) while leaving read endpoints open.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
- [x] Add python-jose[cryptography] or PyJWT dependency
|
|
||||||
- [x] Create auth dependency that extracts Bearer token from Authorization header
|
|
||||||
- [x] Verify JWT against Supabase JWT secret
|
|
||||||
- [x] Create `get_current_user` dependency (returns User or None)
|
|
||||||
- [x] Create `require_auth` dependency (raises 401 if not authenticated)
|
|
||||||
- [x] Apply `require_auth` to all write endpoints (POST, PUT, DELETE)
|
|
||||||
- [x] Add tests for auth middleware (valid token, expired token, missing token)
|
|
||||||
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Added JWT authentication middleware to the FastAPI backend:
|
|
||||||
|
|
||||||
- Added `PyJWT==2.10.1` dependency to `pyproject.toml`
|
|
||||||
- Added Supabase config fields (`supabase_url`, `supabase_anon_key`, `supabase_jwt_secret`) to `core/config.py`
|
|
||||||
- Created `core/auth.py` with:
|
|
||||||
- `AuthUser` dataclass for authenticated user info
|
|
||||||
- `_extract_token()` to parse Bearer tokens from Authorization header
|
|
||||||
- `_verify_jwt()` to validate tokens against Supabase JWT secret (HS256 with "authenticated" audience)
|
|
||||||
- `get_current_user()` dependency that returns `AuthUser | None`
|
|
||||||
- `require_auth()` dependency that raises 401 if not authenticated
|
|
||||||
- Applied `require_auth` to all write endpoints (POST, PUT, PATCH, DELETE) in:
|
|
||||||
- `runs.py` (3 endpoints)
|
|
||||||
- `encounters.py` (4 endpoints)
|
|
||||||
- `genlockes.py` (7 endpoints)
|
|
||||||
- `bosses.py` (9 endpoints)
|
|
||||||
- `journal_entries.py` (3 endpoints)
|
|
||||||
- `games.py` (9 endpoints)
|
|
||||||
- Added `tests/test_auth.py` with tests for valid/expired/invalid/missing tokens
|
|
||||||
- Updated `tests/conftest.py` with `auth_client` fixture for tests requiring authentication
|
|
||||||
- Updated `test_games.py` and `test_runs.py` to use `auth_client` for write operations
|
|
||||||
@@ -1,37 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-bnhh
|
|
||||||
title: User model, run ownership, and visibility migration
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T15:28:18Z
|
|
||||||
updated_at: 2026-03-20T20:16:39Z
|
|
||||||
parent: nuzlocke-tracker-d98o
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-2561
|
|
||||||
---
|
|
||||||
|
|
||||||
Create a User model synced from Supabase Auth. Add owner_id FK to runs table. Add visibility column (public/private) to runs with default public. Existing runs will have NULL owner_id (unowned).
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
- [x] Create User model (id matches Supabase user UUID, email, display_name, created_at)
|
|
||||||
- [x] Alembic migration: create users table
|
|
||||||
- [x] Alembic migration: add owner_id (nullable FK to users) and visibility (enum: public/private, default public) to runs table
|
|
||||||
- [x] Update Run model with owner relationship and visibility field
|
|
||||||
- [x] Create user sync endpoint or webhook (on first login, upsert user record from Supabase JWT claims)
|
|
||||||
- [x] Update RunResponse schema to include owner and visibility
|
|
||||||
- [x] Add visibility enforcement: private runs return 403 unless requester is owner
|
|
||||||
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
- Created `User` model in `backend/src/app/models/user.py` with UUID primary key (matching Supabase), email, display_name, and created_at fields
|
|
||||||
- Added Alembic migrations: `n5c6d7e8f9a0_create_users_table.py` and `o6d7e8f9a0b1_add_owner_and_visibility_to_runs.py`
|
|
||||||
- Updated `NuzlockeRun` model with `owner_id` FK, `visibility` enum (public/private), and `owner` relationship
|
|
||||||
- Created `POST /users/me` endpoint for user sync on first login (upserts from JWT claims)
|
|
||||||
- Added `GET /users/me` and `PATCH /users/me` for user profile management
|
|
||||||
- Updated `RunResponse` and `RunDetailResponse` schemas with `owner` and `visibility` fields
|
|
||||||
- Implemented visibility enforcement in `list_runs`, `get_run`, `update_run`, and `delete_run`
|
|
||||||
- Private runs return 403 unless requester is owner
|
|
||||||
- Unowned runs (legacy) remain accessible to all
|
|
||||||
- Run list filters to show only public runs + user's own private runs
|
|
||||||
@@ -1,11 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-bw1m
|
|
||||||
title: Errors
|
|
||||||
status: completed
|
|
||||||
type: epic
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T15:19:43Z
|
|
||||||
updated_at: 2026-03-20T15:39:27Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Container for crash and blocker beans created by Talos.
|
|
||||||
@@ -1,28 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-ce4o
|
|
||||||
title: Auth-aware UI and role-based access control
|
|
||||||
status: completed
|
|
||||||
type: epic
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T10:05:52Z
|
|
||||||
updated_at: 2026-03-21T10:18:47Z
|
|
||||||
---
|
|
||||||
|
|
||||||
The app currently shows the same navigation menu to all users regardless of auth state. Logged-out users can navigate to protected pages (e.g., /runs/new, /admin) even though the backend rejects their requests. The admin interface has no role restriction — any authenticated user can access it.
|
|
||||||
|
|
||||||
## Goals
|
|
||||||
|
|
||||||
1. **Auth-aware navigation**: Menu items change based on login state (logged-out users only see public browsing options)
|
|
||||||
2. **Route protection**: Protected routes redirect to login, admin routes require admin role
|
|
||||||
3. **Admin role system**: Define which users are admins via a database field, enforce on both frontend and backend
|
|
||||||
4. **Backend admin enforcement**: Admin API endpoints (games, pokemon, evolutions, bosses, routes) require admin role, not just authentication
|
|
||||||
|
|
||||||
## Success Criteria
|
|
||||||
|
|
||||||
- [ ] Logged-out users see only: Home, Runs (public list), Genlockes, Stats, Sign In
|
|
||||||
- [x] Logged-out users cannot navigate to /runs/new, /genlockes/new, or /admin/*
|
|
||||||
- [ ] Logged-in non-admin users see: New Run, My Runs, Genlockes, Stats (no Admin link)
|
|
||||||
- [ ] Admin users see the full menu including Admin
|
|
||||||
- [x] Backend admin endpoints return 403 for non-admin authenticated users
|
|
||||||
- [ ] Admin role is stored in the `users` table (`is_admin` boolean column)
|
|
||||||
- [x] Admin status is exposed to the frontend via the user API or auth context
|
|
||||||
@@ -1,32 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-cm1c
|
|
||||||
title: 'Crash: Crash: Supabase Auth project setup and provider config'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:12:59Z
|
|
||||||
updated_at: 2026-03-20T19:19:28Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-a8q0
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-a8q0.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEs55SvwXFYVzyWoU1B9"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-a8q0
|
|
||||||
- Title: Crash: Supabase Auth project setup and provider config
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
## Reasons for Scrapping
|
|
||||||
|
|
||||||
This crash was caused by an OAuth token expiration (401 authentication error), not a code bug. The agent's API credentials expired while it was running. This is an infrastructure issue that cannot be fixed by code changes - the original task simply needs to be retried with valid credentials.
|
|
||||||
@@ -1,38 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-d5ht
|
|
||||||
title: 'Bug: TypeScript build fails due to optional property type mismatches in journal components'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T15:39:00Z
|
|
||||||
updated_at: 2026-03-20T19:17:34Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
---
|
|
||||||
|
|
||||||
The frontend TypeScript build fails with 3 errors due to `exactOptionalPropertyTypes` being enabled.
|
|
||||||
|
|
||||||
## Errors
|
|
||||||
|
|
||||||
1. `JournalEntryPage.tsx:76` - `bossResults` and `bosses` props passed as `undefined` to `JournalEditor`
|
|
||||||
2. `JournalEntryPage.tsx:92` - `bossResult` and `boss` props passed as `undefined` to `JournalEntryView`
|
|
||||||
3. `RunEncounters.tsx:1170` - `bossResults` and `bosses` props passed as `undefined` to `JournalSection`
|
|
||||||
|
|
||||||
## Root Cause
|
|
||||||
|
|
||||||
Optional props in interfaces are declared as `prop?: Type` but callers pass `undefined` values from React Query hooks. With `exactOptionalPropertyTypes: true`, TypeScript requires `prop?: Type | undefined` to allow explicit `undefined` values.
|
|
||||||
|
|
||||||
## Fix
|
|
||||||
|
|
||||||
Update the interfaces in these files:
|
|
||||||
- `JournalEditor.tsx` lines 9-10: change to `bossResults?: BossResult[] | undefined` and `bosses?: BossBattle[] | undefined`
|
|
||||||
- `JournalEntryView.tsx` lines 8-9: change to `bossResult?: BossResult | null | undefined` and `boss?: BossBattle | null | undefined`
|
|
||||||
- `JournalSection.tsx` lines 9-10: change to `bossResults?: BossResult[] | undefined` and `bosses?: BossBattle[] | undefined`
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
TypeScript build errors fixed by adding `| undefined` to optional property types in journal components:
|
|
||||||
- `JournalEditor.tsx`: `bossResults` and `bosses` props
|
|
||||||
- `JournalEntryView.tsx`: `bossResult` and `boss` props
|
|
||||||
- `JournalSection.tsx`: `bossResults` and `bosses` props
|
|
||||||
@@ -1,69 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-d68l
|
|
||||||
title: 'Frontend: Journal entry editor and list view'
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T15:15:55Z
|
|
||||||
updated_at: 2026-03-20T15:37:39Z
|
|
||||||
parent: nuzlocke-tracker-mz16
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-vmto
|
|
||||||
---
|
|
||||||
|
|
||||||
Create the frontend UI for writing and viewing journal entries.
|
|
||||||
|
|
||||||
## Design Decisions
|
|
||||||
- Plain markdown textarea (no WYSIWYG)
|
|
||||||
- Images via markdown URL syntax (``)
|
|
||||||
- Blank slate — no templates
|
|
||||||
- Private only (no sharing UI)
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Add `JournalEntry` TypeScript types to `frontend/src/types/`
|
|
||||||
- [x] Create API client functions for journal CRUD
|
|
||||||
- [x] Create `JournalList` component — chronological list of entries for a run
|
|
||||||
- Show title, date, preview snippet, and linked boss (if any)
|
|
||||||
- Link each entry to its detail/edit view
|
|
||||||
- [x] Create `JournalEditor` component — markdown textarea with title input
|
|
||||||
- Optional boss result selector dropdown (link entry to a boss battle)
|
|
||||||
- Preview tab to render markdown
|
|
||||||
- Save and delete actions
|
|
||||||
- [x] Create `JournalEntryView` component — rendered markdown display
|
|
||||||
- [x] Add journal section/tab to the run detail page
|
|
||||||
- [x] Add route for journal entry detail/edit view
|
|
||||||
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Implemented the frontend journal entry editor and list view with the following components:
|
|
||||||
|
|
||||||
**Types created:**
|
|
||||||
- `frontend/src/types/journal.ts` - TypeScript types for JournalEntry, CreateJournalEntryInput, UpdateJournalEntryInput
|
|
||||||
|
|
||||||
**API client created:**
|
|
||||||
- `frontend/src/api/journal.ts` - CRUD functions for journal entries
|
|
||||||
- `frontend/src/hooks/useJournal.ts` - React Query hooks for journal data fetching and mutations
|
|
||||||
|
|
||||||
**Components created:**
|
|
||||||
- `frontend/src/components/journal/JournalList.tsx` - Chronological list of entries with title, date, preview snippet, and linked boss display
|
|
||||||
- `frontend/src/components/journal/JournalEditor.tsx` - Markdown textarea with title input, boss result selector, write/preview tabs, save/delete actions
|
|
||||||
- `frontend/src/components/journal/JournalEntryView.tsx` - Rendered markdown display with entry metadata
|
|
||||||
- `frontend/src/components/journal/JournalSection.tsx` - Wrapper component for embedding in RunEncounters page
|
|
||||||
|
|
||||||
**Pages created:**
|
|
||||||
- `frontend/src/pages/JournalEntryPage.tsx` - Standalone page for viewing/editing a single journal entry
|
|
||||||
|
|
||||||
**Modified files:**
|
|
||||||
- `frontend/src/types/index.ts` - Added journal type exports
|
|
||||||
- `frontend/src/pages/index.ts` - Added JournalEntryPage export
|
|
||||||
- `frontend/src/App.tsx` - Added route `/runs/:runId/journal/:entryId`
|
|
||||||
- `frontend/src/pages/RunEncounters.tsx` - Added Encounters/Journal tab navigation with JournalSection integration
|
|
||||||
|
|
||||||
**Features:**
|
|
||||||
- Tab navigation in run detail page to switch between Encounters and Journal views
|
|
||||||
- Create new journal entries with markdown content and optional boss battle linking
|
|
||||||
- Edit and delete existing entries
|
|
||||||
- Write/Preview toggle in editor
|
|
||||||
- Rendered markdown display with full prose styling
|
|
||||||
@@ -1,43 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-dwah
|
|
||||||
title: Add is_admin column to users table
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T10:06:19Z
|
|
||||||
updated_at: 2026-03-21T10:10:38Z
|
|
||||||
parent: nuzlocke-tracker-ce4o
|
|
||||||
---
|
|
||||||
|
|
||||||
Add an `is_admin` boolean column (default `false`) to the `users` table via an Alembic migration.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Create Alembic migration adding `is_admin: Mapped[bool]` column with `server_default="false"`
|
|
||||||
- [x] Update `User` model in `backend/src/app/models/user.py`
|
|
||||||
- [x] Run migration and verify column exists
|
|
||||||
- [x] Seed a test admin user (or document how to set `is_admin=true` via SQL)
|
|
||||||
|
|
||||||
## Files to change
|
|
||||||
|
|
||||||
- `backend/src/app/models/user.py` — add `is_admin` field
|
|
||||||
- `backend/src/app/alembic/versions/` — new migration
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Added `is_admin` boolean column to the `users` table:
|
|
||||||
|
|
||||||
- **Migration**: `p7e8f9a0b1c2_add_is_admin_to_users.py` adds the column with `server_default='false'`
|
|
||||||
- **Model**: Updated `User` model with `is_admin: Mapped[bool]` field
|
|
||||||
|
|
||||||
### Setting admin via SQL
|
|
||||||
|
|
||||||
To promote a user to admin:
|
|
||||||
```sql
|
|
||||||
UPDATE users SET is_admin = true WHERE email = 'admin@example.com';
|
|
||||||
```
|
|
||||||
|
|
||||||
Or by user ID:
|
|
||||||
```sql
|
|
||||||
UPDATE users SET is_admin = true WHERE id = '<uuid>';
|
|
||||||
```
|
|
||||||
@@ -1,13 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-elcn
|
|
||||||
title: Add Supabase auth config to production Docker setup
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T11:07:01Z
|
|
||||||
updated_at: 2026-03-21T11:08:19Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Update docker-compose.prod.yml and Dockerfile.prod to support Supabase Cloud auth in production.\n\n- [ ] Add SUPABASE_JWT_SECRET env var to backend in docker-compose.prod.yml\n- [ ] Add build args for VITE_SUPABASE_URL, VITE_SUPABASE_ANON_KEY, VITE_API_URL to frontend in docker-compose.prod.yml\n- [ ] Add ARG/ENV lines to Dockerfile.prod so Vite can pick up env vars at build time\n- [ ] Update .env.example with production notes
|
|
||||||
|
|
||||||
## Summary of Changes\n\nUpdated 3 files to support Supabase Cloud auth in production:\n- `docker-compose.prod.yml`: added SUPABASE_JWT_SECRET to backend, added build args to frontend\n- `frontend/Dockerfile.prod`: added ARG lines so Vite inlines Supabase config at build time\n- `.github/workflows/deploy.yml`: pass build args from secrets when building frontend image\n\nPR: #69
|
|
||||||
@@ -1,35 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-evc8
|
|
||||||
title: 'Crash: Crash: Backend auth middleware and JWT verification'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:13:03Z
|
|
||||||
updated_at: 2026-03-20T19:20:46Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-9zpm
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-9zpm.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEs5LCgi1Zh6MdRencGW"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-9zpm
|
|
||||||
- Title: Crash: Backend auth middleware and JWT verification
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
|
|
||||||
## Reasons for Scrapping
|
|
||||||
|
|
||||||
This is not a code bug. The crash occurred because the agent's OAuth token to the Anthropic API expired during execution. This is an infrastructure/authentication issue, not an actionable bug in the nuzlocke-tracker codebase.
|
|
||||||
|
|
||||||
The original task (`nuzlocke-tracker-b311`) can proceed once its actual prerequisite (`nuzlocke-tracker-2561` - Supabase Auth setup) is completed.
|
|
||||||
@@ -1,49 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-f4d0
|
|
||||||
title: Add require_admin dependency and protect admin endpoints
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T10:06:19Z
|
|
||||||
updated_at: 2026-03-21T10:15:14Z
|
|
||||||
parent: nuzlocke-tracker-ce4o
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-dwah
|
|
||||||
---
|
|
||||||
|
|
||||||
Add a `require_admin` FastAPI dependency that checks the `is_admin` column on the `users` table. Apply it to all admin-facing API endpoints (games CRUD, pokemon CRUD, evolutions CRUD, bosses CRUD, route CRUD).
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Add `require_admin` dependency in `backend/src/app/core/auth.py` that:
|
|
||||||
- Requires authentication (reuses `require_auth`)
|
|
||||||
- Looks up the user in the `users` table by `AuthUser.id`
|
|
||||||
- Returns 403 if `is_admin` is not `True`
|
|
||||||
- [x] Apply `require_admin` to write endpoints in: `games.py`, `pokemon.py`, `evolutions.py`, `bosses.py` (all POST/PUT/PATCH/DELETE)
|
|
||||||
- [x] Keep read endpoints (GET) accessible to all authenticated users
|
|
||||||
- [x] Add tests for 403 response when non-admin user hits admin endpoints
|
|
||||||
|
|
||||||
## Files to change
|
|
||||||
|
|
||||||
- `backend/src/app/core/auth.py` — add `require_admin`
|
|
||||||
- `backend/src/app/api/games.py` — replace `require_auth` with `require_admin` on mutations
|
|
||||||
- `backend/src/app/api/pokemon.py` — same
|
|
||||||
- `backend/src/app/api/evolutions.py` — same
|
|
||||||
- `backend/src/app/api/bosses.py` — same
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Added `require_admin` FastAPI dependency to `backend/src/app/core/auth.py`:
|
|
||||||
- Depends on `require_auth` (returns 401 if not authenticated)
|
|
||||||
- Looks up user in `users` table by UUID
|
|
||||||
- Returns 403 if user not found or `is_admin` is not True
|
|
||||||
|
|
||||||
Applied `require_admin` to all admin-facing write endpoints:
|
|
||||||
- `games.py`: POST/PUT/DELETE for games and routes
|
|
||||||
- `pokemon.py`: POST/PUT/DELETE for pokemon and route encounters
|
|
||||||
- `evolutions.py`: POST/PUT/DELETE for evolutions
|
|
||||||
- `bosses.py`: POST/PUT/DELETE for game-scoped boss operations (run-scoped endpoints kept with `require_auth`)
|
|
||||||
|
|
||||||
Added tests in `test_auth.py`:
|
|
||||||
- Unit tests for `require_admin` (admin user, non-admin user, user not in DB)
|
|
||||||
- Integration tests for admin endpoint access (403 for non-admin, 201 for admin)
|
|
||||||
@@ -1,32 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-fbcs
|
|
||||||
title: 'Crash: Add detailed boss pokemon information (ability, item, nature, moveset)'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T19:01:15Z
|
|
||||||
updated_at: 2026-03-20T19:37:36Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-nvd6
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-nvd6.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZErBAtQPvCEsAZyGSYmc"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-nvd6
|
|
||||||
- Title: Add detailed boss pokemon information (ability, item, nature, moveset)
|
|
||||||
- Type: feature
|
|
||||||
|
|
||||||
## Resolution\n\nThe crash was caused by OAuth token expiration. Work completed via nuzlocke-tracker-n926.
|
|
||||||
@@ -1,34 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-gez0
|
|
||||||
title: 'Crash: User model, run ownership, and visibility migration'
|
|
||||||
status: scrapped
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T19:00:55Z
|
|
||||||
updated_at: 2026-03-20T19:21:18Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-bnhh
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-bnhh.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEr9igHnUG4eR8RFWUEj"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-bnhh
|
|
||||||
- Title: User model, run ownership, and visibility migration
|
|
||||||
- Type: task
|
|
||||||
|
|
||||||
## Reasons for Scrapping
|
|
||||||
|
|
||||||
This crash was caused by an expired OAuth token during agent execution - a transient session management issue, not a code bug. The underlying task (nuzlocke-tracker-bnhh) remains blocked by nuzlocke-tracker-2561 (Supabase setup) and can be resumed once that prerequisite is complete.
|
|
||||||
@@ -1,38 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-h205
|
|
||||||
title: Auth-aware navigation menu
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T10:06:20Z
|
|
||||||
updated_at: 2026-03-21T10:22:34Z
|
|
||||||
parent: nuzlocke-tracker-ce4o
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-5svj
|
|
||||||
---
|
|
||||||
|
|
||||||
Update the Layout component to show different nav links based on auth state and admin role.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Replace static \`navLinks\` array with dynamic links based on \`useAuth()\` state
|
|
||||||
- [x] **Logged out**: Home, Runs, Genlockes, Stats (no New Run, no Admin)
|
|
||||||
- [x] **Logged in (non-admin)**: New Run, My Runs, Genlockes, Stats
|
|
||||||
- [x] **Logged in (admin)**: New Run, My Runs, Genlockes, Stats, Admin
|
|
||||||
- [x] Update both desktop and mobile nav (they share the same \`navLinks\` array, so this should be automatic)
|
|
||||||
- [x] Verify menu updates reactively on login/logout
|
|
||||||
|
|
||||||
## Files to change
|
|
||||||
|
|
||||||
- \`frontend/src/components/Layout.tsx\` — make \`navLinks\` dynamic based on auth state
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
- Removed static `navLinks` array from module scope
|
|
||||||
- Added dynamic `navLinks` computation inside `Layout` component using `useMemo`
|
|
||||||
- Navigation now depends on `user` and `isAdmin` from `useAuth()`:
|
|
||||||
- Logged out: Home, Runs, Genlockes, Stats
|
|
||||||
- Logged in (non-admin): New Run, My Runs, Genlockes, Stats
|
|
||||||
- Logged in (admin): New Run, My Runs, Genlockes, Stats, Admin
|
|
||||||
- Updated `isActive` function to handle Home route (`/`) correctly
|
|
||||||
- Both desktop and mobile nav automatically use the same dynamic `navLinks` array
|
|
||||||
@@ -1,28 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-h8zw
|
|
||||||
title: 'Crash: Hide edit controls for non-owners in frontend'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-21T12:49:42Z
|
|
||||||
updated_at: 2026-03-21T12:50:37Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-i2va
|
|
||||||
---
|
|
||||||
|
|
||||||
Bean was found in 'in-progress' status on startup but no agent was running.
|
|
||||||
This likely indicates a crash or unexpected termination.
|
|
||||||
|
|
||||||
Manual review required before retrying.
|
|
||||||
|
|
||||||
Bean: nuzlocke-tracker-i2va
|
|
||||||
Title: Hide edit controls for non-owners in frontend
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Investigation shows commit `3bd24fc` already implemented all required changes:
|
|
||||||
- Added `useAuth` and `canEdit = isOwner` to both `RunEncounters.tsx` and `RunDashboard.tsx`
|
|
||||||
- All mutation UI guarded behind `canEdit` (Log Shiny/Egg, End Run, Randomize All, HoF Edit, Boss Battle, route clicks, visibility, naming scheme)
|
|
||||||
- Read-only banners displayed for non-owners
|
|
||||||
- No code changes needed — work was already complete
|
|
||||||
@@ -1,55 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-he1n
|
|
||||||
title: Add local GoTrue container for dev auth testing
|
|
||||||
status: completed
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T20:57:04Z
|
|
||||||
updated_at: 2026-03-21T10:07:40Z
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
The current local Docker setup has no auth service — Supabase is only available as a cloud service. This means:
|
|
||||||
- Auth flows (login, signup, JWT verification) cannot be tested locally
|
|
||||||
- The frontend's `supabase.ts` falls back to a stub client (`http://localhost:54321`) that doesn't actually exist
|
|
||||||
- Backend tests mock auth entirely via `conftest.py` fixtures, so integration testing of the full auth flow is impossible
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
Add a **GoTrue** container (Supabase's auth engine) to the local `docker-compose.yml`. GoTrue is a standalone Go service that provides the same auth API that Supabase cloud exposes. This gives us local email/password auth without needing Discord/Google OAuth providers configured.
|
|
||||||
|
|
||||||
**Architecture (Option 3):**
|
|
||||||
- **Local dev**: Own PostgreSQL + GoTrue container → full auth testing
|
|
||||||
- **Production**: Own PostgreSQL + Supabase cloud for auth (handles Discord/Google OAuth)
|
|
||||||
|
|
||||||
GoTrue will use the existing `db` PostgreSQL container, creating its own `auth` schema (separate from the app's tables managed by Alembic).
|
|
||||||
|
|
||||||
## Files to modify
|
|
||||||
|
|
||||||
- `docker-compose.yml` — add GoTrue service, configure env vars
|
|
||||||
- `.env.example` — add GoTrue-specific local defaults
|
|
||||||
- `frontend/src/lib/supabase.ts` — point to local GoTrue when in dev mode
|
|
||||||
- `backend/src/app/core/config.py` — may need local JWT secret default
|
|
||||||
- `README.md` or docs — document local auth setup
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Research GoTrue Docker image and required env vars (JWT secret, DB connection, SMTP disabled, etc.)
|
|
||||||
- [x] Add `gotrue` service to `docker-compose.yml` using the existing `db` container
|
|
||||||
- [x] Configure GoTrue to use the same PostgreSQL with its own `auth` schema
|
|
||||||
- [x] Set local JWT secret (e.g. `super-secret-jwt-token-for-local-dev`) shared between GoTrue and the backend
|
|
||||||
- [x] Update `.env.example` with local GoTrue defaults (`SUPABASE_URL=http://localhost:9999`, local JWT secret, local anon key)
|
|
||||||
- [x] Update `frontend/src/lib/supabase.ts` to use `http://localhost:9999` in dev (GoTrue's local port)
|
|
||||||
- [x] Verify backend JWT verification works with GoTrue-issued tokens (same HS256 + shared secret)
|
|
||||||
- [ ] Test email/password signup and login flow end-to-end locally
|
|
||||||
- [x] Verify OAuth buttons gracefully handle missing providers in local dev (show disabled state or helpful message)
|
|
||||||
- [x] Update `docker-compose.yml` healthcheck for GoTrue readiness
|
|
||||||
- [x] Document the local auth setup in README or contributing guide
|
|
||||||
|
|
||||||
## Notes
|
|
||||||
|
|
||||||
- GoTrue image: `supabase/gotrue` (official, regularly updated)
|
|
||||||
- GoTrue needs: `GOTRUE_DB_DATABASE_URL`, `GOTRUE_JWT_SECRET`, `GOTRUE_SITE_URL`, `GOTRUE_EXTERNAL_EMAIL_ENABLED=true`, `GOTRUE_MAILER_AUTOCONFIRM=true` (skip email verification locally)
|
|
||||||
- The `anon` key for local dev can be a static JWT signed with the local secret (Supabase docs show how to generate this)
|
|
||||||
- Production docker-compose.prod.yml is NOT modified — it continues using Supabase cloud via env vars
|
|
||||||
@@ -1,34 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-jmkf
|
|
||||||
title: 'Crash: Run ownership assignment and visibility toggle'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:01:04Z
|
|
||||||
updated_at: 2026-03-20T19:28:57Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-k1l1
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-k1l1.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZErAP1dbTeqSqRccKWyb"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-k1l1
|
|
||||||
- Title: Run ownership assignment and visibility toggle
|
|
||||||
- Type: feature
|
|
||||||
|
|
||||||
## Resolution
|
|
||||||
|
|
||||||
This crash was caused by OAuth token expiration during agent execution, not a code bug. The token expired mid-session, causing the API to return a 401 authentication error. No code changes are required.
|
|
||||||
|
|
||||||
The original feature (nuzlocke-tracker-k1l1) remains blocked by its dependencies (b311 and bnhh).
|
|
||||||
@@ -1,40 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-k1l1
|
|
||||||
title: Run ownership assignment and visibility toggle
|
|
||||||
status: completed
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T15:28:27Z
|
|
||||||
updated_at: 2026-03-20T20:21:01Z
|
|
||||||
parent: nuzlocke-tracker-d98o
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-b311
|
|
||||||
- nuzlocke-tracker-bnhh
|
|
||||||
- nuzlocke-tracker-l9xh
|
|
||||||
---
|
|
||||||
|
|
||||||
Wire up run ownership in the UI. New runs created by logged-in users are automatically assigned to them. Add a visibility toggle (public/private) to run settings. Update run list to show owned runs and public runs separately.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
- [x] Auto-assign owner_id when creating a new run (if authenticated)
|
|
||||||
- [x] Add visibility toggle to run settings/edit page
|
|
||||||
- [x] Update run list view: show 'My Runs' section for authenticated users
|
|
||||||
- [x] Show public/private badge on run cards
|
|
||||||
- [x] Enforce visibility on frontend (don't show edit controls for non-owned runs)
|
|
||||||
- [x] Admin script/endpoint to assign existing unowned runs to a user by ID
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
### Frontend
|
|
||||||
- Updated `NuzlockeRun` type to include `visibility` (public/private) and `owner` fields
|
|
||||||
- Updated `CreateRunInput` and `UpdateRunInput` to support visibility setting
|
|
||||||
- **RunList.tsx**: Added "My Runs" and "Public Runs" sections for authenticated users, with private badge on owned runs
|
|
||||||
- **RunDashboard.tsx**: Added visibility toggle dropdown in settings, restricted edit controls to run owners
|
|
||||||
- **NewRun.tsx**: Added visibility selector during run creation
|
|
||||||
|
|
||||||
### Backend
|
|
||||||
- Created `scripts/assign_unowned_runs.py` admin script to migrate existing unowned runs to a user
|
|
||||||
|
|
||||||
### Notes
|
|
||||||
- The backend already supported auto-assigning `owner_id` on run creation (from blocking bean)
|
|
||||||
- Unowned runs (legacy) remain editable by anyone for backwards compatibility
|
|
||||||
@@ -1,60 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-kix5
|
|
||||||
title: Fix e2e tests after boss feature changes
|
|
||||||
status: scrapped
|
|
||||||
type: bug
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T19:19:31Z
|
|
||||||
updated_at: 2026-03-20T20:49:19Z
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-neqv
|
|
||||||
---
|
|
||||||
|
|
||||||
The e2e tests (accessibility + mobile) are failing because the test infrastructure hasn't been updated since the boss feature, journal, and admin pages were added.
|
|
||||||
|
|
||||||
## Problems
|
|
||||||
|
|
||||||
### 1. Missing pages in test coverage
|
|
||||||
Both `accessibility.spec.ts` and `mobile.spec.ts` share a hardcoded page list that is missing several routes added since the tests were written:
|
|
||||||
|
|
||||||
**Missing from page list:**
|
|
||||||
- `runs/:runId/journal/:entryId` — Journal entry page (requires journal fixture)
|
|
||||||
- `admin/games/:gameId` — Admin game detail page (requires game fixture ID)
|
|
||||||
- `admin/games/:gameId/routes/:routeId` — Admin route detail page (requires route fixture ID)
|
|
||||||
- `admin/runs` — Admin runs page
|
|
||||||
- `admin/genlockes` — Admin genlockes page
|
|
||||||
- `admin/genlockes/:genlockeId` — Admin genlocke detail page (requires genlocke fixture ID)
|
|
||||||
|
|
||||||
### 2. Missing test fixtures/seeding
|
|
||||||
The global-setup seeds runs, encounters, and genlockes but does **not** seed:
|
|
||||||
- Boss battles (via `/games/{game_id}/bosses`)
|
|
||||||
- Boss results (via `/runs/{run_id}/boss-results`)
|
|
||||||
- Journal entries (via journal API)
|
|
||||||
- Version groups (required for boss battles to work)
|
|
||||||
|
|
||||||
The RunEncounters page now renders a boss battle section, which likely makes API calls that fail or produce unexpected DOM, causing accessibility or layout violations.
|
|
||||||
|
|
||||||
### 3. Shared page list duplication
|
|
||||||
Both spec files duplicate the same page list — should be extracted to a shared constant in `fixtures.ts`.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [ ] Update `fixtures.ts` to export a shared page list with all current routes
|
|
||||||
- [ ] Add boss battle seeding to `global-setup.ts` (create boss via API after game seed)
|
|
||||||
- [ ] Add boss result seeding to `global-setup.ts` (create result for the test run)
|
|
||||||
- [ ] Add journal entry seeding to `global-setup.ts` (create entry for the test run)
|
|
||||||
- [ ] Add new fixture IDs to `Fixtures` interface (journalEntryId, routeId, bossId, etc.)
|
|
||||||
- [ ] Update `accessibility.spec.ts` to use shared page list
|
|
||||||
- [ ] Update `mobile.spec.ts` to use shared page list
|
|
||||||
- [ ] Run e2e tests locally and verify they pass
|
|
||||||
- [ ] Fix any new accessibility or layout violations on boss/journal pages
|
|
||||||
|
|
||||||
## Files to modify
|
|
||||||
- `frontend/e2e/fixtures.ts`
|
|
||||||
- `frontend/e2e/global-setup.ts`
|
|
||||||
- `frontend/e2e/accessibility.spec.ts`
|
|
||||||
- `frontend/e2e/mobile.spec.ts`
|
|
||||||
|
|
||||||
## Notes
|
|
||||||
- The boss feature is still in progress (epic `nuzlocke-tracker-neqv`). This bean should be worked on after the boss feature is finalized to avoid churn.
|
|
||||||
- Version groups must exist for boss battle API calls to work — check if `app.seeds` already seeds them.
|
|
||||||
@@ -1,41 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-l9xh
|
|
||||||
title: Frontend auth flow (login, signup, session management)
|
|
||||||
status: completed
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T15:28:24Z
|
|
||||||
updated_at: 2026-03-20T19:26:16Z
|
|
||||||
parent: nuzlocke-tracker-d98o
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-2561
|
|
||||||
---
|
|
||||||
|
|
||||||
Add Supabase JS client to the frontend. Build login and signup pages with email/password and social login buttons (Google, Discord). Implement auth context/provider for session management, protected route wrapper, and auth-aware API client that attaches Bearer tokens.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
- [x] Install @supabase/supabase-js
|
|
||||||
- [x] Create Supabase client singleton with env vars
|
|
||||||
- [x] Create AuthContext/AuthProvider with session state, login, logout, signup methods
|
|
||||||
- [x] Build login page (email/password form + Google/Discord buttons)
|
|
||||||
- [x] Build signup page (email/password form + Google/Discord buttons)
|
|
||||||
- [x] Add auth callback route for OAuth redirects
|
|
||||||
- [x] Create ProtectedRoute wrapper component
|
|
||||||
- [x] Update API client to attach Authorization header when user is logged in
|
|
||||||
- [x] Add user menu (avatar/email, logout) to header when authenticated
|
|
||||||
- [x] Handle token refresh automatically via Supabase client
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
- Installed @supabase/supabase-js package
|
|
||||||
- Created Supabase client singleton at `frontend/src/lib/supabase.ts`
|
|
||||||
- Created AuthContext/AuthProvider at `frontend/src/contexts/AuthContext.tsx` with session state, login, logout, signup, and OAuth methods
|
|
||||||
- Created Login page (`frontend/src/pages/Login.tsx`) with email/password form and Google/Discord OAuth buttons
|
|
||||||
- Created Signup page (`frontend/src/pages/Signup.tsx`) with email/password form and Google/Discord OAuth buttons
|
|
||||||
- Created auth callback route (`frontend/src/pages/AuthCallback.tsx`) for OAuth redirects
|
|
||||||
- Created ProtectedRoute component (`frontend/src/components/ProtectedRoute.tsx`)
|
|
||||||
- Updated API client to attach Authorization header automatically when user is logged in
|
|
||||||
- Added UserMenu component to Layout header showing avatar/email and logout button
|
|
||||||
- Token refresh is handled automatically by Supabase JS client
|
|
||||||
@@ -1,34 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-ldyi
|
|
||||||
title: 'Crash: Crash: Run ownership assignment and visibility toggle'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:13:16Z
|
|
||||||
updated_at: 2026-03-20T19:29:03Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-jmkf
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-jmkf.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEs6J7hxAdJni9KoTLcJ"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-jmkf
|
|
||||||
- Title: Crash: Run ownership assignment and visibility toggle
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
## Resolution
|
|
||||||
|
|
||||||
This crash was caused by OAuth token expiration during agent execution, not a code bug. The token expired mid-session, causing the API to return a 401 authentication error. No code changes are required.
|
|
||||||
|
|
||||||
The original feature (nuzlocke-tracker-k1l1) remains blocked by its dependencies (b311 and bnhh).
|
|
||||||
@@ -1,13 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-liz1
|
|
||||||
title: Fix frontend Layout tests for auth-aware navigation
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T10:41:51Z
|
|
||||||
updated_at: 2026-03-21T10:42:30Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Layout.test.tsx fails because nav links are now auth-dependent. Tests expect logged-in admin links but render with no user. Fix by mocking useAuth.
|
|
||||||
|
|
||||||
## Summary of Changes\n\nMocked `useAuth` in Layout.test.tsx instead of using real AuthProvider. Added separate test groups for logged-out and logged-in-as-admin states, verifying correct nav links appear in each. All 118 frontend tests pass.
|
|
||||||
@@ -1,11 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-m8ki
|
|
||||||
title: Split e2e tests into manual workflow
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-02-21T16:53:37Z
|
|
||||||
updated_at: 2026-02-21T16:54:04Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Remove e2e-tests job from ci.yml and create a new e2e.yml workflow with workflow_dispatch trigger only.
|
|
||||||
@@ -1,32 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-mg99
|
|
||||||
title: 'Crash: Add detailed boss battle information'
|
|
||||||
status: scrapped
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:01:08Z
|
|
||||||
updated_at: 2026-03-20T19:29:55Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-neqv
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-neqv.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZErAh36SY2uCVFvs6pe8"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-neqv
|
|
||||||
- Title: Add detailed boss battle information
|
|
||||||
- Type: epic
|
|
||||||
|
|
||||||
## Reasons for Scrapping
|
|
||||||
|
|
||||||
This is a crash report bean created when a previous agent session expired due to OAuth token timeout. This is a transient infrastructure issue, not a code bug. The original work is tracked in the child beans of nuzlocke-tracker-neqv.
|
|
||||||
@@ -1,32 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-mygi
|
|
||||||
title: 'Crash: Crash: Add detailed boss battle information'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:13:19Z
|
|
||||||
updated_at: 2026-03-20T19:30:01Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-mg99
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-mg99.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEs6XKwjZQ4HoyPLXVxp"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-mg99
|
|
||||||
- Title: Crash: Add detailed boss battle information
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
## Reasons for Scrapping
|
|
||||||
|
|
||||||
This is a crash report bean created when a previous agent session expired due to OAuth token timeout. This is a transient infrastructure issue, not a code bug. The original work is tracked in the child beans of nuzlocke-tracker-neqv.
|
|
||||||
@@ -1,30 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-n926
|
|
||||||
title: 'Crash: Crash: Add detailed boss pokemon information (ability, item, nature, moveset)'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:13:24Z
|
|
||||||
updated_at: 2026-03-20T19:37:57Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-fbcs
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-fbcs.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEs6sYsQqU6dmmpwcmTM"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-fbcs
|
|
||||||
- Title: Crash: Add detailed boss pokemon information (ability, item, nature, moveset)
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
## Resolution\n\nThe crash was caused by OAuth token expiration. Resumed work and completed the original feature (nuzlocke-tracker-nvd6).
|
|
||||||
@@ -1,11 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-na3s
|
|
||||||
title: Allow multiple games per region in Custom genlocke
|
|
||||||
status: completed
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-17T12:29:57Z
|
|
||||||
updated_at: 2026-03-17T12:32:05Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Users want to run multiple games from the same region in a genlocke (e.g., Black + Black 2 in Unova). Change availableRegions computation so custom mode shows all regions, and add a subtle indicator for already-used regions in AddLegDropdown.
|
|
||||||
@@ -1,36 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-ndpz
|
|
||||||
title: 'Crash: User Account integration'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T19:00:42Z
|
|
||||||
updated_at: 2026-03-20T19:18:25Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-d98o
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-d98o.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEr8m1A9hiKCVyBgkCJB"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-d98o
|
|
||||||
- Title: User Account integration
|
|
||||||
- Type: epic
|
|
||||||
|
|
||||||
## Resolution
|
|
||||||
|
|
||||||
This crash was caused by Claude's OAuth token expiring during an agent session. This is an environmental/infrastructure issue, not a code bug. The token has been refreshed by starting a new agent session.
|
|
||||||
|
|
||||||
No code changes required.
|
|
||||||
@@ -1,17 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-neqv
|
|
||||||
title: Add detailed boss battle information
|
|
||||||
status: completed
|
|
||||||
type: epic
|
|
||||||
priority: low
|
|
||||||
created_at: 2026-02-08T11:21:22Z
|
|
||||||
updated_at: 2026-03-20T20:25:11Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Enhance boss battles with more detailed information. Split into child beans:
|
|
||||||
|
|
||||||
## Success Criteria
|
|
||||||
- [x] Moves and abilities tables seeded (names + introduced generation)
|
|
||||||
- [x] Boss pokemon entries support ability, held item, nature, and moveset
|
|
||||||
- [x] Boss battle results can capture a team snapshot
|
|
||||||
- [ ] (Future) Moves/abilities enriched with generation-specific stats
|
|
||||||
@@ -1,53 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-nvd6
|
|
||||||
title: Add detailed boss pokemon information (ability, item, nature, moveset)
|
|
||||||
status: completed
|
|
||||||
type: feature
|
|
||||||
priority: low
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T15:11:50Z
|
|
||||||
updated_at: 2026-03-20T19:37:18Z
|
|
||||||
parent: nuzlocke-tracker-neqv
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-vc5o
|
|
||||||
---
|
|
||||||
|
|
||||||
Add optional detail fields to boss pokemon entries: ability, held item, nature, and moveset (up to 4 moves).
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
- Ability and moves reference the seeded `moves`/`abilities` tables via FK (hybrid approach — names only, no gen-specific stats yet)
|
|
||||||
- Held item and nature stored as plain strings (items table can come later; natures are static)
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
- [x] **Migration**: Add columns to `boss_pokemon` — `ability_id` (FK|null), `held_item` (str|null), `nature` (str|null), `move1_id`–`move4_id` (FK|null)
|
|
||||||
- [x] **Model**: Update `BossPokemon` in `backend/src/app/models/boss_pokemon.py` with relationships
|
|
||||||
- [x] **Schemas**: Update `BossPokemonResponse` and `BossPokemonInput` in `backend/src/app/schemas/boss.py`
|
|
||||||
- [x] **Admin UI**: Add fields to `BossTeamEditor.tsx` (ability autocomplete, item input, nature dropdown, 4 move autocomplete inputs)
|
|
||||||
- [x] **Frontend types**: Update `BossPokemon` in `frontend/src/types/game.ts` and admin input types
|
|
||||||
- [x] **Frontend display**: Show details on boss cards in `RunEncounters.tsx` and `BossDefeatModal.tsx`
|
|
||||||
- [~] **Seed data**: (deferred) Update bulk import format to support new fields
|
|
||||||
|
|
||||||
## Dependencies
|
|
||||||
- Requires moves and abilities tables to be seeded first
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
### Backend
|
|
||||||
- Created migration `l3a4b5c6d7e8_add_boss_pokemon_details.py` adding `ability_id`, `held_item`, `nature`, `move1_id`-`move4_id` columns
|
|
||||||
- Updated `BossPokemon` model with relationships to `Ability` and `Move`
|
|
||||||
- Updated `BossPokemonResponse` and `BossPokemonInput` schemas with detail fields
|
|
||||||
- Created `/moves` and `/abilities` API endpoints for autocomplete search
|
|
||||||
- Updated `set_boss_team` endpoint to handle new fields
|
|
||||||
- Added eager loading for ability/moves in boss queries
|
|
||||||
|
|
||||||
### Frontend
|
|
||||||
- Added `MoveRef` and `AbilityRef` types to game.ts
|
|
||||||
- Extended `BossPokemon` type with detail fields
|
|
||||||
- Extended `BossPokemonInput` admin type
|
|
||||||
- Created `MoveSelector` and `AbilitySelector` autocomplete components
|
|
||||||
- Updated `BossTeamEditor` with expandable detail section per pokemon
|
|
||||||
- Updated `BossTeamPreview` and `BossDefeatModal` to display details
|
|
||||||
|
|
||||||
### Deferred
|
|
||||||
- Bulk import format for seed data not updated (optional fields work with existing format)
|
|
||||||
@@ -1,30 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-pl1m
|
|
||||||
title: 'Crash: Crash: Frontend auth flow (login, signup, session management)'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:13:10Z
|
|
||||||
updated_at: 2026-03-20T19:27:57Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-8vev
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-8vev.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEs5tdpug65ZR5M3DSQS"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-8vev
|
|
||||||
- Title: Crash: Frontend auth flow (login, signup, session management)
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
## Resolution\n\nThis was an infrastructure issue (Claude API OAuth token expired), not a code bug. Continuing work on the original feature bean (nuzlocke-tracker-l9xh).
|
|
||||||
@@ -1,24 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-t90q
|
|
||||||
title: 'Crash: Backend: Journal entries model, API, and migration'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T15:30:02Z
|
|
||||||
updated_at: 2026-03-20T15:39:13Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-vmto
|
|
||||||
---
|
|
||||||
|
|
||||||
Bean was found in 'in-progress' status on startup but no agent was running.
|
|
||||||
This likely indicates a crash or unexpected termination.
|
|
||||||
|
|
||||||
Manual review required before retrying.
|
|
||||||
|
|
||||||
Bean: nuzlocke-tracker-vmto
|
|
||||||
Title: Backend: Journal entries model, API, and migration
|
|
||||||
|
|
||||||
## Resolution
|
|
||||||
|
|
||||||
The underlying bean (nuzlocke-tracker-vmto) was already completed before the crash was detected. All backend work for journal entries is implemented and functional. A separate bug bean (nuzlocke-tracker-d5ht) was created for frontend TypeScript errors discovered during review.
|
|
||||||
@@ -1,30 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-ueub
|
|
||||||
title: 'Crash: Add team snapshot to boss battle results'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T19:01:23Z
|
|
||||||
updated_at: 2026-03-20T19:41:51Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-xd9j
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-xd9j.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZErBmcConDqezwzK8kaP"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-xd9j
|
|
||||||
- Title: Add team snapshot to boss battle results
|
|
||||||
- Type: feature
|
|
||||||
@@ -1,53 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-vc5o
|
|
||||||
title: Seed moves and abilities tables (names + introduced generation)
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T15:11:44Z
|
|
||||||
updated_at: 2026-03-20T15:25:11Z
|
|
||||||
parent: nuzlocke-tracker-neqv
|
|
||||||
---
|
|
||||||
|
|
||||||
Create and seed `moves` and `abilities` tables with name and generation data using the hybrid approach.
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
Seed move/ability **names** with `introduced_gen` only. Full generation-specific stats (power, accuracy, type changes, effect text) will be added in a follow-up bean.
|
|
||||||
|
|
||||||
This enables FK references and autocomplete from boss pokemon fields without blocking on a full moves database.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
- [x] **Migration**: Create `moves` table (`id`, `name`, `introduced_gen`, `type` optional)
|
|
||||||
- [x] **Migration**: Create `abilities` table (`id`, `name`, `introduced_gen`)
|
|
||||||
- [x] **Models**: Create `Move` and `Ability` SQLAlchemy models
|
|
||||||
- [x] **Seed data**: Seed all move names with introduced generation (source: PokeAPI or Bulbapedia)
|
|
||||||
- [x] **Seed data**: Seed all ability names with introduced generation
|
|
||||||
- [x] **Seed script**: Add to existing seeding pipeline (`backend/src/app/seed/`)
|
|
||||||
- [x] **Schemas**: Create basic response schemas for API consumption
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
### Migration
|
|
||||||
- Created `j1e2f3a4b5c6_add_moves_and_abilities_tables.py` migration
|
|
||||||
- `moves` table: `id`, `name` (unique), `introduced_gen`, `type` (optional)
|
|
||||||
- `abilities` table: `id`, `name` (unique), `introduced_gen`
|
|
||||||
- Added indexes on `introduced_gen` for both tables
|
|
||||||
|
|
||||||
### Models
|
|
||||||
- `backend/src/app/models/move.py`: `Move` SQLAlchemy model
|
|
||||||
- `backend/src/app/models/ability.py`: `Ability` SQLAlchemy model
|
|
||||||
- Updated `models/__init__.py` to export both
|
|
||||||
|
|
||||||
### Schemas
|
|
||||||
- `backend/src/app/schemas/move.py`: `MoveResponse`, `AbilityResponse`, and paginated variants
|
|
||||||
- Updated `schemas/__init__.py` to export all new schemas
|
|
||||||
|
|
||||||
### Seed Data
|
|
||||||
- Created `backend/scripts/fetch_moves_abilities.py` to fetch data from PokeAPI
|
|
||||||
- Generated `moves.json` (937 moves) and `abilities.json` (367 abilities)
|
|
||||||
- Data includes name, introduced generation, and type (for moves)
|
|
||||||
|
|
||||||
### Seed Pipeline
|
|
||||||
- Added `upsert_moves` and `upsert_abilities` functions to `loader.py`
|
|
||||||
- Updated `run.py` to seed moves and abilities after Pokemon
|
|
||||||
- Updated `verify()` to include move/ability counts
|
|
||||||
@@ -1,62 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-vmto
|
|
||||||
title: 'Backend: Journal entries model, API, and migration'
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: normal
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T15:15:48Z
|
|
||||||
updated_at: 2026-03-20T15:30:47Z
|
|
||||||
parent: nuzlocke-tracker-mz16
|
|
||||||
---
|
|
||||||
|
|
||||||
Create the backend infrastructure for session journal entries.
|
|
||||||
|
|
||||||
## Data Model
|
|
||||||
|
|
||||||
`journal_entries` table:
|
|
||||||
- `id` (UUID, PK)
|
|
||||||
- `run_id` (FK to runs)
|
|
||||||
- `boss_result_id` (FK to boss_results, nullable) — optional link to a boss battle
|
|
||||||
- `title` (str, required)
|
|
||||||
- `body` (text, required) — raw markdown content
|
|
||||||
- `created_at`, `updated_at` (timestamps)
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Create Alembic migration for `journal_entries` table
|
|
||||||
- [x] Create `JournalEntry` SQLAlchemy model with relationships to `Run` and `BossResult`
|
|
||||||
- [x] Create Pydantic schemas (`JournalEntryCreate`, `JournalEntryUpdate`, `JournalEntryResponse`)
|
|
||||||
- [x] Create CRUD operations for journal entries
|
|
||||||
- [x] Create API endpoints under `/runs/{run_id}/journal`:
|
|
||||||
- `GET /` — list entries for a run (ordered by created_at desc)
|
|
||||||
- `POST /` — create entry
|
|
||||||
- `GET /{entry_id}` — get single entry
|
|
||||||
- `PUT /{entry_id}` — update entry
|
|
||||||
- `DELETE /{entry_id}` — delete entry
|
|
||||||
- [x] Add optional `boss_result_id` query filter to GET list endpoint
|
|
||||||
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Implemented backend infrastructure for session journal entries:
|
|
||||||
|
|
||||||
**Files created:**
|
|
||||||
- `backend/src/app/alembic/versions/k2f3a4b5c6d7_add_journal_entries_table.py` - Migration creating `journal_entries` table with UUID PK, foreign keys to `nuzlocke_runs` and `boss_results`, and timestamp columns
|
|
||||||
- `backend/src/app/models/journal_entry.py` - SQLAlchemy model with relationships to `NuzlockeRun` and `BossResult`
|
|
||||||
- `backend/src/app/schemas/journal_entry.py` - Pydantic schemas for create, update, and response
|
|
||||||
- `backend/src/app/api/journal_entries.py` - API endpoints for CRUD operations
|
|
||||||
|
|
||||||
**Files modified:**
|
|
||||||
- `backend/src/app/models/nuzlocke_run.py` - Added `journal_entries` relationship
|
|
||||||
- `backend/src/app/models/__init__.py` - Exported `JournalEntry`
|
|
||||||
- `backend/src/app/schemas/__init__.py` - Exported journal entry schemas
|
|
||||||
- `backend/src/app/api/routes.py` - Registered journal entries router
|
|
||||||
|
|
||||||
**API Endpoints:**
|
|
||||||
- `GET /runs/{run_id}/journal` - List entries (supports `boss_result_id` filter)
|
|
||||||
- `POST /runs/{run_id}/journal` - Create entry
|
|
||||||
- `GET /runs/{run_id}/journal/{entry_id}` - Get single entry
|
|
||||||
- `PUT /runs/{run_id}/journal/{entry_id}` - Update entry
|
|
||||||
- `DELETE /runs/{run_id}/journal/{entry_id}` - Delete entry
|
|
||||||
@@ -1,39 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-vw1z
|
|
||||||
title: 'Crash: Crash: Add team snapshot to boss battle results'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:13:27Z
|
|
||||||
updated_at: 2026-03-20T19:41:58Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-ueub
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-ueub.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEs79fEcc7KikDZH5tuz"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-ueub
|
|
||||||
- Title: Crash: Add team snapshot to boss battle results
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
This crash was caused by an OAuth token expiration, not a code issue. The original feature (add team snapshot to boss battle results) has been implemented:
|
|
||||||
|
|
||||||
- Created `boss_result_team` table migration
|
|
||||||
- Added `BossResultTeam` model with relationships
|
|
||||||
- Updated schemas with `BossResultTeamMemberInput` and `BossResultTeamMemberResponse`
|
|
||||||
- Updated `POST /runs/{run_id}/boss-results` API to accept and save team snapshots
|
|
||||||
- Updated `BossDefeatModal` with checkboxes for alive team members with level input
|
|
||||||
- Added team snapshot display in boss cards on `RunEncounters.tsx`
|
|
||||||
@@ -1,11 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-wb85
|
|
||||||
title: Replace playstyle rules with custom rules markdown field
|
|
||||||
status: completed
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-20T13:48:50Z
|
|
||||||
updated_at: 2026-03-20T13:53:08Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Remove hardcoreMode, setModeOnly, bossTeamMatch playstyle rules. Add a free-text markdown customRules field so users can track their own rules (especially useful for genlockes). Also: remove 'Lost' result and attempts from BossDefeatModal, always show boss team size.
|
|
||||||
@@ -1,23 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-wwnu
|
|
||||||
title: Auth hardening, admin ownership display, and MFA
|
|
||||||
status: completed
|
|
||||||
type: epic
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-21T12:18:09Z
|
|
||||||
updated_at: 2026-03-21T12:38:27Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Harden authentication and authorization across the app after the initial auth integration went live.
|
|
||||||
|
|
||||||
## Goals
|
|
||||||
|
|
||||||
- [x] Runs are only editable by their owner (encounters, deaths, bosses, settings)
|
|
||||||
- [x] Frontend hides edit controls for non-owners and logged-out users
|
|
||||||
- [x] Admin pages show owner info for runs and genlockes
|
|
||||||
- [ ] Genlocke visibility/ownership inferred from first leg's run
|
|
||||||
- [ ] Optional TOTP MFA for email/password signups
|
|
||||||
|
|
||||||
## Context
|
|
||||||
|
|
||||||
Auth is live with Google/Discord OAuth + email/password. Backend has `require_auth` on mutations but doesn't check ownership on encounters or genlockes. Frontend `RunEncounters.tsx` has zero auth checks. Admin pages lack owner columns. Genlocke model has no `owner_id` or `visibility`.
|
|
||||||
@@ -1,24 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-wwwq
|
|
||||||
title: 'Crash: Show owner info in admin pages'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-21T12:49:42Z
|
|
||||||
updated_at: 2026-03-21T12:51:18Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-2fp1
|
|
||||||
---
|
|
||||||
|
|
||||||
Bean was found in 'in-progress' status on startup but no agent was running.
|
|
||||||
This likely indicates a crash or unexpected termination.
|
|
||||||
|
|
||||||
Manual review required before retrying.
|
|
||||||
|
|
||||||
Bean: nuzlocke-tracker-2fp1
|
|
||||||
Title: Show owner info in admin pages
|
|
||||||
|
|
||||||
## Reasons for Scrapping
|
|
||||||
|
|
||||||
The original bean (nuzlocke-tracker-2fp1) had all work completed and committed before the crash occurred. The agent crashed after completing the implementation but before marking the bean as completed. No additional work was needed - just updated the original bean's status to completed.
|
|
||||||
@@ -1,34 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-xd9j
|
|
||||||
title: Add team snapshot to boss battle results
|
|
||||||
status: completed
|
|
||||||
type: feature
|
|
||||||
priority: low
|
|
||||||
tags:
|
|
||||||
- failed
|
|
||||||
created_at: 2026-03-20T15:11:53Z
|
|
||||||
updated_at: 2026-03-20T19:41:44Z
|
|
||||||
parent: nuzlocke-tracker-neqv
|
|
||||||
---
|
|
||||||
|
|
||||||
When recording a boss battle result, allow the player to snapshot which alive team pokemon they used and at what levels. This gives a record of "what I brought to the fight."
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
- [x] **Migration**: Create \`boss_result_team\` table (\`id\`, \`boss_result_id\` FK, \`encounter_id\` FK, \`level\`)
|
|
||||||
- [x] **Model**: Create \`BossResultTeam\` model, add relationship to \`BossResult\`
|
|
||||||
- [x] **Schemas**: Add \`BossResultTeamInput\` and update \`BossResultCreate\`/\`BossResultResponse\`
|
|
||||||
- [x] **API**: Update \`POST /runs/{run_id}/boss-results\` to accept and save team snapshot
|
|
||||||
- [x] **BossDefeatModal**: Add checkboxes for alive team members with optional level override
|
|
||||||
- [x] **Display**: Show team snapshot when viewing past boss results in \`RunEncounters.tsx\`
|
|
||||||
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Implemented team snapshot feature for boss battle results:
|
|
||||||
|
|
||||||
- Created `boss_result_team` table (`id`, `boss_result_id` FK, `encounter_id` FK, `level`)
|
|
||||||
- Added `BossResultTeam` model with relationship to `BossResult`
|
|
||||||
- Updated schemas with `BossResultTeamMemberInput` and `BossResultTeamMemberResponse`
|
|
||||||
- Updated `POST /runs/{run_id}/boss-results` to validate and save team snapshot
|
|
||||||
- Added team selection UI in `BossDefeatModal` with level override
|
|
||||||
- Display team snapshot in defeated boss cards on `RunEncounters.tsx`
|
|
||||||
@@ -1,37 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-xsdr
|
|
||||||
title: 'Crash: Crash: Bug: TypeScript build fails due to optional property type mismatches in journal components'
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-20T19:12:50Z
|
|
||||||
updated_at: 2026-03-20T19:17:39Z
|
|
||||||
parent: nuzlocke-tracker-bw1m
|
|
||||||
blocking:
|
|
||||||
- nuzlocke-tracker-3psa
|
|
||||||
---
|
|
||||||
|
|
||||||
Agent crashed while working on nuzlocke-tracker-3psa.
|
|
||||||
|
|
||||||
## Exit Code
|
|
||||||
1
|
|
||||||
|
|
||||||
## Last Output
|
|
||||||
```
|
|
||||||
Failed to authenticate. API Error: 401 {"type":"error","error":{"type":"authentication_error","message":"OAuth token has expired. Please obtain a new token or refresh your existing token."},"request_id":"req_011CZEs4QPgAQoZbS63nnkqT"}
|
|
||||||
|
|
||||||
```
|
|
||||||
|
|
||||||
## Context
|
|
||||||
- Bean: nuzlocke-tracker-3psa
|
|
||||||
- Title: Crash: Bug: TypeScript build fails due to optional property type mismatches in journal components
|
|
||||||
- Type: bug
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Fixed TypeScript build errors caused by `exactOptionalPropertyTypes: true` requiring explicit `| undefined` in optional property types.
|
|
||||||
|
|
||||||
**Files changed:**
|
|
||||||
- `JournalEditor.tsx`: Added `| undefined` to `bossResults` and `bosses` prop types
|
|
||||||
- `JournalEntryView.tsx`: Added `| undefined` to `bossResult` and `boss` prop types
|
|
||||||
- `JournalSection.tsx`: Added `| undefined` to `bossResults` and `bosses` prop types
|
|
||||||
@@ -1,43 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-2fp1
|
|
||||||
title: Show owner info in admin pages
|
|
||||||
status: in-progress
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T12:18:51Z
|
|
||||||
updated_at: 2026-03-21T12:37:36Z
|
|
||||||
parent: nuzlocke-tracker-wwnu
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
Admin pages (`AdminRuns.tsx`, `AdminGenlockes.tsx`) don't show which user owns each run or genlocke. This makes it hard for admins to manage content.
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
### Backend
|
|
||||||
- The `/api/runs` list endpoint already returns run data — verify it includes `owner` (id + email). If not, add it to the response schema.
|
|
||||||
- For genlockes, ownership is inferred from the first leg's run owner. Add an `owner` field to the genlocke list response that resolves from the first leg's run.
|
|
||||||
|
|
||||||
### Frontend
|
|
||||||
- `AdminRuns.tsx`: Add an "Owner" column showing the owner's email (or "No owner" for legacy runs)
|
|
||||||
- `AdminGenlockes.tsx`: Add an "Owner" column showing the inferred owner from the first leg's run
|
|
||||||
- Add owner filter dropdown to both pages
|
|
||||||
|
|
||||||
## Files to modify
|
|
||||||
|
|
||||||
- `backend/src/app/api/runs.py` — verify owner is included in list response
|
|
||||||
- `backend/src/app/api/genlockes.py` — add owner resolution to list endpoint
|
|
||||||
- `backend/src/app/schemas/genlocke.py` — add owner field to `GenlockeListItem`
|
|
||||||
- `frontend/src/pages/admin/AdminRuns.tsx` — add Owner column + filter
|
|
||||||
- `frontend/src/pages/admin/AdminGenlockes.tsx` — add Owner column + filter
|
|
||||||
- `frontend/src/types/game.ts` — update types if needed
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Verify runs list API includes owner info; add if missing
|
|
||||||
- [x] Add owner resolution to genlocke list endpoint (from first leg's run)
|
|
||||||
- [x] Update `GenlockeListItem` schema to include owner
|
|
||||||
- [x] Add Owner column to `AdminRuns.tsx`
|
|
||||||
- [x] Add Owner column to `AdminGenlockes.tsx`
|
|
||||||
- [x] Add owner filter to both admin pages
|
|
||||||
@@ -1,29 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-532i
|
|
||||||
title: 'UX: Make level field optional in boss defeat modal'
|
|
||||||
status: todo
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T21:50:48Z
|
|
||||||
updated_at: 2026-03-21T22:04:08Z
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
When recording which team members beat a boss, users must manually enter a level for each pokemon. Since the app does not track levels anywhere else, this is unnecessary friction with no payoff.
|
|
||||||
|
|
||||||
## Current Implementation
|
|
||||||
|
|
||||||
- Level input in `BossDefeatModal.tsx:200-211`
|
|
||||||
- DB column `boss_result_team.level` is `SmallInteger NOT NULL` (in `models.py`)
|
|
||||||
- Level is required in the API schema
|
|
||||||
|
|
||||||
## Proposed Solution
|
|
||||||
|
|
||||||
Remove the level field entirely from the UI and make it optional in the backend:
|
|
||||||
|
|
||||||
- [ ] Remove level input from `BossDefeatModal.tsx`
|
|
||||||
- [ ] Make `level` column nullable in the database (alembic migration)
|
|
||||||
- [ ] Update the API schema to make level optional (default to null)
|
|
||||||
- [ ] Update any backend validation that requires level
|
|
||||||
- [ ] Verify boss result display still works without level data
|
|
||||||
@@ -1,84 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-73ba
|
|
||||||
title: Enforce run ownership on all mutation endpoints
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: critical
|
|
||||||
created_at: 2026-03-21T12:18:27Z
|
|
||||||
updated_at: 2026-03-21T12:28:35Z
|
|
||||||
parent: nuzlocke-tracker-wwnu
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
Backend mutation endpoints for encounters, bosses, and run updates use `require_auth` but do NOT verify the authenticated user is the run's owner. Any authenticated user can modify any run's encounters, mark bosses as defeated, or change run settings.
|
|
||||||
|
|
||||||
Additionally, `_check_run_access` in `runs.py:184` allows anyone to edit unowned (legacy) runs when `require_owner=False`.
|
|
||||||
|
|
||||||
### Affected endpoints
|
|
||||||
|
|
||||||
**encounters.py** — all mutations use `require_auth` with no ownership check:
|
|
||||||
- `POST /runs/{run_id}/encounters` (line 35)
|
|
||||||
- `PATCH /runs/{run_id}/encounters/{encounter_id}` (line 142)
|
|
||||||
- `DELETE /runs/{run_id}/encounters/{encounter_id}` (line 171)
|
|
||||||
- `POST /runs/{run_id}/encounters/bulk-randomize` (line 203)
|
|
||||||
|
|
||||||
**bosses.py** — boss result mutations:
|
|
||||||
- `POST /runs/{run_id}/boss-results` (line 347)
|
|
||||||
- `DELETE /runs/{run_id}/boss-results/{result_id}` (line 428)
|
|
||||||
|
|
||||||
**runs.py** — run updates/deletion:
|
|
||||||
- `PATCH /runs/{run_id}` (line 379) — uses `_check_run_access(run, user, require_owner=run.owner_id is not None)` which skips check for unowned runs
|
|
||||||
- `DELETE /runs/{run_id}` (line 488) — same conditional check
|
|
||||||
|
|
||||||
**genlockes.py** — genlocke mutations:
|
|
||||||
- `POST /genlockes` (line 439) — no owner assigned to created genlocke or its first run
|
|
||||||
- `PATCH /genlockes/{id}` (line 824) — no ownership check
|
|
||||||
- `DELETE /genlockes/{id}` (line 862) — no ownership check
|
|
||||||
- `POST /genlockes/{id}/legs/{leg_order}/advance` (line 569) — no ownership check
|
|
||||||
- `POST /genlockes/{id}/legs` (line 894) — no ownership check
|
|
||||||
- `DELETE /genlockes/{id}/legs/{leg_id}` (line 936) — no ownership check
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
1. Add a reusable `_check_run_owner(run, user)` helper in `auth.py` or `runs.py` that raises 403 if `user.id != str(run.owner_id)` (no fallback for unowned runs — they should be read-only)
|
|
||||||
2. Apply ownership check to ALL encounter/boss/run mutation endpoints
|
|
||||||
3. For genlocke mutations, load the first leg's run and verify ownership against that
|
|
||||||
4. Update `_check_run_access` to always require ownership for mutations (remove the `require_owner` conditional)
|
|
||||||
5. When creating runs (standalone or via genlocke), set `owner_id` from the authenticated user
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Add `_check_run_owner` helper that rejects non-owners (including unowned/legacy runs)
|
|
||||||
- [x] Apply ownership check to all 4 encounter mutation endpoints
|
|
||||||
- [x] Apply ownership check to both boss result mutation endpoints
|
|
||||||
- [x] Fix `_check_run_access` to always require ownership on mutations
|
|
||||||
- [x] Set `owner_id` on run creation in `runs.py` and `genlockes.py` (create_genlocke, advance_leg)
|
|
||||||
- [x] Apply ownership check to all genlocke mutation endpoints (via first leg's run owner)
|
|
||||||
- [x] Add tests for ownership enforcement (403 for non-owner, 401 for unauthenticated)
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
Added `require_run_owner` helper in `auth.py` that enforces ownership on mutation endpoints:
|
|
||||||
- Returns 403 for unowned (legacy) runs - they are now read-only
|
|
||||||
- Returns 403 if authenticated user is not the run's owner
|
|
||||||
|
|
||||||
Applied ownership checks to:
|
|
||||||
- All 4 encounter mutation endpoints (create, update, delete, bulk-randomize)
|
|
||||||
- Both boss result mutation endpoints (create, delete)
|
|
||||||
- Run update and delete endpoints (via `require_run_owner`)
|
|
||||||
- All 5 genlocke mutation endpoints (update, delete, advance_leg, add_leg, remove_leg via `_check_genlocke_owner`)
|
|
||||||
|
|
||||||
Added `owner_id` on run creation:
|
|
||||||
- `runs.py`: create_run already sets owner_id (verified)
|
|
||||||
- `genlockes.py`: create_genlocke now sets owner_id on the first run
|
|
||||||
- `genlockes.py`: advance_leg preserves owner_id from current run to new run
|
|
||||||
|
|
||||||
Renamed `_check_run_access` to `_check_run_read_access` (read-only visibility check) for clarity.
|
|
||||||
|
|
||||||
Added 22 comprehensive tests in `test_ownership.py` covering:
|
|
||||||
- Owner can perform mutations
|
|
||||||
- Non-owner gets 403 on mutations
|
|
||||||
- Unauthenticated user gets 401
|
|
||||||
- Unowned (legacy) runs reject all mutations
|
|
||||||
- Read access preserved for public runs
|
|
||||||
@@ -1,36 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-8b25
|
|
||||||
title: 'UX: Allow editing caught pokemon details on run page'
|
|
||||||
status: draft
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T22:00:55Z
|
|
||||||
updated_at: 2026-03-21T22:04:08Z
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
Users can mistype catch level, nickname, or other details when recording an encounter, but there's no way to correct mistakes from the run page. The only option is to go through admin — which doesn't even support editing encounters for a specific run.
|
|
||||||
|
|
||||||
## Current State
|
|
||||||
|
|
||||||
- **Backend `EncounterUpdate` schema** (`backend/src/app/schemas/encounter.py:18-23`): Supports `nickname`, `status`, `faint_level`, `death_cause`, `current_pokemon_id` — but NOT `catch_level`
|
|
||||||
- **Frontend `UpdateEncounterInput`** (`frontend/src/types/game.ts:169-175`): Same fields as backend, missing `catch_level`
|
|
||||||
- **Run page encounter modal**: Clicking a route with an existing encounter opens the modal in "edit" mode, but only allows changing pokemon/nickname/status — no catch_level editing
|
|
||||||
- The encounter modal is the create/edit modal — editing is done by re-opening it on an existing encounter
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
### Backend
|
|
||||||
- [ ] Add `catch_level: int | None = None` to `EncounterUpdate` schema
|
|
||||||
- [ ] Verify the PATCH `/encounters/{id}` endpoint applies `catch_level` updates (check `encounters.py` update handler)
|
|
||||||
|
|
||||||
### Frontend
|
|
||||||
- [ ] Add `catchLevel?: number` to `UpdateEncounterInput` type
|
|
||||||
- [ ] Ensure the encounter modal shows catch_level as editable when editing an existing encounter
|
|
||||||
- [ ] Add catch_level field to the encounter edit modal (shown when editing existing encounters)
|
|
||||||
|
|
||||||
### Testing
|
|
||||||
- [ ] Test updating catch_level via API
|
|
||||||
- [ ] Test that the frontend sends catch_level in update requests
|
|
||||||
- [ ] Verify existing create/update flows still work
|
|
||||||
@@ -1,38 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-9i9m
|
|
||||||
title: Admin interface overhaul
|
|
||||||
status: draft
|
|
||||||
type: epic
|
|
||||||
created_at: 2026-03-21T21:58:48Z
|
|
||||||
updated_at: 2026-03-21T21:58:48Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Overhaul the admin interface to reduce navigation depth for game data management and add proper run administration.
|
|
||||||
|
|
||||||
## Problems
|
|
||||||
|
|
||||||
1. **Game data navigation is too deep** — Adding an encounter requires navigating Games → Game Detail → Route Detail (3 levels). This is rare but painful when needed.
|
|
||||||
2. **No way to search across admin entities** — You have to manually drill down through the hierarchy to find anything.
|
|
||||||
3. **Run admin is view+delete only** — Clicking a run row immediately opens a delete confirmation. No way to edit name, status, owner, visibility, or other metadata.
|
|
||||||
|
|
||||||
## Solution
|
|
||||||
|
|
||||||
### Game Data Navigation
|
|
||||||
- Add a **global search bar** to the admin layout header that lets you jump directly to any game, route, encounter, or pokemon by name
|
|
||||||
- Add **flattened views** for routes (`/admin/routes`) and encounters (`/admin/encounters`) as top-level admin pages with game/region filters, so you don't have to drill down through the game hierarchy
|
|
||||||
|
|
||||||
### Run Administration
|
|
||||||
- Add a **slide-over panel** that opens when clicking a run row (replacing the current delete-on-click behavior)
|
|
||||||
- Panel shows editable metadata: name, status, owner, visibility, rules, naming scheme
|
|
||||||
- Add admin-only backend endpoint for owner reassignment
|
|
||||||
- Keep delete as a button inside the panel (not the primary action)
|
|
||||||
|
|
||||||
## Success Criteria
|
|
||||||
|
|
||||||
- [ ] Global admin search bar in layout header
|
|
||||||
- [ ] Flattened routes page (`/admin/routes`) with game filter
|
|
||||||
- [ ] Flattened encounters page (`/admin/encounters`) with game/route filters
|
|
||||||
- [ ] Admin nav updated with new pages
|
|
||||||
- [ ] Run slide-over panel with metadata editing
|
|
||||||
- [ ] Admin endpoint for owner reassignment
|
|
||||||
- [ ] Delete moved inside slide-over panel
|
|
||||||
@@ -1,37 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-b4d8
|
|
||||||
title: Flattened admin routes page
|
|
||||||
status: draft
|
|
||||||
type: feature
|
|
||||||
created_at: 2026-03-21T21:59:20Z
|
|
||||||
updated_at: 2026-03-21T21:59:20Z
|
|
||||||
parent: nuzlocke-tracker-9i9m
|
|
||||||
---
|
|
||||||
|
|
||||||
Add a top-level `/admin/routes` page that shows all routes across all games, with filters for game and region. Eliminates the need to drill into a specific game just to find a route.
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
- New page at `/admin/routes` showing all routes in a table
|
|
||||||
- Columns: Route Name, Game, Region/Area, Order, Pokemon Count
|
|
||||||
- Filters: game dropdown, text search
|
|
||||||
- Clicking a route navigates to the existing `/admin/games/:gameId/routes/:routeId` detail page
|
|
||||||
- Reuse existing `useRoutes` or add a new hook that fetches all routes across games
|
|
||||||
|
|
||||||
## Files to modify
|
|
||||||
|
|
||||||
- `frontend/src/pages/admin/AdminRoutes.tsx` — New page
|
|
||||||
- `frontend/src/pages/admin/index.ts` — Export new page
|
|
||||||
- `frontend/src/App.tsx` — Add route
|
|
||||||
- `frontend/src/components/admin/AdminLayout.tsx` — Add nav item
|
|
||||||
- Possibly `frontend/src/hooks/` — Hook for fetching all routes
|
|
||||||
- Possibly `backend/app/routes/` — Endpoint for listing all routes (if not already available)
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [ ] AdminRoutes page with table of all routes
|
|
||||||
- [ ] Game filter dropdown
|
|
||||||
- [ ] Text search filter
|
|
||||||
- [ ] Click navigates to route detail page
|
|
||||||
- [ ] Nav item added to admin sidebar
|
|
||||||
- [ ] Route registered in App.tsx
|
|
||||||
@@ -1,11 +1,11 @@
|
|||||||
---
|
---
|
||||||
# nuzlocke-tracker-d98o
|
# nuzlocke-tracker-d98o
|
||||||
title: User Account integration
|
title: User Account integration
|
||||||
status: completed
|
status: draft
|
||||||
type: epic
|
type: epic
|
||||||
priority: normal
|
priority: deferred
|
||||||
created_at: 2026-02-04T16:17:01Z
|
created_at: 2026-02-04T16:17:01Z
|
||||||
updated_at: 2026-03-20T20:16:30Z
|
updated_at: 2026-02-10T12:05:43Z
|
||||||
blocking:
|
blocking:
|
||||||
- nuzlocke-tracker-0jec
|
- nuzlocke-tracker-0jec
|
||||||
---
|
---
|
||||||
@@ -35,10 +35,10 @@ Enable user accounts so players can track multiple Nuzlocke runs, access them fr
|
|||||||
- [ ] Delete account option (with data export)
|
- [ ] Delete account option (with data export)
|
||||||
|
|
||||||
### Multi-Run Support
|
### Multi-Run Support
|
||||||
- [x] Associate runs with user accounts
|
- [ ] Associate runs with user accounts
|
||||||
- [ ] Users can have unlimited runs
|
- [ ] Users can have unlimited runs
|
||||||
- [ ] Migrate any existing local/anonymous runs to account
|
- [ ] Migrate any existing local/anonymous runs to account
|
||||||
- [x] Run visibility settings (public by default, can be set to private)
|
- [ ] Run visibility settings (private by default)
|
||||||
|
|
||||||
### Runs Overview Page
|
### Runs Overview Page
|
||||||
- [ ] Dashboard showing all user's runs
|
- [ ] Dashboard showing all user's runs
|
||||||
@@ -75,18 +75,4 @@ Enable user accounts so players can track multiple Nuzlocke runs, access them fr
|
|||||||
## Out of Scope (for now)
|
## Out of Scope (for now)
|
||||||
- Social features (sharing runs, leaderboards)
|
- Social features (sharing runs, leaderboards)
|
||||||
- Team collaboration
|
- Team collaboration
|
||||||
- Public run profiles
|
- Public run profiles
|
||||||
|
|
||||||
## Decisions (resolved 2026-03-20)
|
|
||||||
|
|
||||||
- **Auth provider:** Supabase Auth (third-party, self-hostable, AWS-compatible)
|
|
||||||
- **Social login:** Google + Discord
|
|
||||||
- **Run migration:** Existing runs stay unowned, admin assigns manually post-signup
|
|
||||||
- **Auth scope:** Write operations require auth; per-run public/private visibility toggle
|
|
||||||
- **Editor for journal (related):** Plain markdown
|
|
||||||
|
|
||||||
## Execution Order
|
|
||||||
|
|
||||||
1. `nuzlocke-tracker-2561` — Supabase project setup (unblocked)
|
|
||||||
2. `nuzlocke-tracker-b311` + `nuzlocke-tracker-bnhh` + `nuzlocke-tracker-l9xh` — Backend auth, user model, frontend auth (parallel, after setup)
|
|
||||||
3. `nuzlocke-tracker-k1l1` — Run ownership + visibility (after all above)
|
|
||||||
@@ -1,39 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-e372
|
|
||||||
title: Flattened admin encounters page
|
|
||||||
status: draft
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T21:59:20Z
|
|
||||||
updated_at: 2026-03-21T22:04:08Z
|
|
||||||
parent: nuzlocke-tracker-9i9m
|
|
||||||
---
|
|
||||||
|
|
||||||
Add a top-level `/admin/encounters` page that shows all encounters across all games and routes, with filters. This is the deepest entity in the current hierarchy and the most painful to reach.
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
- New page at `/admin/encounters` showing all encounters in a table
|
|
||||||
- Columns: Pokemon, Route, Game, Encounter Rate, Method
|
|
||||||
- Filters: game dropdown, route dropdown (filtered by selected game), pokemon search
|
|
||||||
- Clicking an encounter navigates to the route detail page where it can be edited
|
|
||||||
- Requires new backend endpoint: GET /admin/encounters returning encounters joined with route name, game name, and pokemon name. Response shape: `{ id, pokemon_name, route_name, game_name, encounter_rate, method }`
|
|
||||||
|
|
||||||
## Files to modify
|
|
||||||
|
|
||||||
- `frontend/src/pages/admin/AdminEncounters.tsx` — New page
|
|
||||||
- `frontend/src/pages/admin/index.ts` — Export new page
|
|
||||||
- `frontend/src/App.tsx` — Add route
|
|
||||||
- `frontend/src/components/admin/AdminLayout.tsx` — Add nav item
|
|
||||||
- `backend/app/routes/` — Endpoint for listing all encounters with game/route context
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [ ] AdminEncounters page with table of all encounters
|
|
||||||
- [ ] Game filter dropdown
|
|
||||||
- [ ] Route filter dropdown (cascading from game)
|
|
||||||
- [ ] Pokemon name search
|
|
||||||
- [ ] Click navigates to route detail page
|
|
||||||
- [ ] Nav item added to admin sidebar
|
|
||||||
- [ ] Route registered in App.tsx
|
|
||||||
- [ ] Backend endpoint for listing all encounters
|
|
||||||
@@ -1,13 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-eg7j
|
|
||||||
title: Fix JWT verification failing in local dev (HS256 fallback)
|
|
||||||
status: completed
|
|
||||||
type: bug
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-22T08:37:18Z
|
|
||||||
updated_at: 2026-03-22T08:38:57Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Local GoTrue signs JWTs with HS256, but the JWKS migration only supports RS256. The JWKS endpoint returns empty keys locally, causing 500 errors on all authenticated endpoints. Add HS256 fallback using SUPABASE_JWT_SECRET for local dev.
|
|
||||||
|
|
||||||
## Summary of Changes\n\nAdded HS256 fallback to JWT verification so local GoTrue (which signs with HMAC) works alongside the JWKS/RS256 path used in production. Added `SUPABASE_JWT_SECRET` config setting, passed it in docker-compose.yml, and updated .env.example files.
|
|
||||||
@@ -1,56 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-f2hs
|
|
||||||
title: Optional TOTP MFA for email/password accounts
|
|
||||||
status: in-progress
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T12:19:18Z
|
|
||||||
updated_at: 2026-03-21T12:56:34Z
|
|
||||||
parent: nuzlocke-tracker-wwnu
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
Users who sign up with email/password have no MFA option. Google/Discord OAuth users get their provider's MFA, but email-only users have a weaker security posture.
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
Supabase has built-in TOTP MFA support via the `supabase.auth.mfa` API. This should be optional — users can enable it from their profile/settings page.
|
|
||||||
|
|
||||||
### Backend
|
|
||||||
- No backend changes needed — Supabase handles MFA enrollment and verification at the auth layer
|
|
||||||
- JWT tokens from MFA-enrolled users include an `aal` (authenticator assurance level) claim; optionally validate `aal2` for sensitive operations in the future
|
|
||||||
|
|
||||||
### Frontend
|
|
||||||
1. Add MFA setup flow to user profile/settings page:
|
|
||||||
- "Enable MFA" button → calls `supabase.auth.mfa.enroll({ factorType: 'totp' })`
|
|
||||||
- Show QR code from enrollment response
|
|
||||||
- Verify with TOTP code → `supabase.auth.mfa.challengeAndVerify()`
|
|
||||||
2. Add MFA challenge during login:
|
|
||||||
- After email/password sign-in, check `supabase.auth.mfa.getAuthenticatorAssuranceLevel()`
|
|
||||||
- If `currentLevel === 'aal1'` and `nextLevel === 'aal2'`, show TOTP input
|
|
||||||
- Verify → `supabase.auth.mfa.challengeAndVerify()`
|
|
||||||
3. Add "Disable MFA" option with re-verification
|
|
||||||
4. Only show MFA options for email/password users (not OAuth)
|
|
||||||
|
|
||||||
### UX
|
|
||||||
- Settings page: toggle to enable/disable MFA
|
|
||||||
- Login flow: TOTP input step after password for enrolled users
|
|
||||||
- Recovery: Supabase provides recovery codes during enrollment — display them
|
|
||||||
|
|
||||||
## Files to modify
|
|
||||||
|
|
||||||
- `frontend/src/pages/` — new MFA settings component or add to existing profile page
|
|
||||||
- `frontend/src/pages/Login.tsx` — add MFA challenge step
|
|
||||||
- `frontend/src/contexts/AuthContext.tsx` — handle AAL levels
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Add MFA enrollment UI (QR code, verification) to profile/settings
|
|
||||||
- [x] Display backup secret code after enrollment (Supabase TOTP doesn't provide recovery codes)
|
|
||||||
- [x] Add TOTP challenge step to login flow
|
|
||||||
- [x] Check AAL after login and redirect to TOTP if needed
|
|
||||||
- [x] Add "Disable MFA" with re-verification
|
|
||||||
- [x] Only show MFA options for email/password users
|
|
||||||
- [ ] Test: full enrollment → login → TOTP flow
|
|
||||||
- [N/A] Test: recovery code works when TOTP unavailable (Supabase doesn't provide recovery codes; users save their secret key instead)
|
|
||||||
@@ -1,54 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-i0rn
|
|
||||||
title: Infer genlocke visibility from first leg's run
|
|
||||||
status: completed
|
|
||||||
type: feature
|
|
||||||
created_at: 2026-03-21T12:46:56Z
|
|
||||||
updated_at: 2026-03-21T12:46:56Z
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
Genlockes are always public — they have no visibility setting. They should inherit visibility from their first leg's run, so if a user makes their run private, the genlocke is also hidden from public listings.
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
Rather than adding a `visibility` column to the `genlockes` table, infer it from the first leg's run at query time. This avoids sync issues and keeps the first leg's run as the source of truth.
|
|
||||||
|
|
||||||
### Backend
|
|
||||||
- `list_genlockes` endpoint: filter out genlockes whose first leg's run is private (unless the requesting user is the owner)
|
|
||||||
- `get_genlocke` endpoint: return 404 if the first leg's run is private and the user is not the owner
|
|
||||||
- Add optional auth (not required) to genlocke read endpoints to check ownership
|
|
||||||
|
|
||||||
### Frontend
|
|
||||||
- No changes needed — private genlockes simply won't appear in listings for non-owners
|
|
||||||
|
|
||||||
## Files modified
|
|
||||||
|
|
||||||
- `backend/src/app/api/genlockes.py` — add visibility filtering to all read endpoints
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Add `get_current_user` (optional auth) dependency to genlocke read endpoints
|
|
||||||
- [x] Filter private genlockes from `list_genlockes` for non-owners
|
|
||||||
- [x] Return 404 for private genlockes in `get_genlocke` for non-owners
|
|
||||||
- [x] Apply same filtering to graveyard, lineages, survivors, and retired-families endpoints
|
|
||||||
- [x] Test: private run's genlocke hidden from unauthenticated users
|
|
||||||
- [x] Test: owner can still see their private genlocke
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
- Added `_is_genlocke_visible()` helper function to check visibility based on first leg's run
|
|
||||||
- Added optional auth (`get_current_user`) to all genlocke read endpoints:
|
|
||||||
- `list_genlockes`: filters out private genlockes for non-owners
|
|
||||||
- `get_genlocke`: returns 404 for private genlockes to non-owners
|
|
||||||
- `get_genlocke_graveyard`: returns 404 for private genlockes
|
|
||||||
- `get_genlocke_lineages`: returns 404 for private genlockes
|
|
||||||
- `get_leg_survivors`: returns 404 for private genlockes
|
|
||||||
- `get_retired_families`: returns 404 for private genlockes
|
|
||||||
- Added 9 new tests in `TestGenlockeVisibility` class covering:
|
|
||||||
- Private genlockes hidden from unauthenticated list
|
|
||||||
- Private genlockes visible to owner in list
|
|
||||||
- 404 for all detail endpoints when accessed by unauthenticated users
|
|
||||||
- 404 for private genlockes when accessed by different authenticated user
|
|
||||||
- Owner can still access their private genlocke
|
|
||||||
@@ -1,41 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-i2va
|
|
||||||
title: Hide edit controls for non-owners in frontend
|
|
||||||
status: in-progress
|
|
||||||
type: bug
|
|
||||||
priority: critical
|
|
||||||
created_at: 2026-03-21T12:18:38Z
|
|
||||||
updated_at: 2026-03-21T12:32:45Z
|
|
||||||
parent: nuzlocke-tracker-wwnu
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-73ba
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
`RunEncounters.tsx` has NO auth checks — all edit buttons (encounter modals, boss defeat, status changes, end run, shiny encounters, egg encounters, transfers, HoF team) are always visible, even to logged-out users viewing a public run.
|
|
||||||
|
|
||||||
`RunDashboard.tsx` has `canEdit = isOwner || !run?.owner` (line 70) which means unowned legacy runs are editable by anyone, including logged-out users.
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
1. Add `useAuth` and `canEdit` logic to `RunEncounters.tsx`, matching the pattern from `RunDashboard.tsx` but stricter: `canEdit = isOwner` (no fallback for unowned runs)
|
|
||||||
2. Update `RunDashboard.tsx` line 70 to `canEdit = isOwner` (remove `|| !run?.owner`)
|
|
||||||
3. Conditionally render all mutation UI elements based on `canEdit`:
|
|
||||||
- Encounter create/edit modals and triggers
|
|
||||||
- Boss defeat buttons
|
|
||||||
- Status change / End run buttons
|
|
||||||
- Shiny encounter / Egg encounter modals
|
|
||||||
- Transfer modal
|
|
||||||
- HoF team modal
|
|
||||||
- Visibility settings toggle
|
|
||||||
4. Show a read-only banner when viewing someone else's run
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [x] Add `useAuth` import and `canEdit` logic to `RunEncounters.tsx`
|
|
||||||
- [x] Guard all mutation triggers in `RunEncounters.tsx` behind `canEdit`
|
|
||||||
- [x] Update `RunDashboard.tsx` `canEdit` to be `isOwner` only (no unowned fallback)
|
|
||||||
- [x] Guard all mutation triggers in `RunDashboard.tsx` behind `canEdit`
|
|
||||||
- [x] Add read-only indicator/banner for non-owner viewers
|
|
||||||
- [x] Verify logged-out users see no edit controls on public runs
|
|
||||||
@@ -1,36 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-lkro
|
|
||||||
title: 'UX: Make team section a floating sidebar on desktop'
|
|
||||||
status: todo
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T21:50:48Z
|
|
||||||
updated_at: 2026-03-22T08:08:13Z
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
During a run, the team section is rendered inline at the top of the encounters page. When scrolling through routes and bosses, the team disappears and users must scroll back up to evolve pokemon or check their team. This creates constant friction during gameplay.
|
|
||||||
|
|
||||||
## Current Implementation
|
|
||||||
|
|
||||||
- Team section rendered in `RunEncounters.tsx:1214-1288`
|
|
||||||
- Inline in the page flow, above the encounters list
|
|
||||||
- No sticky/floating behavior
|
|
||||||
|
|
||||||
## Proposed Solution
|
|
||||||
|
|
||||||
Make the team section a sticky sidebar on desktop viewports (2-column layout):
|
|
||||||
- **Desktop (lg breakpoint, ≥1024px — Tailwind v4 default):** Encounters on the left, team pinned in a right sidebar that scrolls with the page
|
|
||||||
- **Mobile:** Keep current stacked layout (team above encounters)
|
|
||||||
|
|
||||||
Alternative: A floating action button (FAB) that opens the team in a slide-over panel.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [ ] Add responsive 2-column layout to RunEncounters page (desktop only)
|
|
||||||
- [ ] Move team section into a sticky sidebar column
|
|
||||||
- [ ] Ensure sidebar scrolls independently if team is taller than viewport
|
|
||||||
- [ ] Keep current stacked layout on mobile/tablet
|
|
||||||
- [ ] Test with various team sizes (0-6 pokemon)
|
|
||||||
- [ ] Test evolution/nickname editing still works from sidebar
|
|
||||||
@@ -1,36 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-mmre
|
|
||||||
title: Admin global search bar
|
|
||||||
status: draft
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T21:59:20Z
|
|
||||||
updated_at: 2026-03-21T22:04:08Z
|
|
||||||
parent: nuzlocke-tracker-9i9m
|
|
||||||
---
|
|
||||||
|
|
||||||
Add a search bar to the admin layout header that searches across all admin entities (games, routes, encounters, pokemon, evolutions, runs) and lets you jump directly to the relevant page.
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
- Add a search input to `AdminLayout.tsx` above the nav
|
|
||||||
- Use a debounced search that queries multiple endpoints (or a single backend search endpoint)
|
|
||||||
- Show results in a dropdown grouped by entity type (Games, Routes, Encounters, Pokemon, Runs)
|
|
||||||
- Each result links directly to the relevant admin page (e.g., clicking a route goes to `/admin/games/:gameId/routes/:routeId`)
|
|
||||||
- Keyboard shortcut (Cmd/Ctrl+K) to focus the search bar
|
|
||||||
|
|
||||||
## Files to modify
|
|
||||||
|
|
||||||
- `frontend/src/components/admin/AdminLayout.tsx` — Add search bar UI
|
|
||||||
- `frontend/src/components/admin/AdminSearchBar.tsx` — New component
|
|
||||||
- `frontend/src/hooks/useAdminSearch.ts` — New hook for search logic
|
|
||||||
- `backend/src/app/api/search.py` — New unified search endpoint (required — client-side search across 5+ entity types is too slow)
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [ ] Search bar component with debounced input
|
|
||||||
- [ ] Search across games, routes, encounters, pokemon, runs
|
|
||||||
- [ ] Results dropdown grouped by entity type
|
|
||||||
- [ ] Click result navigates to correct admin page
|
|
||||||
- [ ] Keyboard shortcut (Cmd/Ctrl+K) to focus
|
|
||||||
- [ ] Empty state and loading state
|
|
||||||
@@ -1,11 +1,10 @@
|
|||||||
---
|
---
|
||||||
# nuzlocke-tracker-mz16
|
# nuzlocke-tracker-mz16
|
||||||
title: Session Journal / Blog Posts
|
title: Session Journal / Blog Posts
|
||||||
status: completed
|
status: draft
|
||||||
type: epic
|
type: epic
|
||||||
priority: normal
|
|
||||||
created_at: 2026-02-19T07:43:05Z
|
created_at: 2026-02-19T07:43:05Z
|
||||||
updated_at: 2026-03-20T15:37:21Z
|
updated_at: 2026-02-19T07:43:05Z
|
||||||
---
|
---
|
||||||
|
|
||||||
Let users tell the story of their nuzlocke run through session journal entries (blog posts).
|
Let users tell the story of their nuzlocke run through session journal entries (blog posts).
|
||||||
@@ -24,15 +23,10 @@ For each play session, users can write a short post to document what happened. P
|
|||||||
|
|
||||||
The journal becomes a chronological narrative of the nuzlocke run, with game data woven in automatically.
|
The journal becomes a chronological narrative of the nuzlocke run, with game data woven in automatically.
|
||||||
|
|
||||||
## Decisions
|
## Open Questions
|
||||||
|
|
||||||
- **Editor:** Plain markdown textarea with preview
|
- [ ] What editor experience? (Markdown, rich text, block editor?)
|
||||||
- **Images:** Via markdown URL syntax (no uploads)
|
- [ ] How are images stored? (Local uploads, external links, cloud storage?)
|
||||||
- **Run linkage:** Entries belong to a run, optionally linked to a boss battle
|
- [ ] What run events can be linked/embedded? (Team snapshots, deaths, catches, badge progress?)
|
||||||
- **Visibility:** Private only (no sharing — deferred until user accounts exist)
|
- [ ] Should posts be publishable/shareable, or private by default?
|
||||||
- **Templates:** Blank slate — no templates
|
- [ ] How does the journal UI look? Timeline view? Blog-style list?
|
||||||
|
|
||||||
## Success Criteria
|
|
||||||
|
|
||||||
- [x] Backend: journal entries CRUD API is complete (`nuzlocke-tracker-vmto`)
|
|
||||||
- [x] Frontend: journal list, editor, and view are functional (`nuzlocke-tracker-d68l`)
|
|
||||||
@@ -0,0 +1,27 @@
|
|||||||
|
---
|
||||||
|
# nuzlocke-tracker-neqv
|
||||||
|
title: Add detailed boss battle information
|
||||||
|
status: todo
|
||||||
|
type: feature
|
||||||
|
priority: low
|
||||||
|
created_at: 2026-02-08T11:21:22Z
|
||||||
|
updated_at: 2026-02-10T12:05:43Z
|
||||||
|
---
|
||||||
|
|
||||||
|
Enhance boss battles with more detailed information for each boss pokemon and the player's team.
|
||||||
|
|
||||||
|
## Boss Pokemon Details
|
||||||
|
Add the following optional fields to boss pokemon entries:
|
||||||
|
- **Ability** – the pokemon's ability
|
||||||
|
- **Held item** – item the pokemon is holding
|
||||||
|
- **Nature** – the pokemon's nature
|
||||||
|
- **Moveset** – up to 4 moves per pokemon
|
||||||
|
|
||||||
|
This requires backend model/schema changes (BossPokemon fields), migration, admin UI for editing, and display in the run encounter boss cards.
|
||||||
|
|
||||||
|
## Team Snapshot
|
||||||
|
When recording a boss battle result, allow the player to snapshot which of their alive team pokemon they used and at what levels. This gives a record of "what I brought to the fight."
|
||||||
|
|
||||||
|
- Add a `boss_result_team` join table (boss_result_id, encounter_id, level)
|
||||||
|
- In the BossDefeatModal, show checkboxes for alive team members with optional level override
|
||||||
|
- Display the team snapshot when viewing past boss results
|
||||||
@@ -1,19 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-oar4
|
|
||||||
title: Ko-fi Integration
|
|
||||||
status: draft
|
|
||||||
type: feature
|
|
||||||
priority: deferred
|
|
||||||
created_at: 2026-03-20T15:38:23Z
|
|
||||||
updated_at: 2026-03-20T15:38:23Z
|
|
||||||
---
|
|
||||||
|
|
||||||
Add Ko-fi integration to allow visitors to contribute toward hosting costs. This is not about monetization — it's a way for users who enjoy the tool to optionally help cover server/infrastructure expenses.
|
|
||||||
|
|
||||||
## Open Questions
|
|
||||||
|
|
||||||
- [ ] Where should the Ko-fi link/button live? (footer, about page, dedicated page, or subtle banner?)
|
|
||||||
- [ ] Should it be a simple outbound link to a Ko-fi page, or use Ko-fi's embeddable widget/overlay?
|
|
||||||
- [ ] Should there be any acknowledgment for supporters (e.g., a thank-you page, supporter list)?
|
|
||||||
- [ ] Should this be gated behind user auth (only shown to logged-in users) or visible to everyone?
|
|
||||||
- [ ] Any legal/tax considerations to document?
|
|
||||||
@@ -1,29 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-ququ
|
|
||||||
title: Enrich moves and abilities with generation-specific stats
|
|
||||||
status: draft
|
|
||||||
type: feature
|
|
||||||
priority: deferred
|
|
||||||
created_at: 2026-03-20T15:11:59Z
|
|
||||||
updated_at: 2026-03-20T15:12:33Z
|
|
||||||
blocked_by:
|
|
||||||
- nuzlocke-tracker-vc5o
|
|
||||||
---
|
|
||||||
|
|
||||||
Follow-up to the hybrid moves/abilities seeding. Add full generation-specific data to enable rich display.
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
Add a `move_gen_details` table (or similar) with per-generation stats: power, accuracy, PP, type, category, effect text. Same pattern for `ability_gen_details`. Seed from PokeAPI data.
|
|
||||||
|
|
||||||
This is additive — the base `moves`/`abilities` tables already exist with names and introduced_gen.
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
- [ ] Design schema for generation-specific move data (power, accuracy, PP, type, category, effect)
|
|
||||||
- [ ] Design schema for generation-specific ability data (description, effect)
|
|
||||||
- [ ] Create migrations
|
|
||||||
- [ ] Seed from PokeAPI or equivalent data source
|
|
||||||
- [ ] Update boss pokemon display to show enriched move/ability info when available
|
|
||||||
|
|
||||||
## Open Questions
|
|
||||||
- Should we pull directly from PokeAPI at seed time, or maintain our own data files?
|
|
||||||
- How to handle edge cases (e.g., moves that exist in romhacks but not official games)?
|
|
||||||
@@ -1,50 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-ru96
|
|
||||||
title: Admin run slide-over panel with metadata editing
|
|
||||||
status: draft
|
|
||||||
type: feature
|
|
||||||
priority: normal
|
|
||||||
created_at: 2026-03-21T21:59:20Z
|
|
||||||
updated_at: 2026-03-21T22:04:08Z
|
|
||||||
parent: nuzlocke-tracker-9i9m
|
|
||||||
---
|
|
||||||
|
|
||||||
Replace the current click-to-delete behavior on the runs page with a slide-over panel that shows run details and allows editing metadata.
|
|
||||||
|
|
||||||
## Current problem
|
|
||||||
|
|
||||||
Clicking any run row in AdminRuns immediately opens a delete confirmation modal. There is no way to view or edit run metadata (name, status, owner, visibility).
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
- Replace `onRowClick` from opening delete modal to opening a slide-over panel
|
|
||||||
- Panel slides in from the right over the runs list
|
|
||||||
- Panel shows all run metadata with inline editing:
|
|
||||||
- Name (text input)
|
|
||||||
- Status (dropdown: active/completed/failed — matches `RunStatus` type)
|
|
||||||
- Owner (user search/select — requires new admin endpoint)
|
|
||||||
- Visibility (dropdown: public/private/unlisted)
|
|
||||||
- Rules, Naming Scheme (if applicable)
|
|
||||||
- Started At, Completed At (read-only)
|
|
||||||
- Save button to persist changes
|
|
||||||
- Delete button at bottom of panel (with confirmation)
|
|
||||||
- New admin-only backend endpoint: PUT /admin/runs/:id for owner reassignment and other admin-only fields\n- New admin-only endpoint: GET /admin/users for user search/select (currently no list-users endpoint exists — only /users/me)
|
|
||||||
|
|
||||||
## Files to modify
|
|
||||||
|
|
||||||
- `frontend/src/pages/admin/AdminRuns.tsx` — Replace delete-on-click with slide-over
|
|
||||||
- `frontend/src/components/admin/RunSlideOver.tsx` — New slide-over component
|
|
||||||
- `frontend/src/hooks/useRuns.ts` — Add admin update mutation
|
|
||||||
- `backend/app/routes/admin.py` — Add admin run update endpoint
|
|
||||||
- `backend/app/schemas/run.py` — Add admin-specific update schema (with owner_id)
|
|
||||||
|
|
||||||
## Checklist
|
|
||||||
|
|
||||||
- [ ] SlideOver component (reusable, slides from right)
|
|
||||||
- [ ] RunSlideOver with editable fields
|
|
||||||
- [ ] AdminRuns opens slide-over on row click (not delete modal)
|
|
||||||
- [ ] Save functionality with optimistic updates
|
|
||||||
- [ ] Delete button inside slide-over with confirmation
|
|
||||||
- [ ] Admin backend endpoint for run updates (including owner reassignment)
|
|
||||||
- [ ] Admin run update schema with owner_id field
|
|
||||||
- [ ] User search/select for owner reassignment
|
|
||||||
@@ -1,26 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-t9aj
|
|
||||||
title: Migrate JWT verification from HS256 shared secret to asymmetric keys (JWKS)
|
|
||||||
status: completed
|
|
||||||
type: task
|
|
||||||
priority: low
|
|
||||||
created_at: 2026-03-21T11:14:29Z
|
|
||||||
updated_at: 2026-03-21T13:01:33Z
|
|
||||||
---
|
|
||||||
|
|
||||||
The backend currently verifies Supabase JWTs using an HS256 shared secret (`SUPABASE_JWT_SECRET`). Supabase recommends migrating to asymmetric keys (RS256) for better security.\n\nInstead of storing a shared secret, the backend would fetch public keys from Supabase's JWKS endpoint (`https://<project>.supabase.co/.well-known/jwks.json`) and verify tokens against those.\n\n## Changes needed\n\n- [x] Update `backend/src/app/core/auth.py` to fetch and cache JWKS public keys\n- [x] Change `jwt.decode` from `HS256` to `RS256` with the fetched public key\n- [x] Remove `SUPABASE_JWT_SECRET` from config, docker-compose, deploy workflow, and .env files\n- [x] Update tests\n\n## References\n\n- https://supabase.com/docs/guides/auth/signing-keys\n- https://supabase.com/docs/guides/auth/jwts
|
|
||||||
|
|
||||||
|
|
||||||
## Summary of Changes
|
|
||||||
|
|
||||||
- Added `cryptography==45.0.3` dependency for RS256 support
|
|
||||||
- Updated `auth.py` to use `PyJWKClient` for fetching and caching JWKS public keys from `{SUPABASE_URL}/.well-known/jwks.json`
|
|
||||||
- Changed JWT verification from HS256 to RS256
|
|
||||||
- Removed `supabase_jwt_secret` from config.py
|
|
||||||
- Updated docker-compose.yml: removed `SUPABASE_JWT_SECRET`, backend now uses JWKS from GoTrue URL
|
|
||||||
- Updated docker-compose.prod.yml: replaced `SUPABASE_JWT_SECRET` with `SUPABASE_URL`
|
|
||||||
- Updated deploy.yml: deploy workflow now writes `SUPABASE_URL` instead of `SUPABASE_JWT_SECRET`
|
|
||||||
- Updated .env.example files: removed `SUPABASE_JWT_SECRET` references
|
|
||||||
- Rewrote tests to use RS256 tokens with mocked JWKS client
|
|
||||||
|
|
||||||
**Note:** For production, add `SUPABASE_URL` to your GitHub secrets (should point to your Supabase project URL like `https://your-project.supabase.co`).
|
|
||||||
@@ -1,33 +0,0 @@
|
|||||||
---
|
|
||||||
# nuzlocke-tracker-tatg
|
|
||||||
title: 'Bug: Intermittent 401 errors / failed save-load requiring page reload'
|
|
||||||
status: todo
|
|
||||||
type: bug
|
|
||||||
priority: high
|
|
||||||
created_at: 2026-03-21T21:50:48Z
|
|
||||||
updated_at: 2026-03-21T21:50:48Z
|
|
||||||
---
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
During gameplay, the app intermittently fails to load or save data. A page reload fixes the issue. Likely caused by expired Supabase JWT tokens not being refreshed automatically before API calls.
|
|
||||||
|
|
||||||
## Current Implementation
|
|
||||||
|
|
||||||
- Auth uses Supabase JWTs verified with HS256 (`backend/auth.py:39-44`)
|
|
||||||
- Frontend gets token via `supabase.auth.getSession()` in `client.ts:16-21`
|
|
||||||
- `getAuthHeaders()` returns the cached session token without checking expiry
|
|
||||||
- When the token expires between interactions, API calls return 401
|
|
||||||
- Page reload triggers a fresh `getSession()` which refreshes the token
|
|
||||||
|
|
||||||
## Root Cause Analysis
|
|
||||||
|
|
||||||
`getSession()` returns the cached token. If it's expired, the frontend sends an expired JWT to the backend, which rejects it with 401. The frontend doesn't call `refreshSession()` or handle token refresh before API calls.
|
|
||||||
|
|
||||||
## Proposed Fix
|
|
||||||
|
|
||||||
- [ ] Add token refresh logic before API calls (check expiry, call `refreshSession()` if needed)
|
|
||||||
- [ ] Add 401 response interceptor that automatically refreshes token and retries the request
|
|
||||||
- [ ] Verify Supabase client `autoRefreshToken` option is enabled
|
|
||||||
- [ ] Test with short-lived tokens to confirm refresh works
|
|
||||||
- [ ] Check if there's a race condition when multiple API calls trigger refresh simultaneously
|
|
||||||
@@ -1,26 +0,0 @@
|
|||||||
#!/usr/bin/env bash
|
|
||||||
set -euo pipefail
|
|
||||||
|
|
||||||
# PreToolUse hook for Bash tool: blocks git commit/push on protected branches.
|
|
||||||
# TOOL_INPUT is JSON with a "command" field containing the bash command.
|
|
||||||
|
|
||||||
PROTECTED_BRANCHES=("develop" "main" "master")
|
|
||||||
|
|
||||||
COMMAND="${TOOL_INPUT:-}"
|
|
||||||
|
|
||||||
# Only check commands that look like git commit or git push
|
|
||||||
if ! echo "$COMMAND" | grep -qE '\bgit\b.*(commit|push)'; then
|
|
||||||
exit 0
|
|
||||||
fi
|
|
||||||
|
|
||||||
BRANCH="$(git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "")"
|
|
||||||
|
|
||||||
for protected in "${PROTECTED_BRANCHES[@]}"; do
|
|
||||||
if [[ "$BRANCH" == "$protected" ]]; then
|
|
||||||
echo "BLOCKED: Cannot commit or push on protected branch '$BRANCH'."
|
|
||||||
echo "Create a feature branch first: git checkout -b feature/<name>"
|
|
||||||
exit 2
|
|
||||||
fi
|
|
||||||
done
|
|
||||||
|
|
||||||
exit 0
|
|
||||||
@@ -5,18 +5,6 @@
|
|||||||
],
|
],
|
||||||
"PreCompact": [
|
"PreCompact": [
|
||||||
{ "hooks": [{ "type": "command", "command": "beans prime" }] }
|
{ "hooks": [{ "type": "command", "command": "beans prime" }] }
|
||||||
],
|
|
||||||
"PreToolUse": [
|
|
||||||
{
|
|
||||||
"matcher": "Bash",
|
|
||||||
"hooks": [
|
|
||||||
{
|
|
||||||
"type": "command",
|
|
||||||
"command": ".claude/guard-branch.sh",
|
|
||||||
"statusMessage": "Checking branch protection..."
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
16
.env.example
16
.env.example
@@ -2,21 +2,5 @@
|
|||||||
DEBUG=true
|
DEBUG=true
|
||||||
DATABASE_URL=postgresql://postgres:postgres@localhost:5432/nuzlocke
|
DATABASE_URL=postgresql://postgres:postgres@localhost:5432/nuzlocke
|
||||||
|
|
||||||
# Supabase Auth (backend uses JWKS from this URL for JWT verification)
|
|
||||||
# For local dev with GoTrue container:
|
|
||||||
SUPABASE_URL=http://localhost:9999
|
|
||||||
# HS256 fallback for local GoTrue (not needed for Supabase Cloud):
|
|
||||||
SUPABASE_JWT_SECRET=super-secret-jwt-token-with-at-least-32-characters-long
|
|
||||||
SUPABASE_ANON_KEY=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJyb2xlIjoiYW5vbiIsImlzcyI6InN1cGFiYXNlIiwiaWF0IjoxNzc0MDQwNjEzLCJleHAiOjIwODk0MDA2MTN9.EV6tRj7gLqoiT-l2vDFw_67myqRjwpcZTuRb3Xs1nr4
|
|
||||||
# For production, replace with your Supabase cloud values:
|
|
||||||
# SUPABASE_URL=https://your-project.supabase.co
|
|
||||||
# SUPABASE_ANON_KEY=your-anon-key
|
|
||||||
|
|
||||||
# Frontend settings (used by Vite)
|
# Frontend settings (used by Vite)
|
||||||
VITE_API_URL=http://localhost:8000
|
VITE_API_URL=http://localhost:8000
|
||||||
# For local dev with GoTrue container:
|
|
||||||
VITE_SUPABASE_URL=http://localhost:9999
|
|
||||||
VITE_SUPABASE_ANON_KEY=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJyb2xlIjoiYW5vbiIsImlzcyI6InN1cGFiYXNlIiwiaWF0IjoxNzc0MDQwNjEzLCJleHAiOjIwODk0MDA2MTN9.EV6tRj7gLqoiT-l2vDFw_67myqRjwpcZTuRb3Xs1nr4
|
|
||||||
# For production, replace with your Supabase cloud values:
|
|
||||||
# VITE_SUPABASE_URL=https://your-project.supabase.co
|
|
||||||
# VITE_SUPABASE_ANON_KEY=your-anon-key
|
|
||||||
|
|||||||
37
.github/workflows/ci.yml
vendored
37
.github/workflows/ci.yml
vendored
@@ -26,7 +26,7 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
services:
|
services:
|
||||||
postgres:
|
postgres:
|
||||||
image: postgres:18-alpine
|
image: postgres:16-alpine
|
||||||
ports:
|
ports:
|
||||||
- 5433:5432
|
- 5433:5432
|
||||||
env:
|
env:
|
||||||
@@ -39,7 +39,7 @@ jobs:
|
|||||||
--health-timeout 5s
|
--health-timeout 5s
|
||||||
--health-retries 5
|
--health-retries 5
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
|
||||||
with:
|
with:
|
||||||
persist-credentials: false
|
persist-credentials: false
|
||||||
- name: Install uv and Python
|
- name: Install uv and Python
|
||||||
@@ -57,10 +57,10 @@ jobs:
|
|||||||
frontend-tests:
|
frontend-tests:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
|
||||||
with:
|
with:
|
||||||
persist-credentials: false
|
persist-credentials: false
|
||||||
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
|
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
|
||||||
with:
|
with:
|
||||||
node-version: "24"
|
node-version: "24"
|
||||||
- name: Install dependencies
|
- name: Install dependencies
|
||||||
@@ -68,4 +68,31 @@ jobs:
|
|||||||
working-directory: frontend
|
working-directory: frontend
|
||||||
- name: Run tests
|
- name: Run tests
|
||||||
run: npm test
|
run: npm test
|
||||||
working-directory: frontend
|
working-directory: frontend
|
||||||
|
|
||||||
|
e2e-tests:
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
|
||||||
|
with:
|
||||||
|
persist-credentials: false
|
||||||
|
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
|
||||||
|
with:
|
||||||
|
node-version: "24"
|
||||||
|
- name: Install dependencies
|
||||||
|
run: npm ci
|
||||||
|
working-directory: frontend
|
||||||
|
- name: Install Playwright browsers
|
||||||
|
run: npx playwright install --with-deps chromium
|
||||||
|
working-directory: frontend
|
||||||
|
- name: Run e2e tests
|
||||||
|
run: npm run test:e2e
|
||||||
|
working-directory: frontend
|
||||||
|
env:
|
||||||
|
E2E_API_URL: http://192.168.1.10:8100
|
||||||
|
- name: Upload Playwright report
|
||||||
|
if: failure()
|
||||||
|
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
|
||||||
|
with:
|
||||||
|
name: playwright-report
|
||||||
|
path: frontend/playwright-report/
|
||||||
|
|||||||
11
.github/workflows/deploy.yml
vendored
11
.github/workflows/deploy.yml
vendored
@@ -11,7 +11,7 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
if: github.ref == 'refs/heads/main'
|
if: github.ref == 'refs/heads/main'
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
|
||||||
with:
|
with:
|
||||||
persist-credentials: false
|
persist-credentials: false
|
||||||
|
|
||||||
@@ -28,9 +28,6 @@ jobs:
|
|||||||
- name: Build and push frontend image
|
- name: Build and push frontend image
|
||||||
run: |
|
run: |
|
||||||
docker build --platform linux/amd64 \
|
docker build --platform linux/amd64 \
|
||||||
--build-arg VITE_API_URL=${{ secrets.VITE_API_URL }} \
|
|
||||||
--build-arg VITE_SUPABASE_URL=${{ secrets.VITE_SUPABASE_URL }} \
|
|
||||||
--build-arg VITE_SUPABASE_ANON_KEY=${{ secrets.VITE_SUPABASE_ANON_KEY }} \
|
|
||||||
-t gitea.nerdboden.de/thefurya/nuzlocke-tracker-frontend:latest \
|
-t gitea.nerdboden.de/thefurya/nuzlocke-tracker-frontend:latest \
|
||||||
-f frontend/Dockerfile.prod ./frontend
|
-f frontend/Dockerfile.prod ./frontend
|
||||||
docker push gitea.nerdboden.de/thefurya/nuzlocke-tracker-frontend:latest
|
docker push gitea.nerdboden.de/thefurya/nuzlocke-tracker-frontend:latest
|
||||||
@@ -44,12 +41,6 @@ jobs:
|
|||||||
SCP_CMD="scp -o StrictHostKeyChecking=no -i ~/.ssh/deploy_key"
|
SCP_CMD="scp -o StrictHostKeyChecking=no -i ~/.ssh/deploy_key"
|
||||||
DEPLOY_DIR="/mnt/user/appdata/nuzlocke-tracker"
|
DEPLOY_DIR="/mnt/user/appdata/nuzlocke-tracker"
|
||||||
|
|
||||||
# Write .env from secrets (overwrites any existing file)
|
|
||||||
printf '%s\n' \
|
|
||||||
"POSTGRES_PASSWORD=${{ secrets.POSTGRES_PASSWORD }}" \
|
|
||||||
"SUPABASE_URL=${{ secrets.SUPABASE_URL }}" \
|
|
||||||
| $SSH_CMD "cat > '${DEPLOY_DIR}/.env'"
|
|
||||||
|
|
||||||
$SCP_CMD docker-compose.prod.yml "root@192.168.1.10:${DEPLOY_DIR}/docker-compose.yml"
|
$SCP_CMD docker-compose.prod.yml "root@192.168.1.10:${DEPLOY_DIR}/docker-compose.yml"
|
||||||
$SCP_CMD backup.sh "root@192.168.1.10:${DEPLOY_DIR}/backup.sh"
|
$SCP_CMD backup.sh "root@192.168.1.10:${DEPLOY_DIR}/backup.sh"
|
||||||
$SSH_CMD "chmod +x '${DEPLOY_DIR}/backup.sh'"
|
$SSH_CMD "chmod +x '${DEPLOY_DIR}/backup.sh'"
|
||||||
|
|||||||
35
.github/workflows/e2e.yml
vendored
35
.github/workflows/e2e.yml
vendored
@@ -1,35 +0,0 @@
|
|||||||
name: E2E Tests
|
|
||||||
|
|
||||||
on:
|
|
||||||
workflow_dispatch:
|
|
||||||
|
|
||||||
permissions:
|
|
||||||
contents: read
|
|
||||||
|
|
||||||
jobs:
|
|
||||||
e2e-tests:
|
|
||||||
runs-on: ubuntu-latest
|
|
||||||
steps:
|
|
||||||
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
||||||
with:
|
|
||||||
persist-credentials: false
|
|
||||||
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
|
|
||||||
with:
|
|
||||||
node-version: "24"
|
|
||||||
- name: Install dependencies
|
|
||||||
run: npm ci
|
|
||||||
working-directory: frontend
|
|
||||||
- name: Install Playwright browsers
|
|
||||||
run: npx playwright install --with-deps chromium
|
|
||||||
working-directory: frontend
|
|
||||||
- name: Run e2e tests
|
|
||||||
run: npm run test:e2e
|
|
||||||
working-directory: frontend
|
|
||||||
env:
|
|
||||||
E2E_API_URL: http://192.168.1.10:8100
|
|
||||||
- name: Upload Playwright report
|
|
||||||
if: failure()
|
|
||||||
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
|
|
||||||
with:
|
|
||||||
name: playwright-report
|
|
||||||
path: frontend/playwright-report/
|
|
||||||
3
.gitignore
vendored
3
.gitignore
vendored
@@ -38,9 +38,6 @@ Thumbs.db
|
|||||||
ehthumbs.db
|
ehthumbs.db
|
||||||
Desktop.ini
|
Desktop.ini
|
||||||
|
|
||||||
# Talos chat history
|
|
||||||
.talos/
|
|
||||||
|
|
||||||
# Editor/IDE
|
# Editor/IDE
|
||||||
.idea/
|
.idea/
|
||||||
.vscode/
|
.vscode/
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
nodejs 24.14.0
|
nodejs 24.13.0
|
||||||
python 3.14.3
|
python 3.14.3
|
||||||
golang 1.26.1
|
golang 1.25.7
|
||||||
|
|||||||
19
CLAUDE.md
19
CLAUDE.md
@@ -1,15 +1,12 @@
|
|||||||
# Branching Strategy
|
# Branching Strategy
|
||||||
|
|
||||||
- **NEVER commit or push directly to `develop` or `main`.** These branches are protected. All work happens on `feature/*` branches.
|
- **Never commit directly to `main`.** `main` is always production-ready.
|
||||||
- **Every epic** gets its own feature branch: `feature/<epic-title-slug>` off `develop`
|
- Day-to-day work happens on `develop`.
|
||||||
- **Every standalone task/bug** (no parent epic) gets its own feature branch: `feature/<task-title-slug>` off `develop`
|
- New work is done on `feature/*` branches off `develop`.
|
||||||
- Branch naming: kebab-case slug of the bean title (e.g., `feature/add-auth-system`)
|
- Merge flow: `feature/*` → `develop` → `main`.
|
||||||
|
- **Squash merge** `feature/*` into `develop` (one clean commit per feature).
|
||||||
## Committing workflow
|
- **Merge commit** `develop` into `main` (marks deploy points).
|
||||||
|
- Always `git pull` the target branch before merging into it.
|
||||||
- **Every completed task gets its own commit** on the feature branch — including tasks within an epic. One task = one commit.
|
|
||||||
- After finishing a task, **immediately commit** the changes to the feature branch. Do not batch multiple tasks into a single commit.
|
|
||||||
- When the epic or standalone task is fully complete, squash merge the feature branch into `develop` (via PR).
|
|
||||||
|
|
||||||
# Pre-commit Hooks
|
# Pre-commit Hooks
|
||||||
|
|
||||||
@@ -25,7 +22,7 @@ Frontend hooks require `npm ci` in `frontend/` first (they use `npx` to run from
|
|||||||
|
|
||||||
# Instructions
|
# Instructions
|
||||||
|
|
||||||
- After completing a task, immediately commit the changes to the current feature branch and ask the user to confirm.
|
- After completing a task, always ask the user if they'd like to commit the changes.
|
||||||
- Before working on a bean, always set it to in-progress. After the changes related to the bean are committed, mark it as completed.
|
- Before working on a bean, always set it to in-progress. After the changes related to the bean are committed, mark it as completed.
|
||||||
- If a bean is marked as draft, refine it first before starting work on it.
|
- If a bean is marked as draft, refine it first before starting work on it.
|
||||||
- When completing a bean that has a parent (epic, feature, etc.), check the parent's checklist/success criteria for items that can now be marked as completed and update them.
|
- When completing a bean that has a parent (epic, feature, etc.), check the parent's checklist/success criteria for items that can now be marked as completed and update them.
|
||||||
|
|||||||
24
README.md
24
README.md
@@ -14,29 +14,15 @@ A full-stack Nuzlocke run tracker for Pokemon games.
|
|||||||
docker compose up
|
docker compose up
|
||||||
```
|
```
|
||||||
|
|
||||||
This starts four services:
|
This starts three services:
|
||||||
|
|
||||||
| Service | URL |
|
| Service | URL |
|
||||||
|------------|---------------------------|
|
|------------|--------------------------|
|
||||||
| Frontend | http://localhost:5173 |
|
| Frontend | http://localhost:5173 |
|
||||||
| API | http://localhost:8080 |
|
| API | http://localhost:8000 |
|
||||||
| API Docs | http://localhost:8080/docs|
|
| API Docs | http://localhost:8000/docs|
|
||||||
| GoTrue | http://localhost:9999 |
|
|
||||||
| PostgreSQL | localhost:5432 |
|
| PostgreSQL | localhost:5432 |
|
||||||
|
|
||||||
### Local Authentication
|
|
||||||
|
|
||||||
The stack includes a local GoTrue container for auth testing. Email/password signup and login work out of the box with auto-confirmation (no email verification needed).
|
|
||||||
|
|
||||||
**OAuth providers (Google, Discord) are disabled in local dev.** The login/signup pages show OAuth buttons as disabled with a tooltip explaining this. For OAuth testing, deploy to an environment with Supabase cloud configured.
|
|
||||||
|
|
||||||
The local JWT secret and anon key are pre-configured in `.env.example` and `docker-compose.yml`. Copy `.env.example` to `.env` before starting:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cp .env.example .env
|
|
||||||
docker compose up
|
|
||||||
```
|
|
||||||
|
|
||||||
### Run Migrations
|
### Run Migrations
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
|
|||||||
@@ -7,9 +7,3 @@ API_V1_PREFIX="/api/v1"
|
|||||||
|
|
||||||
# Database settings
|
# Database settings
|
||||||
DATABASE_URL="sqlite:///./nuzlocke.db"
|
DATABASE_URL="sqlite:///./nuzlocke.db"
|
||||||
|
|
||||||
# Supabase Auth (JWKS used for JWT verification)
|
|
||||||
SUPABASE_URL=https://your-project.supabase.co
|
|
||||||
SUPABASE_ANON_KEY=your-anon-key
|
|
||||||
# HS256 fallback for local GoTrue (not needed for Supabase Cloud):
|
|
||||||
# SUPABASE_JWT_SECRET=super-secret-jwt-token-with-at-least-32-characters-long
|
|
||||||
|
|||||||
@@ -1 +0,0 @@
|
|||||||
uv 0.10.12
|
|
||||||
@@ -5,22 +5,20 @@ description = "Backend API for Another Nuzlocke Tracker"
|
|||||||
readme = "README.md"
|
readme = "README.md"
|
||||||
requires-python = ">=3.14"
|
requires-python = ">=3.14"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"fastapi==0.135.1",
|
"fastapi==0.128.4",
|
||||||
"uvicorn[standard]==0.42.0",
|
"uvicorn[standard]==0.40.0",
|
||||||
"pydantic==2.12.5",
|
"pydantic==2.12.5",
|
||||||
"pydantic-settings==2.13.1",
|
"pydantic-settings==2.12.0",
|
||||||
"python-dotenv==1.2.2",
|
"python-dotenv==1.2.1",
|
||||||
"sqlalchemy[asyncio]==2.0.48",
|
"sqlalchemy[asyncio]==2.0.46",
|
||||||
"asyncpg==0.31.0",
|
"asyncpg==0.31.0",
|
||||||
"alembic==1.18.4",
|
"alembic==1.18.3",
|
||||||
"PyJWT==2.12.1",
|
|
||||||
"cryptography==45.0.7",
|
|
||||||
]
|
]
|
||||||
|
|
||||||
[project.optional-dependencies]
|
[project.optional-dependencies]
|
||||||
dev = [
|
dev = [
|
||||||
"ruff==0.15.7",
|
"ruff==0.15.0",
|
||||||
"ty==0.0.24",
|
"ty==0.0.17",
|
||||||
|
|
||||||
"pytest==9.0.2",
|
"pytest==9.0.2",
|
||||||
"pytest-asyncio==1.3.0",
|
"pytest-asyncio==1.3.0",
|
||||||
|
|||||||
@@ -1,81 +0,0 @@
|
|||||||
#!/usr/bin/env python3
|
|
||||||
"""Assign existing unowned runs to a user.
|
|
||||||
|
|
||||||
Usage:
|
|
||||||
cd backend && uv run python scripts/assign_unowned_runs.py <user_uuid>
|
|
||||||
|
|
||||||
This script assigns all runs without an owner to the specified user.
|
|
||||||
Useful for migrating existing data after implementing user ownership.
|
|
||||||
"""
|
|
||||||
|
|
||||||
import asyncio
|
|
||||||
import sys
|
|
||||||
from uuid import UUID
|
|
||||||
|
|
||||||
from sqlalchemy import select, update
|
|
||||||
|
|
||||||
sys.path.insert(0, "src")
|
|
||||||
|
|
||||||
from app.core.database import async_session # noqa: E402
|
|
||||||
from app.models.nuzlocke_run import NuzlockeRun # noqa: E402
|
|
||||||
from app.models.user import User # noqa: E402
|
|
||||||
|
|
||||||
|
|
||||||
async def main(user_uuid: str) -> None:
|
|
||||||
try:
|
|
||||||
user_id = UUID(user_uuid)
|
|
||||||
except ValueError:
|
|
||||||
print(f"Error: Invalid UUID format: {user_uuid}")
|
|
||||||
sys.exit(1)
|
|
||||||
|
|
||||||
async with async_session() as session:
|
|
||||||
# Verify user exists
|
|
||||||
user_result = await session.execute(select(User).where(User.id == user_id))
|
|
||||||
user = user_result.scalar_one_or_none()
|
|
||||||
if user is None:
|
|
||||||
print(f"Error: User {user_id} not found")
|
|
||||||
sys.exit(1)
|
|
||||||
|
|
||||||
print(f"Found user: {user.email} (display_name: {user.display_name})")
|
|
||||||
|
|
||||||
# Count unowned runs
|
|
||||||
count_result = await session.execute(
|
|
||||||
select(NuzlockeRun.id, NuzlockeRun.name).where(
|
|
||||||
NuzlockeRun.owner_id.is_(None)
|
|
||||||
)
|
|
||||||
)
|
|
||||||
unowned_runs = count_result.all()
|
|
||||||
|
|
||||||
if not unowned_runs:
|
|
||||||
print("No unowned runs found.")
|
|
||||||
return
|
|
||||||
|
|
||||||
print(f"\nFound {len(unowned_runs)} unowned run(s):")
|
|
||||||
for run_id, run_name in unowned_runs:
|
|
||||||
print(f" - [{run_id}] {run_name}")
|
|
||||||
|
|
||||||
# Confirm action
|
|
||||||
confirm = input(f"\nAssign all {len(unowned_runs)} runs to this user? [y/N] ")
|
|
||||||
if confirm.lower() != "y":
|
|
||||||
print("Aborted.")
|
|
||||||
return
|
|
||||||
|
|
||||||
# Perform the update
|
|
||||||
await session.execute(
|
|
||||||
update(NuzlockeRun)
|
|
||||||
.where(NuzlockeRun.owner_id.is_(None))
|
|
||||||
.values(owner_id=user_id)
|
|
||||||
)
|
|
||||||
await session.commit()
|
|
||||||
|
|
||||||
print(f"\nAssigned {len(unowned_runs)} run(s) to user {user.email}")
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
|
||||||
if len(sys.argv) != 2:
|
|
||||||
print("Usage: python scripts/assign_unowned_runs.py <user_uuid>")
|
|
||||||
print("\nExample:")
|
|
||||||
print(" uv run python scripts/assign_unowned_runs.py 550e8400-e29b-41d4-a716-446655440000")
|
|
||||||
sys.exit(1)
|
|
||||||
|
|
||||||
asyncio.run(main(sys.argv[1]))
|
|
||||||
@@ -1,187 +0,0 @@
|
|||||||
#!/usr/bin/env python3
|
|
||||||
"""Fetch moves and abilities from PokeAPI and save as seed data JSON files.
|
|
||||||
|
|
||||||
Usage:
|
|
||||||
cd backend && uv run python scripts/fetch_moves_abilities.py
|
|
||||||
|
|
||||||
This script fetches all moves and abilities from PokeAPI, extracts their names
|
|
||||||
and introduced generation, and saves them to the seed data directory.
|
|
||||||
"""
|
|
||||||
|
|
||||||
import asyncio
|
|
||||||
import json
|
|
||||||
import re
|
|
||||||
from pathlib import Path
|
|
||||||
|
|
||||||
import httpx
|
|
||||||
|
|
||||||
DATA_DIR = Path(__file__).parent.parent / "src" / "app" / "seeds" / "data"
|
|
||||||
POKEAPI_BASE = "https://pokeapi.co/api/v2"
|
|
||||||
|
|
||||||
# Map generation names to numbers
|
|
||||||
GEN_MAP = {
|
|
||||||
"generation-i": 1,
|
|
||||||
"generation-ii": 2,
|
|
||||||
"generation-iii": 3,
|
|
||||||
"generation-iv": 4,
|
|
||||||
"generation-v": 5,
|
|
||||||
"generation-vi": 6,
|
|
||||||
"generation-vii": 7,
|
|
||||||
"generation-viii": 8,
|
|
||||||
"generation-ix": 9,
|
|
||||||
}
|
|
||||||
|
|
||||||
|
|
||||||
def title_case_name(name: str) -> str:
|
|
||||||
"""Convert a hyphenated PokeAPI name to title case.
|
|
||||||
|
|
||||||
Examples:
|
|
||||||
'thunder-punch' -> 'Thunder Punch'
|
|
||||||
'self-destruct' -> 'Self-Destruct'
|
|
||||||
"""
|
|
||||||
return " ".join(word.capitalize() for word in name.split("-"))
|
|
||||||
|
|
||||||
|
|
||||||
async def fetch_all_moves(client: httpx.AsyncClient) -> list[dict]:
|
|
||||||
"""Fetch all moves from PokeAPI."""
|
|
||||||
moves = []
|
|
||||||
|
|
||||||
# First, get the list of all moves
|
|
||||||
print("Fetching move list...")
|
|
||||||
url = f"{POKEAPI_BASE}/move?limit=10000"
|
|
||||||
resp = await client.get(url)
|
|
||||||
resp.raise_for_status()
|
|
||||||
data = resp.json()
|
|
||||||
|
|
||||||
move_urls = [m["url"] for m in data["results"]]
|
|
||||||
print(f"Found {len(move_urls)} moves")
|
|
||||||
|
|
||||||
# Fetch each move's details in batches
|
|
||||||
batch_size = 50
|
|
||||||
for i in range(0, len(move_urls), batch_size):
|
|
||||||
batch = move_urls[i : i + batch_size]
|
|
||||||
print(f"Fetching moves {i + 1}-{min(i + batch_size, len(move_urls))}...")
|
|
||||||
|
|
||||||
tasks = [client.get(url) for url in batch]
|
|
||||||
responses = await asyncio.gather(*tasks, return_exceptions=True)
|
|
||||||
|
|
||||||
for resp in responses:
|
|
||||||
if isinstance(resp, Exception):
|
|
||||||
print(f" Error fetching move: {resp}")
|
|
||||||
continue
|
|
||||||
if resp.status_code != 200:
|
|
||||||
print(f" HTTP {resp.status_code} for {resp.url}")
|
|
||||||
continue
|
|
||||||
|
|
||||||
move_data = resp.json()
|
|
||||||
gen_name = move_data["generation"]["name"]
|
|
||||||
introduced_gen = GEN_MAP.get(gen_name)
|
|
||||||
|
|
||||||
if introduced_gen is None:
|
|
||||||
print(f" Unknown generation: {gen_name} for move {move_data['name']}")
|
|
||||||
continue
|
|
||||||
|
|
||||||
# Get type if available
|
|
||||||
move_type = None
|
|
||||||
if move_data.get("type"):
|
|
||||||
move_type = move_data["type"]["name"]
|
|
||||||
|
|
||||||
moves.append(
|
|
||||||
{
|
|
||||||
"name": title_case_name(move_data["name"]),
|
|
||||||
"introduced_gen": introduced_gen,
|
|
||||||
"type": move_type,
|
|
||||||
}
|
|
||||||
)
|
|
||||||
|
|
||||||
# Sort by name for consistent ordering
|
|
||||||
moves.sort(key=lambda m: m["name"])
|
|
||||||
return moves
|
|
||||||
|
|
||||||
|
|
||||||
async def fetch_all_abilities(client: httpx.AsyncClient) -> list[dict]:
|
|
||||||
"""Fetch all abilities from PokeAPI."""
|
|
||||||
abilities = []
|
|
||||||
|
|
||||||
# First, get the list of all abilities
|
|
||||||
print("Fetching ability list...")
|
|
||||||
url = f"{POKEAPI_BASE}/ability?limit=10000"
|
|
||||||
resp = await client.get(url)
|
|
||||||
resp.raise_for_status()
|
|
||||||
data = resp.json()
|
|
||||||
|
|
||||||
ability_urls = [a["url"] for a in data["results"]]
|
|
||||||
print(f"Found {len(ability_urls)} abilities")
|
|
||||||
|
|
||||||
# Fetch each ability's details in batches
|
|
||||||
batch_size = 50
|
|
||||||
for i in range(0, len(ability_urls), batch_size):
|
|
||||||
batch = ability_urls[i : i + batch_size]
|
|
||||||
print(f"Fetching abilities {i + 1}-{min(i + batch_size, len(ability_urls))}...")
|
|
||||||
|
|
||||||
tasks = [client.get(url) for url in batch]
|
|
||||||
responses = await asyncio.gather(*tasks, return_exceptions=True)
|
|
||||||
|
|
||||||
for resp in responses:
|
|
||||||
if isinstance(resp, Exception):
|
|
||||||
print(f" Error fetching ability: {resp}")
|
|
||||||
continue
|
|
||||||
if resp.status_code != 200:
|
|
||||||
print(f" HTTP {resp.status_code} for {resp.url}")
|
|
||||||
continue
|
|
||||||
|
|
||||||
ability_data = resp.json()
|
|
||||||
gen_name = ability_data["generation"]["name"]
|
|
||||||
introduced_gen = GEN_MAP.get(gen_name)
|
|
||||||
|
|
||||||
if introduced_gen is None:
|
|
||||||
print(
|
|
||||||
f" Unknown generation: {gen_name} for ability {ability_data['name']}"
|
|
||||||
)
|
|
||||||
continue
|
|
||||||
|
|
||||||
abilities.append(
|
|
||||||
{
|
|
||||||
"name": title_case_name(ability_data["name"]),
|
|
||||||
"introduced_gen": introduced_gen,
|
|
||||||
}
|
|
||||||
)
|
|
||||||
|
|
||||||
# Sort by name for consistent ordering
|
|
||||||
abilities.sort(key=lambda a: a["name"])
|
|
||||||
return abilities
|
|
||||||
|
|
||||||
|
|
||||||
async def main():
|
|
||||||
print("Fetching moves and abilities from PokeAPI...")
|
|
||||||
print()
|
|
||||||
|
|
||||||
async with httpx.AsyncClient(timeout=30.0) as client:
|
|
||||||
# Fetch moves
|
|
||||||
moves = await fetch_all_moves(client)
|
|
||||||
print()
|
|
||||||
|
|
||||||
# Fetch abilities
|
|
||||||
abilities = await fetch_all_abilities(client)
|
|
||||||
print()
|
|
||||||
|
|
||||||
# Write moves to JSON
|
|
||||||
moves_path = DATA_DIR / "moves.json"
|
|
||||||
with open(moves_path, "w") as f:
|
|
||||||
json.dump(moves, f, indent=2)
|
|
||||||
f.write("\n")
|
|
||||||
print(f"Wrote {len(moves)} moves to {moves_path}")
|
|
||||||
|
|
||||||
# Write abilities to JSON
|
|
||||||
abilities_path = DATA_DIR / "abilities.json"
|
|
||||||
with open(abilities_path, "w") as f:
|
|
||||||
json.dump(abilities, f, indent=2)
|
|
||||||
f.write("\n")
|
|
||||||
print(f"Wrote {len(abilities)} abilities to {abilities_path}")
|
|
||||||
|
|
||||||
print()
|
|
||||||
print("Done!")
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
|
||||||
asyncio.run(main())
|
|
||||||
@@ -1,46 +0,0 @@
|
|||||||
"""add moves and abilities tables
|
|
||||||
|
|
||||||
Revision ID: j1e2f3a4b5c6
|
|
||||||
Revises: i0d1e2f3a4b5
|
|
||||||
Create Date: 2026-03-20 12:00:00.000000
|
|
||||||
|
|
||||||
"""
|
|
||||||
|
|
||||||
from collections.abc import Sequence
|
|
||||||
|
|
||||||
import sqlalchemy as sa
|
|
||||||
from alembic import op
|
|
||||||
|
|
||||||
# revision identifiers, used by Alembic.
|
|
||||||
revision: str = "j1e2f3a4b5c6"
|
|
||||||
down_revision: str | Sequence[str] | None = "i0d1e2f3a4b5"
|
|
||||||
branch_labels: str | Sequence[str] | None = None
|
|
||||||
depends_on: str | Sequence[str] | None = None
|
|
||||||
|
|
||||||
|
|
||||||
def upgrade() -> None:
|
|
||||||
# Create moves table
|
|
||||||
op.create_table(
|
|
||||||
"moves",
|
|
||||||
sa.Column("id", sa.Integer(), primary_key=True),
|
|
||||||
sa.Column("name", sa.String(50), nullable=False, unique=True),
|
|
||||||
sa.Column("introduced_gen", sa.SmallInteger(), nullable=False),
|
|
||||||
sa.Column("type", sa.String(20), nullable=True),
|
|
||||||
)
|
|
||||||
op.create_index("ix_moves_introduced_gen", "moves", ["introduced_gen"])
|
|
||||||
|
|
||||||
# Create abilities table
|
|
||||||
op.create_table(
|
|
||||||
"abilities",
|
|
||||||
sa.Column("id", sa.Integer(), primary_key=True),
|
|
||||||
sa.Column("name", sa.String(50), nullable=False, unique=True),
|
|
||||||
sa.Column("introduced_gen", sa.SmallInteger(), nullable=False),
|
|
||||||
)
|
|
||||||
op.create_index("ix_abilities_introduced_gen", "abilities", ["introduced_gen"])
|
|
||||||
|
|
||||||
|
|
||||||
def downgrade() -> None:
|
|
||||||
op.drop_index("ix_abilities_introduced_gen", "abilities")
|
|
||||||
op.drop_table("abilities")
|
|
||||||
op.drop_index("ix_moves_introduced_gen", "moves")
|
|
||||||
op.drop_table("moves")
|
|
||||||
@@ -1,63 +0,0 @@
|
|||||||
"""add journal entries table
|
|
||||||
|
|
||||||
Revision ID: k2f3a4b5c6d7
|
|
||||||
Revises: j1e2f3a4b5c6
|
|
||||||
Create Date: 2026-03-20 12:00:00.000000
|
|
||||||
|
|
||||||
"""
|
|
||||||
|
|
||||||
from collections.abc import Sequence
|
|
||||||
|
|
||||||
import sqlalchemy as sa
|
|
||||||
from alembic import op
|
|
||||||
|
|
||||||
# revision identifiers, used by Alembic.
|
|
||||||
revision: str = "k2f3a4b5c6d7"
|
|
||||||
down_revision: str | Sequence[str] | None = "j1e2f3a4b5c6"
|
|
||||||
branch_labels: str | Sequence[str] | None = None
|
|
||||||
depends_on: str | Sequence[str] | None = None
|
|
||||||
|
|
||||||
|
|
||||||
def upgrade() -> None:
|
|
||||||
op.create_table(
|
|
||||||
"journal_entries",
|
|
||||||
sa.Column(
|
|
||||||
"id",
|
|
||||||
sa.UUID(),
|
|
||||||
primary_key=True,
|
|
||||||
server_default=sa.text("gen_random_uuid()"),
|
|
||||||
),
|
|
||||||
sa.Column(
|
|
||||||
"run_id",
|
|
||||||
sa.Integer(),
|
|
||||||
sa.ForeignKey("nuzlocke_runs.id", ondelete="CASCADE"),
|
|
||||||
nullable=False,
|
|
||||||
index=True,
|
|
||||||
),
|
|
||||||
sa.Column(
|
|
||||||
"boss_result_id",
|
|
||||||
sa.Integer(),
|
|
||||||
sa.ForeignKey("boss_results.id", ondelete="SET NULL"),
|
|
||||||
nullable=True,
|
|
||||||
index=True,
|
|
||||||
),
|
|
||||||
sa.Column("title", sa.String(200), nullable=False),
|
|
||||||
sa.Column("body", sa.Text(), nullable=False),
|
|
||||||
sa.Column(
|
|
||||||
"created_at",
|
|
||||||
sa.DateTime(timezone=True),
|
|
||||||
nullable=False,
|
|
||||||
server_default=sa.func.now(),
|
|
||||||
),
|
|
||||||
sa.Column(
|
|
||||||
"updated_at",
|
|
||||||
sa.DateTime(timezone=True),
|
|
||||||
nullable=False,
|
|
||||||
server_default=sa.func.now(),
|
|
||||||
onupdate=sa.func.now(),
|
|
||||||
),
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def downgrade() -> None:
|
|
||||||
op.drop_table("journal_entries")
|
|
||||||
@@ -1,62 +0,0 @@
|
|||||||
"""add boss pokemon details
|
|
||||||
|
|
||||||
Revision ID: l3a4b5c6d7e8
|
|
||||||
Revises: k2f3a4b5c6d7
|
|
||||||
Create Date: 2026-03-20 19:30:00.000000
|
|
||||||
|
|
||||||
"""
|
|
||||||
|
|
||||||
from collections.abc import Sequence
|
|
||||||
|
|
||||||
import sqlalchemy as sa
|
|
||||||
from alembic import op
|
|
||||||
|
|
||||||
# revision identifiers, used by Alembic.
|
|
||||||
revision: str = "l3a4b5c6d7e8"
|
|
||||||
down_revision: str | Sequence[str] | None = "k2f3a4b5c6d7"
|
|
||||||
branch_labels: str | Sequence[str] | None = None
|
|
||||||
depends_on: str | Sequence[str] | None = None
|
|
||||||
|
|
||||||
|
|
||||||
def upgrade() -> None:
|
|
||||||
# Add ability reference
|
|
||||||
op.add_column(
|
|
||||||
"boss_pokemon",
|
|
||||||
sa.Column(
|
|
||||||
"ability_id", sa.Integer(), sa.ForeignKey("abilities.id"), nullable=True
|
|
||||||
),
|
|
||||||
)
|
|
||||||
op.create_index("ix_boss_pokemon_ability_id", "boss_pokemon", ["ability_id"])
|
|
||||||
|
|
||||||
# Add held item (plain string)
|
|
||||||
op.add_column(
|
|
||||||
"boss_pokemon",
|
|
||||||
sa.Column("held_item", sa.String(50), nullable=True),
|
|
||||||
)
|
|
||||||
|
|
||||||
# Add nature (plain string)
|
|
||||||
op.add_column(
|
|
||||||
"boss_pokemon",
|
|
||||||
sa.Column("nature", sa.String(20), nullable=True),
|
|
||||||
)
|
|
||||||
|
|
||||||
# Add move references (up to 4 moves)
|
|
||||||
for i in range(1, 5):
|
|
||||||
op.add_column(
|
|
||||||
"boss_pokemon",
|
|
||||||
sa.Column(
|
|
||||||
f"move{i}_id", sa.Integer(), sa.ForeignKey("moves.id"), nullable=True
|
|
||||||
),
|
|
||||||
)
|
|
||||||
op.create_index(f"ix_boss_pokemon_move{i}_id", "boss_pokemon", [f"move{i}_id"])
|
|
||||||
|
|
||||||
|
|
||||||
def downgrade() -> None:
|
|
||||||
for i in range(1, 5):
|
|
||||||
op.drop_index(f"ix_boss_pokemon_move{i}_id", "boss_pokemon")
|
|
||||||
op.drop_column("boss_pokemon", f"move{i}_id")
|
|
||||||
|
|
||||||
op.drop_column("boss_pokemon", "nature")
|
|
||||||
op.drop_column("boss_pokemon", "held_item")
|
|
||||||
op.drop_index("ix_boss_pokemon_ability_id", "boss_pokemon")
|
|
||||||
op.drop_column("boss_pokemon", "ability_id")
|
|
||||||
@@ -1,44 +0,0 @@
|
|||||||
"""add boss result team
|
|
||||||
|
|
||||||
Revision ID: m4b5c6d7e8f9
|
|
||||||
Revises: l3a4b5c6d7e8
|
|
||||||
Create Date: 2026-03-20 20:00:00.000000
|
|
||||||
|
|
||||||
"""
|
|
||||||
|
|
||||||
from collections.abc import Sequence
|
|
||||||
|
|
||||||
import sqlalchemy as sa
|
|
||||||
from alembic import op
|
|
||||||
|
|
||||||
# revision identifiers, used by Alembic.
|
|
||||||
revision: str = "m4b5c6d7e8f9"
|
|
||||||
down_revision: str | Sequence[str] | None = "l3a4b5c6d7e8"
|
|
||||||
branch_labels: str | Sequence[str] | None = None
|
|
||||||
depends_on: str | Sequence[str] | None = None
|
|
||||||
|
|
||||||
|
|
||||||
def upgrade() -> None:
|
|
||||||
op.create_table(
|
|
||||||
"boss_result_team",
|
|
||||||
sa.Column("id", sa.Integer(), primary_key=True),
|
|
||||||
sa.Column(
|
|
||||||
"boss_result_id",
|
|
||||||
sa.Integer(),
|
|
||||||
sa.ForeignKey("boss_results.id", ondelete="CASCADE"),
|
|
||||||
nullable=False,
|
|
||||||
index=True,
|
|
||||||
),
|
|
||||||
sa.Column(
|
|
||||||
"encounter_id",
|
|
||||||
sa.Integer(),
|
|
||||||
sa.ForeignKey("encounters.id", ondelete="CASCADE"),
|
|
||||||
nullable=False,
|
|
||||||
index=True,
|
|
||||||
),
|
|
||||||
sa.Column("level", sa.SmallInteger(), nullable=False),
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def downgrade() -> None:
|
|
||||||
op.drop_table("boss_result_team")
|
|
||||||
@@ -1,37 +0,0 @@
|
|||||||
"""create users table
|
|
||||||
|
|
||||||
Revision ID: n5c6d7e8f9a0
|
|
||||||
Revises: m4b5c6d7e8f9
|
|
||||||
Create Date: 2026-03-20 22:00:00.000000
|
|
||||||
|
|
||||||
"""
|
|
||||||
|
|
||||||
from collections.abc import Sequence
|
|
||||||
|
|
||||||
import sqlalchemy as sa
|
|
||||||
from alembic import op
|
|
||||||
|
|
||||||
# revision identifiers, used by Alembic.
|
|
||||||
revision: str = "n5c6d7e8f9a0"
|
|
||||||
down_revision: str | Sequence[str] | None = "m4b5c6d7e8f9"
|
|
||||||
branch_labels: str | Sequence[str] | None = None
|
|
||||||
depends_on: str | Sequence[str] | None = None
|
|
||||||
|
|
||||||
|
|
||||||
def upgrade() -> None:
|
|
||||||
op.create_table(
|
|
||||||
"users",
|
|
||||||
sa.Column("id", sa.UUID(), primary_key=True),
|
|
||||||
sa.Column("email", sa.String(255), nullable=False, unique=True, index=True),
|
|
||||||
sa.Column("display_name", sa.String(100), nullable=True),
|
|
||||||
sa.Column(
|
|
||||||
"created_at",
|
|
||||||
sa.DateTime(timezone=True),
|
|
||||||
nullable=False,
|
|
||||||
server_default=sa.func.now(),
|
|
||||||
),
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def downgrade() -> None:
|
|
||||||
op.drop_table("users")
|
|
||||||
@@ -1,60 +0,0 @@
|
|||||||
"""add owner_id and visibility to runs
|
|
||||||
|
|
||||||
Revision ID: o6d7e8f9a0b1
|
|
||||||
Revises: n5c6d7e8f9a0
|
|
||||||
Create Date: 2026-03-20 22:01:00.000000
|
|
||||||
|
|
||||||
"""
|
|
||||||
|
|
||||||
from collections.abc import Sequence
|
|
||||||
|
|
||||||
import sqlalchemy as sa
|
|
||||||
from alembic import op
|
|
||||||
|
|
||||||
# revision identifiers, used by Alembic.
|
|
||||||
revision: str = "o6d7e8f9a0b1"
|
|
||||||
down_revision: str | Sequence[str] | None = "n5c6d7e8f9a0"
|
|
||||||
branch_labels: str | Sequence[str] | None = None
|
|
||||||
depends_on: str | Sequence[str] | None = None
|
|
||||||
|
|
||||||
|
|
||||||
def upgrade() -> None:
|
|
||||||
# Create visibility enum
|
|
||||||
visibility_enum = sa.Enum("public", "private", name="run_visibility")
|
|
||||||
visibility_enum.create(op.get_bind(), checkfirst=True)
|
|
||||||
|
|
||||||
# Add owner_id (nullable FK to users)
|
|
||||||
op.add_column(
|
|
||||||
"nuzlocke_runs",
|
|
||||||
sa.Column("owner_id", sa.UUID(), nullable=True),
|
|
||||||
)
|
|
||||||
op.create_foreign_key(
|
|
||||||
"fk_nuzlocke_runs_owner_id",
|
|
||||||
"nuzlocke_runs",
|
|
||||||
"users",
|
|
||||||
["owner_id"],
|
|
||||||
["id"],
|
|
||||||
ondelete="SET NULL",
|
|
||||||
)
|
|
||||||
op.create_index("ix_nuzlocke_runs_owner_id", "nuzlocke_runs", ["owner_id"])
|
|
||||||
|
|
||||||
# Add visibility column with default 'public'
|
|
||||||
op.add_column(
|
|
||||||
"nuzlocke_runs",
|
|
||||||
sa.Column(
|
|
||||||
"visibility",
|
|
||||||
visibility_enum,
|
|
||||||
nullable=False,
|
|
||||||
server_default="public",
|
|
||||||
),
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def downgrade() -> None:
|
|
||||||
op.drop_column("nuzlocke_runs", "visibility")
|
|
||||||
op.drop_index("ix_nuzlocke_runs_owner_id", table_name="nuzlocke_runs")
|
|
||||||
op.drop_constraint("fk_nuzlocke_runs_owner_id", "nuzlocke_runs", type_="foreignkey")
|
|
||||||
op.drop_column("nuzlocke_runs", "owner_id")
|
|
||||||
|
|
||||||
# Drop the enum type
|
|
||||||
sa.Enum(name="run_visibility").drop(op.get_bind(), checkfirst=True)
|
|
||||||
@@ -1,29 +0,0 @@
|
|||||||
"""add is_admin to users
|
|
||||||
|
|
||||||
Revision ID: p7e8f9a0b1c2
|
|
||||||
Revises: o6d7e8f9a0b1
|
|
||||||
Create Date: 2026-03-21 10:00:00.000000
|
|
||||||
|
|
||||||
"""
|
|
||||||
|
|
||||||
from collections.abc import Sequence
|
|
||||||
|
|
||||||
import sqlalchemy as sa
|
|
||||||
from alembic import op
|
|
||||||
|
|
||||||
# revision identifiers, used by Alembic.
|
|
||||||
revision: str = "p7e8f9a0b1c2"
|
|
||||||
down_revision: str | Sequence[str] | None = "o6d7e8f9a0b1"
|
|
||||||
branch_labels: str | Sequence[str] | None = None
|
|
||||||
depends_on: str | Sequence[str] | None = None
|
|
||||||
|
|
||||||
|
|
||||||
def upgrade() -> None:
|
|
||||||
op.add_column(
|
|
||||||
"users",
|
|
||||||
sa.Column("is_admin", sa.Boolean(), nullable=False, server_default="false"),
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def downgrade() -> None:
|
|
||||||
op.drop_column("users", "is_admin")
|
|
||||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user